From: Greg KH <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: outreachy-kernel@googlegroups.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [Patch 0/3]
Date: Sat, 10 Apr 2021 10:04:51 +0200 [thread overview]
Message-ID: <YHFcI104K+ih3UDG@kroah.com> (raw)
In-Reply-To: <2101069.1PIH1tPmJ7@localhost.localdomain>
On Sat, Apr 10, 2021 at 09:57:00AM +0200, Fabio M. De Francesco wrote:
> On Saturday, April 10, 2021 9:29:29 AM CEST Greg KH wrote:
> > On Fri, Apr 09, 2021 at 06:29:59PM +0200, Fabio M. De Francesco wrote:
> > > This patch series removes camelcases, changes the type and use of a
> > > variable, and correct misspelled words.
> > >
> > > Patch 1/3: staging: rtl8723bs: Remove camelcase in several files
> > >
> > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> > > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
> > > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 +++++++++---------
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > > drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 6 +++---
> > > .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +-
> > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 14 +++++++-------
> > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 8 files changed, 24 insertions(+), 24 deletions(-)
> > >
> > > Patch 2/3: staging: rtl8723bs: Change the type and use of a variable
> > >
> > > drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +-
> > >
> > > drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > Patch 3/3: staging: rtl8723bs: include: Fix misspelled words in
> > > comments
> > >
> > > .../rtl8723bs/include/Hal8192CPhyReg.h | 8 ++---
> > >
> > > .../staging/rtl8723bs/include/basic_types.h | 2 +-
> > > drivers/staging/rtl8723bs/include/drv_types.h | 2 +-
> > > drivers/staging/rtl8723bs/include/hal_com.h | 2 +-
> > > .../staging/rtl8723bs/include/hal_com_reg.h | 34 +++++++++----------
> > > drivers/staging/rtl8723bs/include/hal_data.h | 2 +-
> > > .../staging/rtl8723bs/include/hal_pwr_seq.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_cmd.h | 6 ++--
> > > drivers/staging/rtl8723bs/include/rtw_mlme.h | 18 +++++-----
> > > .../staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_mp.h | 2 +-
> > > .../staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +-
> > > drivers/staging/rtl8723bs/include/rtw_recv.h | 4 +--
> > > drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
> > > drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
> > > drivers/staging/rtl8723bs/include/wifi.h | 2 +-
> > > 16 files changed, 46 insertions(+), 46 deletions(-)
> > >
> > > Fabio M. De Francesco
> >
> > I have no idea how you created this patch series, but I do not think it
> > worked well :(
> >
> > Please use our standard tools, that do this all for you automatically,
> >
> Apart from the fact that I forgot to save the subject, I didn't know that
> there are standard tools for doing Patch 0/N. Therefore I thought to make
> an email message that contained the information about the patch series.
>
> I was wrong, sorry. I have to research this topic in the git manual or
> somewhere else.
'git format-patch --cover-letter main..HEAD' will to the trick, if you
are on a different branch from 'main'. Then edit the 0000-* file and
then send them all off with 'git send-email'.
thanks,
greg k-h
next prev parent reply other threads:[~2021-04-10 8:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 16:29 [Outreachy kernel] [Patch 0/3] Fabio M. De Francesco
2021-04-10 7:29 ` Greg KH
2021-04-10 7:57 ` Fabio M. De Francesco
2021-04-10 8:04 ` Greg KH [this message]
2021-04-10 8:22 ` Julia Lawall
2021-04-10 8:20 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHFcI104K+ih3UDG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.