From: Mitali Borkar <mitaliborkar810@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: sakari.ailus@linux.intel.com, bingbu.cao@intel.com,
tian.shu.qiu@intel.com, mchehab@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com, mitali_s@me.iitr.ac.in
Subject: Re: [PATCH v3 4/4] staging: media: intel-ipu3: remove space before tabs
Date: Wed, 14 Apr 2021 01:26:57 +0530 [thread overview]
Message-ID: <YHX3iVCNXJlOsmuQ@kali> (raw)
In-Reply-To: <20210413181712.GI6021@kadam>
On Tue, Apr 13, 2021 at 09:17:12PM +0300, Dan Carpenter wrote:
> On Tue, Apr 13, 2021 at 08:59:34PM +0530, Mitali Borkar wrote:
> > Removed unnecessary space before tabs to adhere to linux kernel coding
> > style.
> > Reported by checkpatch.
> >
> > Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> > ---
> >
> > Changes from v2:- No changes.
> > Changes from v1:- No changes.
> >
> > drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h b/drivers/staging/media/ipu3/include/intel-ipu3.h
> > index 47e98979683c..42edac5ee4e4 100644
> > --- a/drivers/staging/media/ipu3/include/intel-ipu3.h
> > +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h
> > @@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config {
> > * @cg: Gain coefficient for threshold calculation, [0, 31], default 8.
> > * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f]
> > * default 6.
> > - * format: u3.2 (3 most significant bits represent whole number,
> > + *format: u3.2 (3 most significant bits represent whole number,
> > * 2 least significant bits represent the fractional part
>
> Just remove the spaces, don't remove the tab. It's looks silly now.
>
Okay Sir, do I have to send a v4 patch on this now?
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2021-04-13 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 15:28 [PATCH v3 0/4] staging: media: intel-ipu3: Cleanup patchset for style issues Mitali Borkar
2021-04-13 15:28 ` [PATCH v3 1/4] staging: media: intel-ipu3: remove unnecessary blank line Mitali Borkar
2021-04-13 15:28 ` [PATCH v3 2/4] staging: media: intel-ipu3: reduce length of line Mitali Borkar
2021-04-13 15:29 ` [PATCH v3 3/4] staging: media: intel-ipu3: line should not end with '[' Mitali Borkar
2021-04-13 15:29 ` [PATCH v3 4/4] staging: media: intel-ipu3: remove space before tabs Mitali Borkar
2021-04-13 18:17 ` Dan Carpenter
2021-04-13 19:56 ` Mitali Borkar [this message]
2021-04-13 22:05 ` [Outreachy kernel] " Julia Lawall
2021-04-14 7:27 ` Sakari Ailus
2021-04-13 16:21 ` [PATCH v3 0/4] staging: media: intel-ipu3: Cleanup patchset for style issues Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHX3iVCNXJlOsmuQ@kali \
--to=mitaliborkar810@gmail.com \
--cc=bingbu.cao@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mitali_s@me.iitr.ac.in \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.