From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C2AEC433B4 for ; Tue, 13 Apr 2021 17:12:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 305E5613B1 for ; Tue, 13 Apr 2021 17:12:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 305E5613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B1C0F6E851; Tue, 13 Apr 2021 17:12:42 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 702006E851 for ; Tue, 13 Apr 2021 17:12:41 +0000 (UTC) IronPort-SDR: msC5aVUKv7laqO7orul9lnAa0UUM50XVn2uK61Pu15OLFHvBu8VqDP1iN9NU7KkvrmjL+bA0MJ HjiKvrh/nnUA== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="194026431" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="194026431" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 10:12:40 -0700 IronPort-SDR: BkAUe+MpFzDxyYJeQTIpnGz61Y/DTynrZftNxnCZ+0WvTAG1D5cEa4uz9bnE1LUZGvkorkxzi9 KEkIA3dTv87g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="420860693" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga007.jf.intel.com with SMTP; 13 Apr 2021 10:12:37 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 13 Apr 2021 20:12:37 +0300 Date: Tue, 13 Apr 2021 20:12:37 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Message-ID: References: <20210412232413.2755054-1-imre.deak@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210412232413.2755054-1-imre.deak@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix modesetting in case of unexpected AUX timeouts X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Apr 13, 2021 at 02:24:12AM +0300, Imre Deak wrote: > In case AUX failures happen unexpectedly during a modeset, the driver > should still complete the modeset. In particular the driver should > perform the link training sequence steps even in case of an AUX failure, > as this sequence also includes port initialization steps. Not doing that > can leave the port/pipe in a broken state and lead for instance to a > flip done timeout. > = > Fix this by continuing with link training (in a no-LTTPR mode) if the > DPRX DPCD readout failed for some reason at the beginning of link > training. After a successful connector detection we already have the > DPCD read out and cached, so the failed repeated read for it should not > cause a problem. Note that a partial AUX read could in theory partly > overwrite the cached DPCD (and return error) but this overwrite should > not happen if the returned values are corrupted (due to a timeout or > some other IO error). > = > Kudos to Ville to root cause the problem. > = > Fixes: 7dffbdedb96a ("drm/i915: Disable LTTPR support when the DPCD rev <= 1.4") > References: https://gitlab.freedesktop.org/drm/intel/-/issues/3308 > Cc: stable@vger.kernel.org # 5.11 > Cc: Ville Syrj=E4l=E4 > Signed-off-by: Imre Deak Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/driv= ers/gpu/drm/i915/display/intel_dp_link_training.c > index 5e9c3c74310ca..cbcfb0c4c3708 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -882,7 +882,8 @@ void intel_dp_start_link_train(struct intel_dp *intel= _dp, > int lttpr_count =3D intel_dp_init_lttpr_and_dprx_caps(intel_dp); > = > if (lttpr_count < 0) > - return; > + /* Still continue with enabling the port and link training. */ > + lttpr_count =3D 0; > = > if (!intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count)) > intel_dp_schedule_fallback_link_training(intel_dp, crtc_state); > -- = > 2.27.0 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917B8C433B4 for ; Tue, 13 Apr 2021 17:12:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EC2F610C8 for ; Tue, 13 Apr 2021 17:12:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232428AbhDMRNH (ORCPT ); Tue, 13 Apr 2021 13:13:07 -0400 Received: from mga09.intel.com ([134.134.136.24]:5325 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230074AbhDMRNG (ORCPT ); Tue, 13 Apr 2021 13:13:06 -0400 IronPort-SDR: 334a9r7qWr2nFSvRDED3Z/gZhFCe4m5EWvVIuWWh4mTG/7jThTwV2OxYSxecq6KsJkTlpYn8Er p8aRcqIh1+PA== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="194573803" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="194573803" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 10:12:40 -0700 IronPort-SDR: BkAUe+MpFzDxyYJeQTIpnGz61Y/DTynrZftNxnCZ+0WvTAG1D5cEa4uz9bnE1LUZGvkorkxzi9 KEkIA3dTv87g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="420860693" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga007.jf.intel.com with SMTP; 13 Apr 2021 10:12:37 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 13 Apr 2021 20:12:37 +0300 Date: Tue, 13 Apr 2021 20:12:37 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] drm/i915: Fix modesetting in case of unexpected AUX timeouts Message-ID: References: <20210412232413.2755054-1-imre.deak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210412232413.2755054-1-imre.deak@intel.com> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 13, 2021 at 02:24:12AM +0300, Imre Deak wrote: > In case AUX failures happen unexpectedly during a modeset, the driver > should still complete the modeset. In particular the driver should > perform the link training sequence steps even in case of an AUX failure, > as this sequence also includes port initialization steps. Not doing that > can leave the port/pipe in a broken state and lead for instance to a > flip done timeout. > > Fix this by continuing with link training (in a no-LTTPR mode) if the > DPRX DPCD readout failed for some reason at the beginning of link > training. After a successful connector detection we already have the > DPCD read out and cached, so the failed repeated read for it should not > cause a problem. Note that a partial AUX read could in theory partly > overwrite the cached DPCD (and return error) but this overwrite should > not happen if the returned values are corrupted (due to a timeout or > some other IO error). > > Kudos to Ville to root cause the problem. > > Fixes: 7dffbdedb96a ("drm/i915: Disable LTTPR support when the DPCD rev < 1.4") > References: https://gitlab.freedesktop.org/drm/intel/-/issues/3308 > Cc: stable@vger.kernel.org # 5.11 > Cc: Ville Syrjälä > Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > index 5e9c3c74310ca..cbcfb0c4c3708 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c > @@ -882,7 +882,8 @@ void intel_dp_start_link_train(struct intel_dp *intel_dp, > int lttpr_count = intel_dp_init_lttpr_and_dprx_caps(intel_dp); > > if (lttpr_count < 0) > - return; > + /* Still continue with enabling the port and link training. */ > + lttpr_count = 0; > > if (!intel_dp_link_train_all_phys(intel_dp, crtc_state, lttpr_count)) > intel_dp_schedule_fallback_link_training(intel_dp, crtc_state); > -- > 2.27.0 -- Ville Syrjälä Intel