From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA8BC43461 for ; Wed, 14 Apr 2021 15:01:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFA2D610CE for ; Wed, 14 Apr 2021 15:01:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232468AbhDNPBz (ORCPT ); Wed, 14 Apr 2021 11:01:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232373AbhDNPBx (ORCPT ); Wed, 14 Apr 2021 11:01:53 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 468C6C06175F for ; Wed, 14 Apr 2021 08:01:32 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id i16-20020a9d68d00000b0290286edfdfe9eso8975657oto.3 for ; Wed, 14 Apr 2021 08:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pWUtMV31lAE/hyg87N7iEfJU2y6qay0uOr7HTCluXiQ=; b=weX1bUpjRw6wuytQJlFfHNsn28nJPkkHmgBmJw8yPf3L2dHbbM5kfw3GHxlJBh1DyO BJkCg2eP4j3uyTHTdQaKSyyrOp+Fdowe+89rwe7wEGQbQm73jyYQTJ7L9wx49d6igFYd vbmQpzTiwPwqdGDeylnvV3vHpL+PWpFnvnzhRJ+IDnGQvkvXtwuLb+d5yUV9tHJCFx7s bOw6rogRUZEzwOFKIQ91VGxbwbpZd7+mDC+GgCrvp1IoZyasKbedKt0fyfNtq6M1NaxO 7QzGAS3TRRrj5hg+1RxcPnAG82mKMruMgDVEaVQhzyw4zOZpmht7sd/ADU718gXGHYFJ +Udg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pWUtMV31lAE/hyg87N7iEfJU2y6qay0uOr7HTCluXiQ=; b=GZkG2bdbX46LKOp3ivgyf6FwvvIri8hax5uHUtU6SDY+U7tfZzhYVQB83NNcmT8xyk TTDaDKb/WHEJaRL6EjHgUTOfphvRf0tuTdFGpYIyFdD+Wi3oUtKh0dp14i888prmfffh kxeeKL9zoFD3zmma6BGvZcGEIvvDyGM1Cn2KQ8Bh9LCFTtnElIrAUn2LeVSYPca+0rhs vwL9I7IZkiEYGvyAWfVGh92cXpd0wW+VhK3iTGhegJW1GkKtF/L441m7HtPwV3mKO0qQ fLTFaFLrIBcRABB+9S+14tii7/OPR8q9pDwjgTivPWTRvvpaouEwSSlcRs+2h1TvimpY 7azQ== X-Gm-Message-State: AOAM531GEAMH54y5mwzS+ztJ6fFiJoQnI5f26A/+AtpmbEZ+YKveQqAg DJRM/qqKD6UkhFqH8AYPVcI57g== X-Google-Smtp-Source: ABdhPJxDtOsCeDQQ/deHM1lftmwj2WSD1eWrJZcD1R9B4e21VGSd2wMo678cp9rC6umgF66U/MAcWg== X-Received: by 2002:a9d:7f9a:: with SMTP id t26mr2801371otp.363.1618412491567; Wed, 14 Apr 2021 08:01:31 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z25sm337558otm.34.2021.04.14.08.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 08:01:31 -0700 (PDT) Date: Wed, 14 Apr 2021 10:01:29 -0500 From: Bjorn Andersson To: Arnaud POULIQUEN Cc: Ohad Ben-Cohen , Mathieu Poirier , Rob Herring , Alexandre Torgue , devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] remoteproc: stm32: add capability to detach Message-ID: References: <20210331073347.8293-1-arnaud.pouliquen@foss.st.com> <20210331073347.8293-3-arnaud.pouliquen@foss.st.com> <3df5317b-d28a-9362-6876-99442fdb8ef5@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3df5317b-d28a-9362-6876-99442fdb8ef5@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Wed 14 Apr 02:23 CDT 2021, Arnaud POULIQUEN wrote: > On 4/13/21 11:34 PM, Bjorn Andersson wrote: > > On Wed 31 Mar 02:33 CDT 2021, Arnaud Pouliquen wrote: [..] > >> + err = mbox_send_message(ddata->mb[idx].chan, > >> + &dummy_data); > > > > Seems I posted my comment on v1, rather than this latest version. Please > > let me know if we should do anything about this dummy_data. > > Thanks for pointing this out, you are right, the mailbox driver is stm32_ipcc > and it only sends a signal to the remote processor. > > As message can be queued by the mailbox framework using a local variable seems > not a good option. As this code is a copy/past of the kick and stop? > I propose to get this one and I will send a new patch to fix the usage in the > whole driver. > That works for me, I've merged the two patches. Thanks, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C12A9C433B4 for ; Wed, 14 Apr 2021 15:03:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B554610FA for ; Wed, 14 Apr 2021 15:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B554610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wb+K2i6v5Glj0xaWvyOOdTJMbk5qJq3ZAZGePHwI+a0=; b=a/knK5hS74f6VfWygx+xmecqh mRGS3YLvVf1pVonya8sneV7RPfBF2n+kr6gTKsFBzLAhNqrNLOveu7eJIJqt0YThQpxNVCTAdRLeE ty9eZpKSRf3A970CfnujsNkf0h2v50Ve895Nxfc6Km42ix7Vtp6i7mNVY54H5puuYn7NNkseNEoR7 oVpCcCzU1ObCCBvDd7VnT5ftKMsMVCa516Vx1uobhoSpo9l3IKrpkex1v7xRK4S4KUe/9ITnn5NSw 3ESHi2OcOw0eUS6jrRaCZHHnboOKi+JVpnAw2GtnbT3Y0PVvy3ZHxW3AtlG3OsYTd481CkvsQgQfN odlq8/klw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWh1S-00CyFT-TJ; Wed, 14 Apr 2021 15:01:43 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWh1N-00CyF3-Br for linux-arm-kernel@desiato.infradead.org; Wed, 14 Apr 2021 15:01:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pWUtMV31lAE/hyg87N7iEfJU2y6qay0uOr7HTCluXiQ=; b=zC0wzEH91YLgQNKn+ElfZm/c2R 6zMKlolzyQFHG83anL/RkM7ZFYgAdR08toaYJ07oTxVzRhSsK4w2PwtkoXsQaoMvIifJ0UJN1M0/8 c/Mki8eKOGT21G1ziC+MC9xZ+KwUqfnRKxpZ4YM4xQulLcmBWqUaOJtjl9bVZkd2wCNKB5qfTaVaJ QJuCAnDd8IvEZnvZ6Y26kQRyOgtYuLGpxs8RB+80jLtzjTjjVbo77AM/2xtb00iTbdMxhl/CxejvJ X1rDqtUBHQASQ8PLbwws2jpSPAdtB+uNRZ22PSwg1uQIHNOPRLSRokMYyRtYGRfehVWe4P96sL00x jv8xr9tQ==; Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWh1K-007r2a-MN for linux-arm-kernel@lists.infradead.org; Wed, 14 Apr 2021 15:01:35 +0000 Received: by mail-ot1-x32f.google.com with SMTP id i16-20020a9d68d00000b0290286edfdfe9eso8975658oto.3 for ; Wed, 14 Apr 2021 08:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pWUtMV31lAE/hyg87N7iEfJU2y6qay0uOr7HTCluXiQ=; b=weX1bUpjRw6wuytQJlFfHNsn28nJPkkHmgBmJw8yPf3L2dHbbM5kfw3GHxlJBh1DyO BJkCg2eP4j3uyTHTdQaKSyyrOp+Fdowe+89rwe7wEGQbQm73jyYQTJ7L9wx49d6igFYd vbmQpzTiwPwqdGDeylnvV3vHpL+PWpFnvnzhRJ+IDnGQvkvXtwuLb+d5yUV9tHJCFx7s bOw6rogRUZEzwOFKIQ91VGxbwbpZd7+mDC+GgCrvp1IoZyasKbedKt0fyfNtq6M1NaxO 7QzGAS3TRRrj5hg+1RxcPnAG82mKMruMgDVEaVQhzyw4zOZpmht7sd/ADU718gXGHYFJ +Udg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pWUtMV31lAE/hyg87N7iEfJU2y6qay0uOr7HTCluXiQ=; b=TZM0QqH3RnCmyJoroWvk4BNJ6xEayWwDjEvZIxWErEE8scfkuhS4AP2iQxOzESo2Fg owRg6bibWuufkI7M00YcAvE+euCZ22pqRoFAZbPTbPIyGx23ybKFzOVCdnE85LD6rfE9 AONIpxY83It43qgPdjM7AxrMQylgGV7p2JfGw+TGmvnhtKqUJNHqvOUSbSXBY7hya1pd mQ48/5VDhInP/Sp1a9QHcIldyntOvInFF35Hw1FDHZIeOVvt4Si+wJEuoBvzoAUGHWSG IKKNv5Rz0+orICYSUVBZmZnmdTNljj1Pqg8alc/zDnl4xsggEqWR5jABBuyeYs86v2BN A2/A== X-Gm-Message-State: AOAM530GZiKBWz4/Y2h608uxMFYkYQuOr1dISXlNSloq7LybdqMr3lqw PGQtKTcW2p9QoXkLtf67KUOYNA== X-Google-Smtp-Source: ABdhPJxDtOsCeDQQ/deHM1lftmwj2WSD1eWrJZcD1R9B4e21VGSd2wMo678cp9rC6umgF66U/MAcWg== X-Received: by 2002:a9d:7f9a:: with SMTP id t26mr2801371otp.363.1618412491567; Wed, 14 Apr 2021 08:01:31 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z25sm337558otm.34.2021.04.14.08.01.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 08:01:31 -0700 (PDT) Date: Wed, 14 Apr 2021 10:01:29 -0500 From: Bjorn Andersson To: Arnaud POULIQUEN Cc: Ohad Ben-Cohen , Mathieu Poirier , Rob Herring , Alexandre Torgue , devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] remoteproc: stm32: add capability to detach Message-ID: References: <20210331073347.8293-1-arnaud.pouliquen@foss.st.com> <20210331073347.8293-3-arnaud.pouliquen@foss.st.com> <3df5317b-d28a-9362-6876-99442fdb8ef5@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3df5317b-d28a-9362-6876-99442fdb8ef5@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_080134_750805_8DEE8E9B X-CRM114-Status: GOOD ( 19.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 14 Apr 02:23 CDT 2021, Arnaud POULIQUEN wrote: > On 4/13/21 11:34 PM, Bjorn Andersson wrote: > > On Wed 31 Mar 02:33 CDT 2021, Arnaud Pouliquen wrote: [..] > >> + err = mbox_send_message(ddata->mb[idx].chan, > >> + &dummy_data); > > > > Seems I posted my comment on v1, rather than this latest version. Please > > let me know if we should do anything about this dummy_data. > > Thanks for pointing this out, you are right, the mailbox driver is stm32_ipcc > and it only sends a signal to the remote processor. > > As message can be queued by the mailbox framework using a local variable seems > not a good option. As this code is a copy/past of the kick and stop? > I propose to get this one and I will send a new patch to fix the usage in the > whole driver. > That works for me, I've merged the two patches. Thanks, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel