From: Jiri Olsa <jolsa@redhat.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jiri Olsa <jolsa@kernel.org>, bpf <bpf@vger.kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Kernel Team <kernel-team@fb.com>,
Sedat Dilek <sedat.dilek@gmail.com>, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH bpf-next v2 0/5] bpf: tools: support build selftests/bpf with clang
Date: Thu, 15 Apr 2021 23:39:51 +0200 [thread overview]
Message-ID: <YHiyp1lAPzosRkez@krava> (raw)
In-Reply-To: <YHh1Lzl0qS9eniT7@krava>
On Thu, Apr 15, 2021 at 07:17:35PM +0200, Jiri Olsa wrote:
> On Thu, Apr 15, 2021 at 09:55:50AM -0700, Nick Desaulniers wrote:
> > On Thu, Apr 15, 2021 at 6:23 AM Jiri Olsa <jolsa@redhat.com> wrote:
> > >
> > > On Wed, Apr 14, 2021 at 05:16:01PM -0700, Andrii Nakryiko wrote:
> > > > On Wed, Apr 14, 2021 at 6:18 AM Jiri Olsa <jolsa@redhat.com> wrote:
> > > > >
> > > > > On Tue, Apr 13, 2021 at 01:45:39PM -0700, Nick Desaulniers wrote:
> > > > >
> > > > > SNIP
> > > > >
> > > > > > > > >
> > > > > > > > > So I'm not sure precisely what's going on here. I probably have to go
> > > > > > > > > digging around to understand tools/build/feature/ anyways. With your
> > > > > > > > > v3 applied, I consistently see:
> > > > > > > > > No zlib found
> > > > > > > > > and yet, I certainly do have zlib on my host.
> > > > > > > > > https://stackoverflow.com/a/54558861
> > > > > > > >
> > > > > > > > Jiri, any tips on how to debug feature detection in
> > > > > > > > tools/build/feature/Makefile?
> > > > > > >
> > > > > > > for quick check, there's output file for each test, like:
> > > > > > >
> > > > > > > [jolsa@krava feature]$ ls -l *.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-all.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 182 Apr 9 15:52 test-bionic.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-cplus-demangle.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 145 Apr 9 15:52 test-jvmti.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-libbabeltrace.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-libbpf.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 0 Apr 8 20:25 test-libdebuginfod.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 193 Apr 9 15:52 test-libunwind-aarch64.make.output
> > > > > > > -rw-rw-r--. 1 jolsa jolsa 177 Apr 9 15:52 test-libunwind-x86.make.output
> > > > > > > [jolsa@krava feature]$ cat test-libunwind-aarch64.make.output
> > > > > > > test-libunwind-aarch64.c:2:10: fatal error: libunwind-aarch64.h: No such file or directory
> > > > > > > 2 | #include <libunwind-aarch64.h>
> > > > > > > | ^~~~~~~~~~~~~~~~~~~~~
> > > > > > > compilation terminated.
> > > > > > > [jolsa@krava feature]$ cat test-libunwind-x86.make.output
> > > > > > > test-libunwind-x86.c:2:10: fatal error: libunwind-x86.h: No such file or directory
> > > > > > > 2 | #include <libunwind-x86.h>
> > > > > > > | ^~~~~~~~~~~~~~~~~
> > > > > > >
> > > > > > > zlib should be done by:
> > > > > > > [jolsa@krava feature]$ make test-zlib.bin
> > > > > > > gcc -MD -Wall -Werror -o test-zlib.bin test-zlib.c > test-zlib.make.output 2>&1 -lz
> > > > > > >
> > > > > > >
> > > > > > > I can try to recreate, how do you build?
> > > > > >
> > > > > > See note above, I'm similarly running precisely:
> > > > > > $ make LLVM=1 LLVM_IAS=1 -j72 defconfig
> > > > > > $ make LLVM=1 LLVM_IAS=1 -j72 clean
> > > > > > $ make LLVM=1 LLVM_IAS=1 -j72 -C tools/testing/selftests/bpf
> > > > >
> > > > > for some reason I'm stuck with this error on latest bpf-next/master
> > > >
> > > > did you build vmlinux image before building selftests? those enums
> > > > should come through vmlinux.h from up-to-date vmlinux
> > >
> > > it was there.. but I found the clang/lld I compiled can't link properly,
> > > which is probably unrelated to the error below, but I need to solve it
> > > first ;-)
> >
> > Do you have more info about what command you're running, or what error
> > you're observing? The kernel itself is not linking for you?
>
> I did the commands you sent, but I might have but llvm/clang build,
> I'm rebuilding now, it takes forever..
ok, finished all commands finaly.. did not reproduce the issue :-\
any luck with those build make.output files for zlib?
jirka
next prev parent reply other threads:[~2021-04-15 21:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 14:29 [PATCH bpf-next v2 0/5] bpf: tools: support build selftests/bpf with clang Yonghong Song
2021-04-12 14:29 ` [PATCH bpf-next v2 1/5] selftests: set CC to clang in lib.mk if LLVM is set Yonghong Song
2021-04-12 14:29 ` [PATCH bpf-next v2 2/5] tools: allow proper CC/CXX/... override with LLVM=1 in Makefile.include Yonghong Song
2021-04-12 14:29 ` [PATCH bpf-next v2 3/5] selftests/bpf: fix test_cpp compilation failure with clang Yonghong Song
2021-04-12 14:29 ` [PATCH bpf-next v2 4/5] selftests/bpf: silence clang compilation warnings Yonghong Song
2021-04-13 4:45 ` Andrii Nakryiko
2021-04-12 14:29 ` [PATCH bpf-next v2 5/5] bpftool: fix a clang compilation warning Yonghong Song
2021-04-13 4:48 ` Andrii Nakryiko
2021-04-12 23:58 ` [PATCH bpf-next v2 0/5] bpf: tools: support build selftests/bpf with clang Nick Desaulniers
2021-04-13 0:02 ` Nick Desaulniers
2021-04-13 0:31 ` Yonghong Song
2021-04-13 18:46 ` Nick Desaulniers
2021-04-13 18:56 ` Nick Desaulniers
2021-04-13 20:35 ` Jiri Olsa
2021-04-13 20:45 ` Nick Desaulniers
2021-04-14 13:18 ` Jiri Olsa
2021-04-15 0:16 ` Andrii Nakryiko
2021-04-15 13:23 ` Jiri Olsa
2021-04-15 16:55 ` Nick Desaulniers
2021-04-15 17:17 ` Jiri Olsa
2021-04-15 21:39 ` Jiri Olsa [this message]
2021-04-13 0:25 ` Yonghong Song
2021-04-13 1:44 ` Sedat Dilek
2021-04-13 15:21 ` Yonghong Song
2021-04-13 1:50 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHiyp1lAPzosRkez@krava \
--to=jolsa@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jolsa@kernel.org \
--cc=kernel-team@fb.com \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.