From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62A9C433ED for ; Thu, 22 Apr 2021 07:30:09 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 3E9A961461 for ; Thu, 22 Apr 2021 07:30:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E9A961461 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9C5734B457; Thu, 22 Apr 2021 03:30:08 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1Ro+fOswk4wg; Thu, 22 Apr 2021 03:30:07 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 804B64B469; Thu, 22 Apr 2021 03:30:07 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 990464B3E4 for ; Thu, 22 Apr 2021 03:30:06 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7QrGivGIY+sF for ; Thu, 22 Apr 2021 03:30:05 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 6395B4B451 for ; Thu, 22 Apr 2021 03:30:05 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 997EC6145E; Thu, 22 Apr 2021 07:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619076603; bh=GvHLrkjv+8OSfv0DFhto7kn97jmH4HlTtc9KLl6FFu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EEdSmllRyEg3GlL6fG+QQxGmjjh8mn5FNwFOz2dK6HPHJ1DKQtONjppKpwZX6WwKm zTUBFONStme9eAX5Yp/tucFTyfUDifV52Jvk8/tweFJz5h0Tkur33U7zK+IqoecPxG AfclCDbDXzUtfM6wF4InX3oVYpnK3IIedrZy4BeCuEOvfnQaXLluNnvDW/cOCMdHUN 4Du5U0a0uJxKBTiXnTTi1OhiOY2WwDNVY3ruGLAnY3bsSS+D0zn0jgIrIGIWA+2518 UgTkkoL86MmFKi0SjMPoGNYnwfLu3Ag78kGee/2AQLjNwy7ccbIGvoODA1pjeLgfdb KGl0OzJVIPfZA== Date: Thu, 22 Apr 2021 10:29:53 +0300 From: Mike Rapoport To: Kefeng Wang Subject: Re: [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Message-ID: References: <20210421065108.1987-1-rppt@kernel.org> <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> Cc: David Hildenbrand , Catalin Marinas , Anshuman Khandual , linux-kernel@vger.kernel.org, Mike Rapoport , linux-mm@kvack.org, kvmarm@lists.cs.columbia.edu, Marc Zyngier , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVGh1LCBBcHIgMjIsIDIwMjEgYXQgMDM6MDA6MjBQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3Jv dGU6Cj4gCj4gT24gMjAyMS80LzIxIDE0OjUxLCBNaWtlIFJhcG9wb3J0IHdyb3RlOgo+ID4gRnJv bTogTWlrZSBSYXBvcG9ydCA8cnBwdEBsaW51eC5pYm0uY29tPgo+ID4gCj4gPiBIaSwKPiA+IAo+ ID4gVGhlc2UgcGF0Y2hlcyBhaW0gdG8gcmVtb3ZlIENPTkZJR19IT0xFU19JTl9aT05FIGFuZCBl c3NlbnRpYWxseSBoYXJkd2lyZQo+ID4gcGZuX3ZhbGlkX3dpdGhpbigpIHRvIDEuCj4gPiAKPiA+ IFRoZSBpZGVhIGlzIHRvIG1hcmsgTk9NQVAgcGFnZXMgYXMgcmVzZXJ2ZWQgaW4gdGhlIG1lbW9y eSBtYXAgYW5kIHJlc3RvcmUKPiA+IHRoZSBpbnRlbmRlZCBzZW1hbnRpY3Mgb2YgcGZuX3ZhbGlk KCkgdG8gZGVzaWduYXRlIGF2YWlsYWJpbGl0eSBvZiBzdHJ1Y3QKPiA+IHBhZ2UgZm9yIGEgcGZu Lgo+ID4gCj4gPiBXaXRoIHRoaXMgdGhlIGNvcmUgbW0gd2lsbCBiZSBhYmxlIHRvIGNvcGUgd2l0 aCB0aGUgZmFjdCB0aGF0IGl0IGNhbm5vdCB1c2UKPiA+IE5PTUFQIHBhZ2VzIGFuZCB0aGUgaG9s ZXMgY3JlYXRlZCBieSBOT01BUCByYW5nZXMgd2l0aGluIE1BWF9PUkRFUiBibG9ja3MKPiA+IHdp bGwgYmUgdHJlYXRlZCBjb3JyZWN0bHkgZXZlbiB3aXRob3V0IHRoZSBuZWVkIGZvciBwZm5fdmFs aWRfd2l0aGluLgo+ID4gCj4gPiBUaGUgcGF0Y2hlcyBhcmUgb25seSBib290IHRlc3RlZCBvbiBx ZW11LXN5c3RlbS1hYXJjaDY0IHNvIEknZCByZWFsbHkKPiA+IGFwcHJlY2lhdGUgbWVtb3J5IHN0 cmVzcyB0ZXN0cyBvbiByZWFsIGhhcmR3YXJlLgo+ID4gCj4gPiBJZiB0aGlzIGFjdHVhbGx5IHdv cmtzIHdlJ2xsIGJlIG9uZSBzdGVwIGNsb3NlciB0byBkcm9wIGN1c3RvbSBwZm5fdmFsaWQoKQo+ ID4gb24gYXJtNjQgYWx0b2dldGhlci4KPiAKPiBIaSBNaWtl77yMSSBoYXZlIGEgcXVlc3Rpb24s IHdpdGhvdXQgSE9MRVNfSU5fWk9ORSwgdGhlIHBmbl92YWxpZF93aXRoaW4oKSBpbgo+IG1vdmVf ZnJlZXBhZ2VzX2Jsb2NrKCktPm1vdmVfZnJlZXBhZ2VzKCkKPiB3aWxsIGJlIG9wdGltaXplZCwg aWYgdGhlcmUgYXJlIGhvbGVzIGluIHpvbmUsIHRoZSAnc3RydWNlIHBhZ2UnKG1lbW9yeSBtYXAp Cj4gZm9yIHBmbiByYW5nZSBvZiBob2xlIHdpbGwgYmUgZnJlZSBieQo+IGZyZWVfbWVtbWFwKCks IGFuZCB0aGVuIHRoZSBwYWdlIHRyYXZlcnNlIGluIHRoZSB6b25lKHdpdGggaG9sZXMpIGZyb20K PiBtb3ZlX2ZyZWVwYWdlcygpIHdpbGwgbWVldCB0aGUgd3JvbmcgcGFnZe+8jAo+IHRoZW4gaXQg Y291bGQgcGFuaWMgYXQgUGFnZUxSVShwYWdlKSB0ZXN0LCBjaGVjayBsaW5rWzFdLAoKRmlyc3Qs IEhPTEVTX0lOX1pPTkUgbmFtZSB1cyBodWdlbHkgbWlzbGVhZGluZywgdGhpcyBjb25maWd1cmF0 aW9uIG9wdGlvbgpoYXMgbm90aGluZyB0byB0byB3aXRoIG1lbW9yeSBob2xlcywgYnV0IHJhdGhl ciBpdCBpcyB0aGVyZSB0byBkZWFsIHdpdGgKaG9sZXMgb3IgdW5kZWZpbmVkIHN0cnVjdCBwYWdl cyBpbiB0aGUgbWVtb3J5IG1hcCwgd2hlbiB0aGVzZSBob2xlcyBjYW4gYmUKaW5zaWRlIGEgTUFY X09SREVSX05SX1BBR0VTIHJlZ2lvbi4KCkluIGdlbmVyYWwgcGZuIHdhbGtlcnMgdXNlIHBmbl92 YWxpZCgpIGFuZCBwZm5fdmFsaWRfd2l0aGluKCkgdG8gYXZvaWQKYWNjZXNzaW5nICptaXNzaW5n KiBzdHJ1Y3QgcGFnZXMsIGxpa2UgdGhvc2UgdGhhdCBhcmUgZnJlZWQgYXQKZnJlZV9tZW1tYXAo KS4gQnV0IG9uIGFybTY0IHRoZXNlIHRlc3RzIGFsc28gZmlsdGVyIG91dCB0aGUgbm9tYXAgZW50 cmllcwpiZWNhdXNlIHRoZWlyIHN0cnVjdCBwYWdlcyBhcmUgbm90IGluaXRpYWxpemVkLgoKVGhl IHBhbmljIHlvdSByZWZlciB0byBoYXBwZW5lZCBiZWNhdXNlIHRoZXJlIHdhcyBhbiB1bmluaXRp YWxpemVkIHN0cnVjdApwYWdlIGluIHRoZSBtaWRkbGUgb2YgTUFYX09SREVSX05SX1BBR0VTIHJl Z2lvbiBiZWNhdXNlIGl0IGNvcnJlc3BvbmRlZCB0bwpub21hcCBtZW1vcnkuCgpXaXRoIHRoZXNl IGNoYW5nZXMgSSBtYWtlIHN1cmUgdGhhdCBzdWNoIHBhZ2VzIHdpbGwgYmUgcHJvcGVybHkgaW5p dGlhbGl6ZWQKYXMgUGFnZVJlc2VydmVkIGFuZCB0aGUgcGZuIHdhbGtlcnMgd2lsbCBiZSBhYmxl IHRvIHJlbHkgb24gdGhlIG1lbW9yeSBtYXAuCgpOb3RlIGFsc28sIHRoYXQgZnJlZV9tZW1tYXAo KSBhbGlnbnMgdGhlIHBhcnRzIGJlaW5nIGZyZWVkIG9uIE1BWF9PUkRFUgpib3VuZGFyaWVzLCBz byB0aGVyZSB3aWxsIGJlIG5vIG1pc3NpbmcgcGFydHMgaW4gdGhlIG1lbW9yeSBtYXAgd2l0aGlu IGEKTUFYX09SREVSX05SX1BBR0VTIHJlZ2lvbi4KIAo+ICJUaGUgaWRlYSBpcyB0byBtYXJrIE5P TUFQIHBhZ2VzIGFzIHJlc2VydmVkIGluIHRoZSBtZW1vcnkgbWFwIiwgSSBzZWUgdGhlCj4gcGF0 Y2gyIGNoZWNrIG1lbWJsb2NrX2lzX25vbWFwKCkgaW4gbWVtb3J5IHJlZ2lvbgo+IG9mIG1lbWJs b2NrLCBidXQgaXQgc2VlbXMgdGhhdCBtZW1ibG9ja19tYXJrX25vbWFwKCkgaXMgbm90IGNhbGxl ZChtYXliZSBJCj4gbWlzc2VkKSwgdGhlbiBtZW1tYXBfaW5pdF9yZXNlcnZlZF9wYWdlcygpIHdv bid0Cj4gd29yaywgc28gc2hvdWxkIHRoZSBIT0xFU19JTl9aT05FIHN0aWxsIGJlIG5lZWRlZCBm b3IgZ2VuZXJpYyBtbSBjb2RlPwo+IAo+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51 eC1hcm0ta2VybmVsLzU0MTE5M2E2LTJiY2UtZjA0Mi01YmIyLTg4OTEzZDVmMTA0N0Bhcm0uY29t Lwo+IAoKLS0gClNpbmNlcmVseSB5b3VycywKTWlrZS4KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMu Y3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlz dGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63888C433B4 for ; Thu, 22 Apr 2021 07:32:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4399613F2 for ; Thu, 22 Apr 2021 07:32:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4399613F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U8iGI+EArBjIU6MTU6ynhcmFb20854+TozGmwBEq7c4=; b=Jot8pXG2an9vTlnfSvgsAoTZR c8CabqHJlCwmrvMMHOfYWPQP99xSvIe0/pPYYk6atdF/j2Mj0VNXgiWFRViZNQ9V7322csJQDdssY W8sBW5d1ttdLea6qSIkZmidDs3FWI+63UVYq8WdHMB4qxvtnvJD7MufUU9MKZBKXaYbWghOksc16c wx0otyRjxUDULG69br3bDxUgBItaYON7o+xZAhlpDcXo4+nKFz0uD680v7JbCvayiARiS4zm1mqGq zdGtYAGQf8VVpnN/UxYyjF4kYo7jj6P9lDWZzSViySc/+55ITilMhWjA84RYmFyDfxYj1r6ATdYlC mJfSPYiag==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZTmx-00G8eg-BJ; Thu, 22 Apr 2021 07:30:15 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZTmo-00G8d6-VF for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 07:30:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=nAjMry+dyE6dB5tlqLoB2tu2le+UHLPIvA355cvWlbQ=; b=p2X5tfxzyXgmm3cTk+8Tubp34p LrCpmjOeFwilTS6LqnWsvmp3nTefwM8lfjqVHimY65iQtUTm59PqEWm8eJb76AL1hjcsWJVtLNZW2 dG5Grvp85gcAE45aUwFinwwugD44M6KA1D+AD7bO3wdz0/GRJy+F5e+JQ12UBlOE+9DFiw4oZXPUx wewLzE3i5e9oKEWs+uB+dS7qrTrqT5nB2LSRQNHKiUezw0DRbBtn4OrMTUTm6aofwhhVtHcgS88rw 3Q7aHRU6wM43ErxfdyHMGZzOEXWP8P118AJepmadsYS7mW89hIeOvXoOnCc3jIkDdK/NEWSXjA4Sx 5+7Ny1NA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZTml-00DSGk-RE for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 07:30:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 997EC6145E; Thu, 22 Apr 2021 07:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619076603; bh=GvHLrkjv+8OSfv0DFhto7kn97jmH4HlTtc9KLl6FFu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EEdSmllRyEg3GlL6fG+QQxGmjjh8mn5FNwFOz2dK6HPHJ1DKQtONjppKpwZX6WwKm zTUBFONStme9eAX5Yp/tucFTyfUDifV52Jvk8/tweFJz5h0Tkur33U7zK+IqoecPxG AfclCDbDXzUtfM6wF4InX3oVYpnK3IIedrZy4BeCuEOvfnQaXLluNnvDW/cOCMdHUN 4Du5U0a0uJxKBTiXnTTi1OhiOY2WwDNVY3ruGLAnY3bsSS+D0zn0jgIrIGIWA+2518 UgTkkoL86MmFKi0SjMPoGNYnwfLu3Ag78kGee/2AQLjNwy7ccbIGvoODA1pjeLgfdb KGl0OzJVIPfZA== Date: Thu, 22 Apr 2021 10:29:53 +0300 From: Mike Rapoport To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Message-ID: References: <20210421065108.1987-1-rppt@kernel.org> <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_003004_250299_57D4CBEA X-CRM114-Status: GOOD ( 27.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMjIsIDIwMjEgYXQgMDM6MDA6MjBQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3Jv dGU6Cj4gCj4gT24gMjAyMS80LzIxIDE0OjUxLCBNaWtlIFJhcG9wb3J0IHdyb3RlOgo+ID4gRnJv bTogTWlrZSBSYXBvcG9ydCA8cnBwdEBsaW51eC5pYm0uY29tPgo+ID4gCj4gPiBIaSwKPiA+IAo+ ID4gVGhlc2UgcGF0Y2hlcyBhaW0gdG8gcmVtb3ZlIENPTkZJR19IT0xFU19JTl9aT05FIGFuZCBl c3NlbnRpYWxseSBoYXJkd2lyZQo+ID4gcGZuX3ZhbGlkX3dpdGhpbigpIHRvIDEuCj4gPiAKPiA+ IFRoZSBpZGVhIGlzIHRvIG1hcmsgTk9NQVAgcGFnZXMgYXMgcmVzZXJ2ZWQgaW4gdGhlIG1lbW9y eSBtYXAgYW5kIHJlc3RvcmUKPiA+IHRoZSBpbnRlbmRlZCBzZW1hbnRpY3Mgb2YgcGZuX3ZhbGlk KCkgdG8gZGVzaWduYXRlIGF2YWlsYWJpbGl0eSBvZiBzdHJ1Y3QKPiA+IHBhZ2UgZm9yIGEgcGZu Lgo+ID4gCj4gPiBXaXRoIHRoaXMgdGhlIGNvcmUgbW0gd2lsbCBiZSBhYmxlIHRvIGNvcGUgd2l0 aCB0aGUgZmFjdCB0aGF0IGl0IGNhbm5vdCB1c2UKPiA+IE5PTUFQIHBhZ2VzIGFuZCB0aGUgaG9s ZXMgY3JlYXRlZCBieSBOT01BUCByYW5nZXMgd2l0aGluIE1BWF9PUkRFUiBibG9ja3MKPiA+IHdp bGwgYmUgdHJlYXRlZCBjb3JyZWN0bHkgZXZlbiB3aXRob3V0IHRoZSBuZWVkIGZvciBwZm5fdmFs aWRfd2l0aGluLgo+ID4gCj4gPiBUaGUgcGF0Y2hlcyBhcmUgb25seSBib290IHRlc3RlZCBvbiBx ZW11LXN5c3RlbS1hYXJjaDY0IHNvIEknZCByZWFsbHkKPiA+IGFwcHJlY2lhdGUgbWVtb3J5IHN0 cmVzcyB0ZXN0cyBvbiByZWFsIGhhcmR3YXJlLgo+ID4gCj4gPiBJZiB0aGlzIGFjdHVhbGx5IHdv cmtzIHdlJ2xsIGJlIG9uZSBzdGVwIGNsb3NlciB0byBkcm9wIGN1c3RvbSBwZm5fdmFsaWQoKQo+ ID4gb24gYXJtNjQgYWx0b2dldGhlci4KPiAKPiBIaSBNaWtl77yMSSBoYXZlIGEgcXVlc3Rpb24s IHdpdGhvdXQgSE9MRVNfSU5fWk9ORSwgdGhlIHBmbl92YWxpZF93aXRoaW4oKSBpbgo+IG1vdmVf ZnJlZXBhZ2VzX2Jsb2NrKCktPm1vdmVfZnJlZXBhZ2VzKCkKPiB3aWxsIGJlIG9wdGltaXplZCwg aWYgdGhlcmUgYXJlIGhvbGVzIGluIHpvbmUsIHRoZSAnc3RydWNlIHBhZ2UnKG1lbW9yeSBtYXAp Cj4gZm9yIHBmbiByYW5nZSBvZiBob2xlIHdpbGwgYmUgZnJlZSBieQo+IGZyZWVfbWVtbWFwKCks IGFuZCB0aGVuIHRoZSBwYWdlIHRyYXZlcnNlIGluIHRoZSB6b25lKHdpdGggaG9sZXMpIGZyb20K PiBtb3ZlX2ZyZWVwYWdlcygpIHdpbGwgbWVldCB0aGUgd3JvbmcgcGFnZe+8jAo+IHRoZW4gaXQg Y291bGQgcGFuaWMgYXQgUGFnZUxSVShwYWdlKSB0ZXN0LCBjaGVjayBsaW5rWzFdLAoKRmlyc3Qs IEhPTEVTX0lOX1pPTkUgbmFtZSB1cyBodWdlbHkgbWlzbGVhZGluZywgdGhpcyBjb25maWd1cmF0 aW9uIG9wdGlvbgpoYXMgbm90aGluZyB0byB0byB3aXRoIG1lbW9yeSBob2xlcywgYnV0IHJhdGhl ciBpdCBpcyB0aGVyZSB0byBkZWFsIHdpdGgKaG9sZXMgb3IgdW5kZWZpbmVkIHN0cnVjdCBwYWdl cyBpbiB0aGUgbWVtb3J5IG1hcCwgd2hlbiB0aGVzZSBob2xlcyBjYW4gYmUKaW5zaWRlIGEgTUFY X09SREVSX05SX1BBR0VTIHJlZ2lvbi4KCkluIGdlbmVyYWwgcGZuIHdhbGtlcnMgdXNlIHBmbl92 YWxpZCgpIGFuZCBwZm5fdmFsaWRfd2l0aGluKCkgdG8gYXZvaWQKYWNjZXNzaW5nICptaXNzaW5n KiBzdHJ1Y3QgcGFnZXMsIGxpa2UgdGhvc2UgdGhhdCBhcmUgZnJlZWQgYXQKZnJlZV9tZW1tYXAo KS4gQnV0IG9uIGFybTY0IHRoZXNlIHRlc3RzIGFsc28gZmlsdGVyIG91dCB0aGUgbm9tYXAgZW50 cmllcwpiZWNhdXNlIHRoZWlyIHN0cnVjdCBwYWdlcyBhcmUgbm90IGluaXRpYWxpemVkLgoKVGhl IHBhbmljIHlvdSByZWZlciB0byBoYXBwZW5lZCBiZWNhdXNlIHRoZXJlIHdhcyBhbiB1bmluaXRp YWxpemVkIHN0cnVjdApwYWdlIGluIHRoZSBtaWRkbGUgb2YgTUFYX09SREVSX05SX1BBR0VTIHJl Z2lvbiBiZWNhdXNlIGl0IGNvcnJlc3BvbmRlZCB0bwpub21hcCBtZW1vcnkuCgpXaXRoIHRoZXNl IGNoYW5nZXMgSSBtYWtlIHN1cmUgdGhhdCBzdWNoIHBhZ2VzIHdpbGwgYmUgcHJvcGVybHkgaW5p dGlhbGl6ZWQKYXMgUGFnZVJlc2VydmVkIGFuZCB0aGUgcGZuIHdhbGtlcnMgd2lsbCBiZSBhYmxl IHRvIHJlbHkgb24gdGhlIG1lbW9yeSBtYXAuCgpOb3RlIGFsc28sIHRoYXQgZnJlZV9tZW1tYXAo KSBhbGlnbnMgdGhlIHBhcnRzIGJlaW5nIGZyZWVkIG9uIE1BWF9PUkRFUgpib3VuZGFyaWVzLCBz byB0aGVyZSB3aWxsIGJlIG5vIG1pc3NpbmcgcGFydHMgaW4gdGhlIG1lbW9yeSBtYXAgd2l0aGlu IGEKTUFYX09SREVSX05SX1BBR0VTIHJlZ2lvbi4KIAo+ICJUaGUgaWRlYSBpcyB0byBtYXJrIE5P TUFQIHBhZ2VzIGFzIHJlc2VydmVkIGluIHRoZSBtZW1vcnkgbWFwIiwgSSBzZWUgdGhlCj4gcGF0 Y2gyIGNoZWNrIG1lbWJsb2NrX2lzX25vbWFwKCkgaW4gbWVtb3J5IHJlZ2lvbgo+IG9mIG1lbWJs b2NrLCBidXQgaXQgc2VlbXMgdGhhdCBtZW1ibG9ja19tYXJrX25vbWFwKCkgaXMgbm90IGNhbGxl ZChtYXliZSBJCj4gbWlzc2VkKSwgdGhlbiBtZW1tYXBfaW5pdF9yZXNlcnZlZF9wYWdlcygpIHdv bid0Cj4gd29yaywgc28gc2hvdWxkIHRoZSBIT0xFU19JTl9aT05FIHN0aWxsIGJlIG5lZWRlZCBm b3IgZ2VuZXJpYyBtbSBjb2RlPwo+IAo+IFsxXSBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51 eC1hcm0ta2VybmVsLzU0MTE5M2E2LTJiY2UtZjA0Mi01YmIyLTg4OTEzZDVmMTA0N0Bhcm0uY29t Lwo+IAoKLS0gClNpbmNlcmVseSB5b3VycywKTWlrZS4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0AEC433B4 for ; Thu, 22 Apr 2021 07:30:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32315613DE for ; Thu, 22 Apr 2021 07:30:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32315613DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 84A9A6B006C; Thu, 22 Apr 2021 03:30:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FB2E6B006E; Thu, 22 Apr 2021 03:30:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 674E46B0070; Thu, 22 Apr 2021 03:30:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 479D46B006C for ; Thu, 22 Apr 2021 03:30:10 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EA1A13CF6 for ; Thu, 22 Apr 2021 07:30:09 +0000 (UTC) X-FDA: 78059179338.23.6077A75 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id 17F8B6000128 for ; Thu, 22 Apr 2021 07:30:05 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 997EC6145E; Thu, 22 Apr 2021 07:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619076603; bh=GvHLrkjv+8OSfv0DFhto7kn97jmH4HlTtc9KLl6FFu4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EEdSmllRyEg3GlL6fG+QQxGmjjh8mn5FNwFOz2dK6HPHJ1DKQtONjppKpwZX6WwKm zTUBFONStme9eAX5Yp/tucFTyfUDifV52Jvk8/tweFJz5h0Tkur33U7zK+IqoecPxG AfclCDbDXzUtfM6wF4InX3oVYpnK3IIedrZy4BeCuEOvfnQaXLluNnvDW/cOCMdHUN 4Du5U0a0uJxKBTiXnTTi1OhiOY2WwDNVY3ruGLAnY3bsSS+D0zn0jgIrIGIWA+2518 UgTkkoL86MmFKi0SjMPoGNYnwfLu3Ag78kGee/2AQLjNwy7ccbIGvoODA1pjeLgfdb KGl0OzJVIPfZA== Date: Thu, 22 Apr 2021 10:29:53 +0300 From: Mike Rapoport To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Message-ID: References: <20210421065108.1987-1-rppt@kernel.org> <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 17F8B6000128 X-Stat-Signature: ozxujaua4fjwn5m51ok6msz55ity53m9 Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619076605-417238 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 22, 2021 at 03:00:20PM +0800, Kefeng Wang wrote: >=20 > On 2021/4/21 14:51, Mike Rapoport wrote: > > From: Mike Rapoport > >=20 > > Hi, > >=20 > > These patches aim to remove CONFIG_HOLES_IN_ZONE and essentially hard= wire > > pfn_valid_within() to 1. > >=20 > > The idea is to mark NOMAP pages as reserved in the memory map and res= tore > > the intended semantics of pfn_valid() to designate availability of st= ruct > > page for a pfn. > >=20 > > With this the core mm will be able to cope with the fact that it cann= ot use > > NOMAP pages and the holes created by NOMAP ranges within MAX_ORDER bl= ocks > > will be treated correctly even without the need for pfn_valid_within. > >=20 > > The patches are only boot tested on qemu-system-aarch64 so I'd really > > appreciate memory stress tests on real hardware. > >=20 > > If this actually works we'll be one step closer to drop custom pfn_va= lid() > > on arm64 altogether. >=20 > Hi Mike=EF=BC=8CI have a question, without HOLES_IN_ZONE, the pfn_valid= _within() in > move_freepages_block()->move_freepages() > will be optimized, if there are holes in zone, the 'struce page'(memory= map) > for pfn range of hole will be free by > free_memmap(), and then the page traverse in the zone(with holes) from > move_freepages() will meet the wrong page=EF=BC=8C > then it could panic at PageLRU(page) test, check link[1], First, HOLES_IN_ZONE name us hugely misleading, this configuration option has nothing to to with memory holes, but rather it is there to deal with holes or undefined struct pages in the memory map, when these holes can b= e inside a MAX_ORDER_NR_PAGES region. In general pfn walkers use pfn_valid() and pfn_valid_within() to avoid accessing *missing* struct pages, like those that are freed at free_memmap(). But on arm64 these tests also filter out the nomap entries because their struct pages are not initialized. The panic you refer to happened because there was an uninitialized struct page in the middle of MAX_ORDER_NR_PAGES region because it corresponded t= o nomap memory. With these changes I make sure that such pages will be properly initializ= ed as PageReserved and the pfn walkers will be able to rely on the memory ma= p. Note also, that free_memmap() aligns the parts being freed on MAX_ORDER boundaries, so there will be no missing parts in the memory map within a MAX_ORDER_NR_PAGES region. =20 > "The idea is to mark NOMAP pages as reserved in the memory map", I see = the > patch2 check memblock_is_nomap() in memory region > of memblock, but it seems that memblock_mark_nomap() is not called(mayb= e I > missed), then memmap_init_reserved_pages() won't > work, so should the HOLES_IN_ZONE still be needed for generic mm code? >=20 > [1] https://lore.kernel.org/linux-arm-kernel/541193a6-2bce-f042-5bb2-88= 913d5f1047@arm.com/ >=20 --=20 Sincerely yours, Mike.