From: Andrew Lunn <andrew@lunn.ch>
To: Maxim Kochetkov <fido_max@inbox.ru>
Cc: netdev@vger.kernel.org, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
f.fainelli@gmail.com
Subject: Re: [PATCH 1/2] net: phy: marvell: fix m88e1011_set_downshift
Date: Thu, 22 Apr 2021 14:30:34 +0200 [thread overview]
Message-ID: <YIFsaoxmn3mC8VgH@lunn.ch> (raw)
In-Reply-To: <20210422104644.9472-2-fido_max@inbox.ru>
On Thu, Apr 22, 2021 at 01:46:43PM +0300, Maxim Kochetkov wrote:
> Changing downshift params without software reset has no effect,
> so call genphy_soft_reset() after change downshift params.
>
> As the datasheet says:
> Changes to these bits are disruptive to the normal operation therefore,
> any changes to these registers must be followed by software reset
> to take effect.
>
> Fixes: 911af5e149bb ("net: phy: marvell: fix downshift function naming")
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-04-22 12:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 10:46 [PATCH 0/2] net: phy: marvell: fix set downshift params Maxim Kochetkov
2021-04-22 10:46 ` [PATCH 1/2] net: phy: marvell: fix m88e1011_set_downshift Maxim Kochetkov
2021-04-22 12:30 ` Andrew Lunn [this message]
2021-04-22 10:46 ` [PATCH 2/2] net: phy: marvell: fix m88e1111_set_downshift Maxim Kochetkov
2021-04-22 12:31 ` Andrew Lunn
2021-04-22 20:30 ` [PATCH 0/2] net: phy: marvell: fix set downshift params patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIFsaoxmn3mC8VgH@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=fido_max@inbox.ru \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.