From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 979A7C433ED for ; Thu, 22 Apr 2021 12:31:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E43561465 for ; Thu, 22 Apr 2021 12:31:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236183AbhDVMcE (ORCPT ); Thu, 22 Apr 2021 08:32:04 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:35624 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236168AbhDVMcC (ORCPT ); Thu, 22 Apr 2021 08:32:02 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lZYUQ-000UqE-NV; Thu, 22 Apr 2021 14:31:26 +0200 Date: Thu, 22 Apr 2021 14:31:26 +0200 From: Andrew Lunn To: Maxim Kochetkov Cc: netdev@vger.kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, f.fainelli@gmail.com Subject: Re: [PATCH 2/2] net: phy: marvell: fix m88e1111_set_downshift Message-ID: References: <20210422104644.9472-1-fido_max@inbox.ru> <20210422104644.9472-3-fido_max@inbox.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210422104644.9472-3-fido_max@inbox.ru> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 22, 2021 at 01:46:44PM +0300, Maxim Kochetkov wrote: > Changing downshift params without software reset has no effect, > so call genphy_soft_reset() after change downshift params. > > As the datasheet says: > Changes to these bits are disruptive to the normal operation therefore, > any changes to these registers must be followed by software reset > to take effect. > > Fixes: 5c6bc5199b5d ("net: phy: marvell: add downshift support for M88E1111") > Signed-off-by: Maxim Kochetkov Reviewed-by: Andrew Lunn Andrew