From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BFD7C433B4 for ; Fri, 23 Apr 2021 12:41:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A36A61459 for ; Fri, 23 Apr 2021 12:41:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A36A61459 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D0406EB8B; Fri, 23 Apr 2021 12:41:30 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 032C96EB8B; Fri, 23 Apr 2021 12:41:28 +0000 (UTC) IronPort-SDR: 5OBNtVXUlNTAsAuo5p+lnsY0B9jhEHvbk2q/Y8o2DMDiafWKH+rVfoco2wdOYoSi2fi7F2svFr 0uLtwybMM2Sw== X-IronPort-AV: E=McAfee;i="6200,9189,9962"; a="175546117" X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="175546117" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 05:41:28 -0700 IronPort-SDR: QPHLW8jG5xCo83/70ShTBOMYCGWqTGw2QkEAqFlaekBZ1w5gwgawbZM/mw7M8sIz0e302n+OVA 0polxrY4qHEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="386380029" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga006.jf.intel.com with SMTP; 23 Apr 2021 05:41:23 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 23 Apr 2021 15:41:23 +0300 Date: Fri, 23 Apr 2021 15:41:23 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Kai-Heng Feng Message-ID: References: <20210423044700.247359-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210423044700.247359-1-kai.heng.feng@canonical.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, open list , Takashi Iwai , "open list:DRM DRIVERS" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCBBcHIgMjMsIDIwMjEgYXQgMTI6NDY6NTRQTSArMDgwMCwgS2FpLUhlbmcgRmVuZyB3 cm90ZToKPiBPbiBIUCBGdXJ5IEc3IFdvcmtzdGF0aW9ucywgZ3JhcGhpY3Mgb3V0cHV0IGlzIHJl LXJvdXRlZCBmcm9tIEludGVsIEdGWAo+IHRvIGRpc2NyZXRlIEdGWCBhZnRlciBTMy4gVGhpcyBp cyBub3QgZGVzaXJhYmxlLCBiZWNhdXNlIHVzZXJzcGFjZSB3aWxsCj4gdHJlYXQgY29ubmVjdGVk IGRpc3BsYXkgYXMgYSBuZXcgb25lLCBsb3NpbmcgZGlzcGxheSBzZXR0aW5ncy4KPiAKPiBUaGUg ZXhwZWN0ZWQgYmVoYXZpb3IgaXMgdG8gbGV0IGRpc2NyZXRlIEdGWCBkcml2ZXMgYWxsIGV4dGVy bmFsCj4gZGlzcGxheXMuCj4gCj4gVGhlIHBsYXRmb3JtIGluIHF1ZXN0aW9uIHVzZXMgQUNQSSBt ZXRob2QgXF9TQi5QQ0kwLkhHTUUgdG8gZW5hYmxlIE1VWC4KPiBUaGUgbWV0aG9kIGlzIGluc2lk ZSB0aGUgQlhUIF9EU00sIHNvIGFkZCB0aGUgX0RTTSBhbmQgY2FsbCBpdAo+IGFjY29yZGluZ2x5 Lgo+IAo+IEkgYWxzbyB0ZXN0ZWQgc29tZSBNVVgtbGVzcyBhbmQgaUdQVSBvbmx5IGxhcHRvcHMg d2l0aCB0aGUgQlhUIF9EU00sIG5vCj4gcmVncmVzc2lvbiB3YXMgZm91bmQuCj4gCj4gdjI6Cj4g IC0gRm9yd2FyZCBkZWNsYXJlIHN0cnVjdCBwY2lfZGV2Lgo+IAo+IENsb3NlczogaHR0cHM6Ly9n aXRsYWIuZnJlZWRlc2t0b3Aub3JnL2RybS9pbnRlbC8tL2lzc3Vlcy8zMTEzCj4gUmVmZXJlbmNl czogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvaW50ZWwtZ2Z4LzE0NjAwNDA3MzItMzE0MTctNC1n aXQtc2VuZC1lbWFpbC1hbmltZXNoLm1hbm5hQGludGVsLmNvbS8KPiBTaWduZWQtb2ZmLWJ5OiBL YWktSGVuZyBGZW5nIDxrYWkuaGVuZy5mZW5nQGNhbm9uaWNhbC5jb20+Cj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5jIHwgMTcgKysrKysrKysrKysrKysr KysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmggfCAgMyArKysK PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyAgICAgICAgICAgfCAgNSArKysrKwo+ ICAzIGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9kaXNwbGF5L2ludGVsX2FjcGkuYwo+IGluZGV4IDgzM2QwYzFiZTRmMS4uYzdiNTdjMjJk Y2UzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNw aS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiBA QCAtMTQsMTEgKzE0LDE2IEBACj4gIAo+ICAjZGVmaW5lIElOVEVMX0RTTV9SRVZJU0lPTl9JRCAx IC8qIEZvciBDYWxwZWxsYSBhbnl3YXkuLi4gKi8KPiAgI2RlZmluZSBJTlRFTF9EU01fRk5fUExB VEZPUk1fTVVYX0lORk8gMSAvKiBObyBhcmdzICovCj4gKyNkZWZpbmUgSU5URUxfRFNNX0ZOX1BM QVRGT1JNX0JYVF9NVVhfSU5GTyAwIC8qIE5vIGFyZ3MgKi8KPiAgCj4gIHN0YXRpYyBjb25zdCBn dWlkX3QgaW50ZWxfZHNtX2d1aWQgPQo+ICAJR1VJRF9JTklUKDB4N2VkODczZDMsIDB4YzJkMCwg MHg0ZTRmLAo+ICAJCSAgMHhhOCwgMHg1NCwgMHgwZiwgMHgxMywgMHgxNywgMHhiMCwgMHgxYywg MHgyYyk7Cj4gIAo+ICtzdGF0aWMgY29uc3QgZ3VpZF90IGludGVsX2J4dF9kc21fZ3VpZCA9Cj4g KwlHVUlEX0lOSVQoMHgzZTViNDFjNiwgMHhlYjFkLCAweDQyNjAsCj4gKwkJICAweDlkLCAweDE1 LCAweGM3LCAweDFmLCAweGJhLCAweGRhLCAweGU0LCAweDE0KTsKPiArCgpJIHRoaW5rIHRoaXMg ZHNtIGlzIGp1c3Qgc3VwcG9zZWQgdG8gYmUgbW9yZSBvciBsZXNzIGFuCmFsdGVybmF0aXZlIHRv IHRoZSBvcHJlZ2lvbiBTQ0kgc3R1ZmYuIFdoeSB0aGVyZSBhcmUgdHdvCndheXMgdG8gZG8gdGhl IHNhbWUgdGhpbmdzIEkgaGF2ZSBubyBpZGVhLiBUaGUgb3ByZWdpb24Kc3BlYyBkb2VzIG5vdCB0 ZWxsIHVzIHN1Y2ggbXVuZGFuZSBkZXRhaWxzLgoKSXQncyBhbHNvIG5vdCBkb2N1bWVudGVkIHRv IGRvIGFueXRoaW5nIGV4Y2VwdCBsaXN0IHRoZQpzdXBwb3J0ZWQgZnVuY3Rpb25zOgoiR2V0IEJJ T1MgRGF0YSBGdW5jdGlvbnMgU3VwcG9ydGVkIOKAnEZ1bmN0aW9uICMwIgogVGhpcyBmdW5jdGlv biBjYW4gYmUgY2FsbGVkIHRvIGRpc2NvdmVyIHdoaWNoIOKAnF9EU03igJ0gRnVuY3Rpb25zIGFy ZQogc3VwcG9ydGVkLiBJdCBtYXkgb25seSByZXR1cm4gc3VjY2VzcyBpZiB0aGUgcmV0dXJuIHZh bHVlIGFjY3VyYXRlbHkKIGxpc3RzIHN1cHBvcnRlZCBGdW5jdGlvbnMuIgoKQnV0IHdoYXQgeW91 J3JlIGFwcGFyZW50bHkgc2F5aW5nIGlzIHRoYXQgY2FsbGluZyB0aGlzIGNoYW5nZXMKdGhlIGJl aGF2aW91ciBvZiB0aGUgc3lzdGVtIHNvbWVob3c/IFRoYXQgaXMgdHJvdWJsaW5nLgoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA83DC43460 for ; Fri, 23 Apr 2021 12:41:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FB3E61176 for ; Fri, 23 Apr 2021 12:41:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FB3E61176 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D0366EB8F; Fri, 23 Apr 2021 12:41:30 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 032C96EB8B; Fri, 23 Apr 2021 12:41:28 +0000 (UTC) IronPort-SDR: 5OBNtVXUlNTAsAuo5p+lnsY0B9jhEHvbk2q/Y8o2DMDiafWKH+rVfoco2wdOYoSi2fi7F2svFr 0uLtwybMM2Sw== X-IronPort-AV: E=McAfee;i="6200,9189,9962"; a="175546117" X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="175546117" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 05:41:28 -0700 IronPort-SDR: QPHLW8jG5xCo83/70ShTBOMYCGWqTGw2QkEAqFlaekBZ1w5gwgawbZM/mw7M8sIz0e302n+OVA 0polxrY4qHEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="386380029" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga006.jf.intel.com with SMTP; 23 Apr 2021 05:41:23 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 23 Apr 2021 15:41:23 +0300 Date: Fri, 23 Apr 2021 15:41:23 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Kai-Heng Feng Subject: Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops Message-ID: References: <20210423044700.247359-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210423044700.247359-1-kai.heng.feng@canonical.com> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, open list , "open list:DRM DRIVERS" , rodrigo.vivi@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBBcHIgMjMsIDIwMjEgYXQgMTI6NDY6NTRQTSArMDgwMCwgS2FpLUhlbmcgRmVuZyB3 cm90ZToKPiBPbiBIUCBGdXJ5IEc3IFdvcmtzdGF0aW9ucywgZ3JhcGhpY3Mgb3V0cHV0IGlzIHJl LXJvdXRlZCBmcm9tIEludGVsIEdGWAo+IHRvIGRpc2NyZXRlIEdGWCBhZnRlciBTMy4gVGhpcyBp cyBub3QgZGVzaXJhYmxlLCBiZWNhdXNlIHVzZXJzcGFjZSB3aWxsCj4gdHJlYXQgY29ubmVjdGVk IGRpc3BsYXkgYXMgYSBuZXcgb25lLCBsb3NpbmcgZGlzcGxheSBzZXR0aW5ncy4KPiAKPiBUaGUg ZXhwZWN0ZWQgYmVoYXZpb3IgaXMgdG8gbGV0IGRpc2NyZXRlIEdGWCBkcml2ZXMgYWxsIGV4dGVy bmFsCj4gZGlzcGxheXMuCj4gCj4gVGhlIHBsYXRmb3JtIGluIHF1ZXN0aW9uIHVzZXMgQUNQSSBt ZXRob2QgXF9TQi5QQ0kwLkhHTUUgdG8gZW5hYmxlIE1VWC4KPiBUaGUgbWV0aG9kIGlzIGluc2lk ZSB0aGUgQlhUIF9EU00sIHNvIGFkZCB0aGUgX0RTTSBhbmQgY2FsbCBpdAo+IGFjY29yZGluZ2x5 Lgo+IAo+IEkgYWxzbyB0ZXN0ZWQgc29tZSBNVVgtbGVzcyBhbmQgaUdQVSBvbmx5IGxhcHRvcHMg d2l0aCB0aGUgQlhUIF9EU00sIG5vCj4gcmVncmVzc2lvbiB3YXMgZm91bmQuCj4gCj4gdjI6Cj4g IC0gRm9yd2FyZCBkZWNsYXJlIHN0cnVjdCBwY2lfZGV2Lgo+IAo+IENsb3NlczogaHR0cHM6Ly9n aXRsYWIuZnJlZWRlc2t0b3Aub3JnL2RybS9pbnRlbC8tL2lzc3Vlcy8zMTEzCj4gUmVmZXJlbmNl czogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvaW50ZWwtZ2Z4LzE0NjAwNDA3MzItMzE0MTctNC1n aXQtc2VuZC1lbWFpbC1hbmltZXNoLm1hbm5hQGludGVsLmNvbS8KPiBTaWduZWQtb2ZmLWJ5OiBL YWktSGVuZyBGZW5nIDxrYWkuaGVuZy5mZW5nQGNhbm9uaWNhbC5jb20+Cj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNwaS5jIHwgMTcgKysrKysrKysrKysrKysr KysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmggfCAgMyArKysK PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyAgICAgICAgICAgfCAgNSArKysrKwo+ ICAzIGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9kaXNwbGF5L2ludGVsX2FjcGkuYwo+IGluZGV4IDgzM2QwYzFiZTRmMS4uYzdiNTdjMjJk Y2UzIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfYWNw aS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9hY3BpLmMKPiBA QCAtMTQsMTEgKzE0LDE2IEBACj4gIAo+ICAjZGVmaW5lIElOVEVMX0RTTV9SRVZJU0lPTl9JRCAx IC8qIEZvciBDYWxwZWxsYSBhbnl3YXkuLi4gKi8KPiAgI2RlZmluZSBJTlRFTF9EU01fRk5fUExB VEZPUk1fTVVYX0lORk8gMSAvKiBObyBhcmdzICovCj4gKyNkZWZpbmUgSU5URUxfRFNNX0ZOX1BM QVRGT1JNX0JYVF9NVVhfSU5GTyAwIC8qIE5vIGFyZ3MgKi8KPiAgCj4gIHN0YXRpYyBjb25zdCBn dWlkX3QgaW50ZWxfZHNtX2d1aWQgPQo+ICAJR1VJRF9JTklUKDB4N2VkODczZDMsIDB4YzJkMCwg MHg0ZTRmLAo+ICAJCSAgMHhhOCwgMHg1NCwgMHgwZiwgMHgxMywgMHgxNywgMHhiMCwgMHgxYywg MHgyYyk7Cj4gIAo+ICtzdGF0aWMgY29uc3QgZ3VpZF90IGludGVsX2J4dF9kc21fZ3VpZCA9Cj4g KwlHVUlEX0lOSVQoMHgzZTViNDFjNiwgMHhlYjFkLCAweDQyNjAsCj4gKwkJICAweDlkLCAweDE1 LCAweGM3LCAweDFmLCAweGJhLCAweGRhLCAweGU0LCAweDE0KTsKPiArCgpJIHRoaW5rIHRoaXMg ZHNtIGlzIGp1c3Qgc3VwcG9zZWQgdG8gYmUgbW9yZSBvciBsZXNzIGFuCmFsdGVybmF0aXZlIHRv IHRoZSBvcHJlZ2lvbiBTQ0kgc3R1ZmYuIFdoeSB0aGVyZSBhcmUgdHdvCndheXMgdG8gZG8gdGhl IHNhbWUgdGhpbmdzIEkgaGF2ZSBubyBpZGVhLiBUaGUgb3ByZWdpb24Kc3BlYyBkb2VzIG5vdCB0 ZWxsIHVzIHN1Y2ggbXVuZGFuZSBkZXRhaWxzLgoKSXQncyBhbHNvIG5vdCBkb2N1bWVudGVkIHRv IGRvIGFueXRoaW5nIGV4Y2VwdCBsaXN0IHRoZQpzdXBwb3J0ZWQgZnVuY3Rpb25zOgoiR2V0IEJJ T1MgRGF0YSBGdW5jdGlvbnMgU3VwcG9ydGVkIOKAnEZ1bmN0aW9uICMwIgogVGhpcyBmdW5jdGlv biBjYW4gYmUgY2FsbGVkIHRvIGRpc2NvdmVyIHdoaWNoIOKAnF9EU03igJ0gRnVuY3Rpb25zIGFy ZQogc3VwcG9ydGVkLiBJdCBtYXkgb25seSByZXR1cm4gc3VjY2VzcyBpZiB0aGUgcmV0dXJuIHZh bHVlIGFjY3VyYXRlbHkKIGxpc3RzIHN1cHBvcnRlZCBGdW5jdGlvbnMuIgoKQnV0IHdoYXQgeW91 J3JlIGFwcGFyZW50bHkgc2F5aW5nIGlzIHRoYXQgY2FsbGluZyB0aGlzIGNoYW5nZXMKdGhlIGJl aGF2aW91ciBvZiB0aGUgc3lzdGVtIHNvbWVob3c/IFRoYXQgaXMgdHJvdWJsaW5nLgoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3827FC433ED for ; Fri, 23 Apr 2021 12:41:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E0DFB613DE for ; Fri, 23 Apr 2021 12:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235549AbhDWMmF (ORCPT ); Fri, 23 Apr 2021 08:42:05 -0400 Received: from mga07.intel.com ([134.134.136.100]:9511 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhDWMmE (ORCPT ); Fri, 23 Apr 2021 08:42:04 -0400 IronPort-SDR: vyq1Nnn/YmJrMTx82quo8iLAlwwGPR7IBlaQ1+1ccB/OKLLrrBXF8cLMREFhPb5D2fjXxVpova Hc3qp8meBWbg== X-IronPort-AV: E=McAfee;i="6200,9189,9962"; a="260014674" X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="260014674" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 05:41:27 -0700 IronPort-SDR: QPHLW8jG5xCo83/70ShTBOMYCGWqTGw2QkEAqFlaekBZ1w5gwgawbZM/mw7M8sIz0e302n+OVA 0polxrY4qHEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,245,1613462400"; d="scan'208";a="386380029" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga006.jf.intel.com with SMTP; 23 Apr 2021 05:41:23 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 23 Apr 2021 15:41:23 +0300 Date: Fri, 23 Apr 2021 15:41:23 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Kai-Heng Feng Cc: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, David Airlie , Daniel Vetter , Takashi Iwai , intel-gfx@lists.freedesktop.org, "open list:DRM DRIVERS" , open list Subject: Re: [PATCH v2] drm/i915: Invoke BXT _DSM to enable MUX on HP Workstation laptops Message-ID: References: <20210423044700.247359-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210423044700.247359-1-kai.heng.feng@canonical.com> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 23, 2021 at 12:46:54PM +0800, Kai-Heng Feng wrote: > On HP Fury G7 Workstations, graphics output is re-routed from Intel GFX > to discrete GFX after S3. This is not desirable, because userspace will > treat connected display as a new one, losing display settings. > > The expected behavior is to let discrete GFX drives all external > displays. > > The platform in question uses ACPI method \_SB.PCI0.HGME to enable MUX. > The method is inside the BXT _DSM, so add the _DSM and call it > accordingly. > > I also tested some MUX-less and iGPU only laptops with the BXT _DSM, no > regression was found. > > v2: > - Forward declare struct pci_dev. > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3113 > References: https://lore.kernel.org/intel-gfx/1460040732-31417-4-git-send-email-animesh.manna@intel.com/ > Signed-off-by: Kai-Heng Feng > --- > drivers/gpu/drm/i915/display/intel_acpi.c | 17 +++++++++++++++++ > drivers/gpu/drm/i915/display/intel_acpi.h | 3 +++ > drivers/gpu/drm/i915/i915_drv.c | 5 +++++ > 3 files changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c > index 833d0c1be4f1..c7b57c22dce3 100644 > --- a/drivers/gpu/drm/i915/display/intel_acpi.c > +++ b/drivers/gpu/drm/i915/display/intel_acpi.c > @@ -14,11 +14,16 @@ > > #define INTEL_DSM_REVISION_ID 1 /* For Calpella anyway... */ > #define INTEL_DSM_FN_PLATFORM_MUX_INFO 1 /* No args */ > +#define INTEL_DSM_FN_PLATFORM_BXT_MUX_INFO 0 /* No args */ > > static const guid_t intel_dsm_guid = > GUID_INIT(0x7ed873d3, 0xc2d0, 0x4e4f, > 0xa8, 0x54, 0x0f, 0x13, 0x17, 0xb0, 0x1c, 0x2c); > > +static const guid_t intel_bxt_dsm_guid = > + GUID_INIT(0x3e5b41c6, 0xeb1d, 0x4260, > + 0x9d, 0x15, 0xc7, 0x1f, 0xba, 0xda, 0xe4, 0x14); > + I think this dsm is just supposed to be more or less an alternative to the opregion SCI stuff. Why there are two ways to do the same things I have no idea. The opregion spec does not tell us such mundane details. It's also not documented to do anything except list the supported functions: "Get BIOS Data Functions Supported “Function #0" This function can be called to discover which “_DSM” Functions are supported. It may only return success if the return value accurately lists supported Functions." But what you're apparently saying is that calling this changes the behaviour of the system somehow? That is troubling. -- Ville Syrjälä Intel