From: Borislav Petkov <bp@suse.de>
To: Calvin Walton <calvin.walton@kepstin.ca>
Cc: Chen Yu <yu.c.chen@intel.com>,
Terry Bowman <terry.bowman@amd.com>,
lenb@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, wei.huang2@amd.com, aros@gmx.com,
rui.zhang@intel.com
Subject: Re: [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors
Date: Fri, 23 Apr 2021 16:29:41 +0200 [thread overview]
Message-ID: <YILZ1aNVrAa9vx79@zn.tnic> (raw)
In-Reply-To: <23f75aaf3d37cbad6f8ed7bd970434e4a2dc388e.camel@kepstin.ca>
On Fri, Apr 23, 2021 at 10:00:14AM -0400, Calvin Walton wrote:
> So, there's two problems with that:
> 1. This function needs to be able to return an error value that cannot be
> confused with a valid MSR. This is currently done by returning a
> negative number. If an unsigned value is used, a different way of
> indicating errors needs to be written.
> 2. We are not using CPU instructions to access MSRs direction. Instead
> they are being read from /dev/msr. So the "offset" value is actually a
> seek into the /dev/msr file (using pread), and thus is of type off_t.
Ah right, that's the /dev/msr thing. Then off_t is correct, forget what
I said.
Thx.
--
Regards/Gruss,
Boris.
SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
next prev parent reply other threads:[~2021-04-23 14:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 19:58 [PATCH v2] tools/power turbostat: Fix RAPL summary collection on AMD processors Terry Bowman
2021-04-19 23:52 ` calvin.walton
2021-04-20 2:03 ` Chen Yu
2021-04-20 8:07 ` Borislav Petkov
2021-04-20 13:15 ` Chen Yu
2021-04-20 13:28 ` Calvin Walton
2021-04-20 14:37 ` Chen Yu
2021-04-20 14:42 ` Calvin Walton
2021-04-23 12:16 ` Chen Yu
2021-04-23 12:19 ` Borislav Petkov
2021-04-23 13:34 ` Chen Yu
2021-04-23 14:32 ` Borislav Petkov
2021-04-24 1:14 ` Chen Yu
2021-04-23 14:00 ` Calvin Walton
2021-04-23 14:29 ` Borislav Petkov [this message]
2021-04-24 1:34 ` Chen Yu
2021-04-23 14:04 ` Calvin Walton
2021-04-23 14:27 ` Chen Yu
2021-04-23 15:17 ` Calvin Walton
2021-04-20 14:06 ` Artem S. Tashkinov
2021-04-20 15:25 ` Borislav Petkov
2021-04-23 12:18 ` Chen Yu
2021-04-20 13:32 ` Calvin Walton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YILZ1aNVrAa9vx79@zn.tnic \
--to=bp@suse.de \
--cc=aros@gmx.com \
--cc=calvin.walton@kepstin.ca \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=terry.bowman@amd.com \
--cc=wei.huang2@amd.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.