From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8039C433ED for ; Fri, 23 Apr 2021 17:31:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 56C4761409 for ; Fri, 23 Apr 2021 17:31:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56C4761409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1CAA416D9; Fri, 23 Apr 2021 19:30:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1CAA416D9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619199080; bh=3fd45qhH8TWDfff3jsutJa8Z49TGH32B7ScJaq9tyaE=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cRRvKHS3b6rXSM1FWD9lL7IR7Vj+xZLNwT2Irz22bEPybtEk4NXrE/ck2yb6vFKal eSdK2X33oPZ4kPi1atdjP2BwBKKWjOgK/7L90/WlNq+La5E0qFSdiSdSYfGKmYotCj dnaXbMX5nREQeSCKjKY1aiesmn2Jd6ZFoClhD0VA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5B31CF8019B; Fri, 23 Apr 2021 19:30:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 04289F80227; Fri, 23 Apr 2021 19:30:24 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D101FF800AE for ; Fri, 23 Apr 2021 19:30:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D101FF800AE IronPort-SDR: BenAotB9N3KbdMSIpXesOGlMLorPcYaGMLnJjVfBaJ1ROjm8QjTZ21ZS+XyfxgydWCsyDiu/3d oEjqDhoOtkHA== X-IronPort-AV: E=McAfee;i="6200,9189,9963"; a="176227014" X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="176227014" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 10:30:16 -0700 IronPort-SDR: H9+pJ0RnWOxq95zAbxojlapA9H16lEreXz5ioaDa6GiMX0Jc7ksJcaW+a51sLjX3NXrGLdTt9x Yd6R36OQH8PA== X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="386443849" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 10:30:11 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lZzd2-006cKS-BS; Fri, 23 Apr 2021 20:30:08 +0300 Date: Fri, 23 Apr 2021 20:30:08 +0300 From: Andy Shevchenko To: Mark Brown Subject: Re: [PATCH v1 05/14] spi: pxa2xx: Consolidate related headers under include/linux/spi Message-ID: References: <20210423163437.89306-1-andriy.shevchenko@linux.intel.com> <20210423163437.89306-5-andriy.shevchenko@linux.intel.com> <20210423165630.GH5507@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423165630.GH5507@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Jie Yang , Cezary Rojewski , Haojian Zhuang , linux-spi@vger.kernel.org, Liam Girdwood , Daniel Mack , linux-input@vger.kernel.org, Takashi Iwai , Robert Jarzmik , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Apr 23, 2021 at 05:56:30PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 07:34:28PM +0300, Andy Shevchenko wrote: > > > We have two headers split between include/linux and include/linux/spi. > > Consolidated them under SPI realm, i.e. in the latter folder. > > Why? Isn't the point to maintain an abstraction between the general > purpose use of the SSP IP and its application as a SPI controller? Aren't the General Purpose of the SSP IP is an SPI controller either way? What you are talking about is probably GP SPI vs. private (dedicated) SPI. But okay, I got the idea, I can drop this patch. > I'd > check the cover letter for the series but there doesn't seem to be one. Set of cleanups here and there related to the SPI PXA2xx driver. It's hard to add something else here. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A45D3C433ED for ; Fri, 23 Apr 2021 17:30:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6885661409 for ; Fri, 23 Apr 2021 17:30:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229957AbhDWRay (ORCPT ); Fri, 23 Apr 2021 13:30:54 -0400 Received: from mga06.intel.com ([134.134.136.31]:28650 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbhDWRay (ORCPT ); Fri, 23 Apr 2021 13:30:54 -0400 IronPort-SDR: HH7J0U3oyCG414KCwiaIxEOQyMXv+p9cFG6DYK4E5+h2aU8d1QQruvQA6r6eBU7Soh+EylEHoJ 6Z2IKDtw2CbA== X-IronPort-AV: E=McAfee;i="6200,9189,9963"; a="257411468" X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="257411468" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 10:30:16 -0700 IronPort-SDR: H9+pJ0RnWOxq95zAbxojlapA9H16lEreXz5ioaDa6GiMX0Jc7ksJcaW+a51sLjX3NXrGLdTt9x Yd6R36OQH8PA== X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="386443849" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 10:30:11 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lZzd2-006cKS-BS; Fri, 23 Apr 2021 20:30:08 +0300 Date: Fri, 23 Apr 2021 20:30:08 +0300 From: Andy Shevchenko To: Mark Brown Cc: Cezary Rojewski , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, alsa-devel@alsa-project.org, Dmitry Torokhov , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 05/14] spi: pxa2xx: Consolidate related headers under include/linux/spi Message-ID: References: <20210423163437.89306-1-andriy.shevchenko@linux.intel.com> <20210423163437.89306-5-andriy.shevchenko@linux.intel.com> <20210423165630.GH5507@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423165630.GH5507@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Apr 23, 2021 at 05:56:30PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 07:34:28PM +0300, Andy Shevchenko wrote: > > > We have two headers split between include/linux and include/linux/spi. > > Consolidated them under SPI realm, i.e. in the latter folder. > > Why? Isn't the point to maintain an abstraction between the general > purpose use of the SSP IP and its application as a SPI controller? Aren't the General Purpose of the SSP IP is an SPI controller either way? What you are talking about is probably GP SPI vs. private (dedicated) SPI. But okay, I got the idea, I can drop this patch. > I'd > check the cover letter for the series but there doesn't seem to be one. Set of cleanups here and there related to the SPI PXA2xx driver. It's hard to add something else here. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16394C433B4 for ; Fri, 23 Apr 2021 17:32:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AACC86124B for ; Fri, 23 Apr 2021 17:32:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AACC86124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mQBKUA/08PaeCplo0clS9VozWR+9PVKSpTU/UfMaxAI=; b=CBDtz4ykeKBXlwL+wlNOQAJTb cSkD84AjryAip0JaGBd3eIHzq+afpcAmW0yMUJ5YfZnF2t1WM3xM7EVB50N4oH8Ika2ektc33sik0 4246NSYBy+7BEQtajsrKg0QhmVSmHe90Hxk4U/Ip3R6GWV4TbOFuK/hd0BCWnnQWW+uy3IyiFc9VO d7as4nDwraF6cjrQQ5sSwt3MldPIDIPbu8RBo8kZLyY+Tkj6+n2Xchvdbr0gN3KxiZNSgb6kwBEOq L8AvlRcyo+Q67YYFj9P5RwrfG28Xt7qP76X8DnmvG1Jo6EGibzUX7xxCIef52ZSoIpLGV9WW/pyIN CEnE5NaLg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZzdH-00218C-0T; Fri, 23 Apr 2021 17:30:23 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZzdE-00217m-DP for linux-arm-kernel@desiato.infradead.org; Fri, 23 Apr 2021 17:30:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5a2BMwB0+f2FBTWRcI1Vd7xsLz11pJeo+plW7z+j5t8=; b=zH2gQksFe4dY3S1eqsq6aw9054 vKFkaTM5DeqB4oe2j4RU1i2sWPll8pXRJylpDDvTZTfU08oIKV3hwDpI1+g3AZcV3jb5bY/zEDFps cS2JWRNJeWmQGYE2PYOBVpnVdwA2KpGcpcuFa0KTui7ohHcGWkkdlQ1kNU6gWo2x1MrCUiIDzI7OQ 0qWgIqzANbYgUrR/BxbfkYat1/lOfAk0IuvCNO5B/f5d6aRAclUPtkHqa/le7xDjAKYGOVfuxLfFR 5ImBVFaF81eMfTQSrM2IqEmeFY7nkdqb3QXiProQzDbCp2hB20+5sOuTme7LSD8+uTnP3Mz0REjP5 tf/shUwA==; Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZzdB-00Eaol-RM for linux-arm-kernel@lists.infradead.org; Fri, 23 Apr 2021 17:30:19 +0000 IronPort-SDR: YlNw6c0UzB18vVCgyYbCC9R2nrSZEKVkWG4ppsAFkOK6c0B1UT9vo1sMEBcMkPtaOWtbjz1KdK Woj+xow7LHkA== X-IronPort-AV: E=McAfee;i="6200,9189,9963"; a="193988219" X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="193988219" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 10:30:16 -0700 IronPort-SDR: H9+pJ0RnWOxq95zAbxojlapA9H16lEreXz5ioaDa6GiMX0Jc7ksJcaW+a51sLjX3NXrGLdTt9x Yd6R36OQH8PA== X-IronPort-AV: E=Sophos;i="5.82,246,1613462400"; d="scan'208";a="386443849" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2021 10:30:11 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lZzd2-006cKS-BS; Fri, 23 Apr 2021 20:30:08 +0300 Date: Fri, 23 Apr 2021 20:30:08 +0300 From: Andy Shevchenko To: Mark Brown Cc: Cezary Rojewski , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, alsa-devel@alsa-project.org, Dmitry Torokhov , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 05/14] spi: pxa2xx: Consolidate related headers under include/linux/spi Message-ID: References: <20210423163437.89306-1-andriy.shevchenko@linux.intel.com> <20210423163437.89306-5-andriy.shevchenko@linux.intel.com> <20210423165630.GH5507@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210423165630.GH5507@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210423_103017_927878_14C2966F X-CRM114-Status: GOOD ( 13.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 23, 2021 at 05:56:30PM +0100, Mark Brown wrote: > On Fri, Apr 23, 2021 at 07:34:28PM +0300, Andy Shevchenko wrote: > > > We have two headers split between include/linux and include/linux/spi. > > Consolidated them under SPI realm, i.e. in the latter folder. > > Why? Isn't the point to maintain an abstraction between the general > purpose use of the SSP IP and its application as a SPI controller? Aren't the General Purpose of the SSP IP is an SPI controller either way? What you are talking about is probably GP SPI vs. private (dedicated) SPI. But okay, I got the idea, I can drop this patch. > I'd > check the cover letter for the series but there doesn't seem to be one. Set of cleanups here and there related to the SPI PXA2xx driver. It's hard to add something else here. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel