From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31BFC433ED for ; Sun, 25 Apr 2021 06:59:37 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 3D78961208 for ; Sun, 25 Apr 2021 06:59:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D78961208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BF3174B52A; Sun, 25 Apr 2021 02:59:36 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uW2nexjsQjHl; Sun, 25 Apr 2021 02:59:34 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 826284B0B2; Sun, 25 Apr 2021 02:59:34 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3406B4B090 for ; Sun, 25 Apr 2021 02:59:33 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 36kdzJzCQn7P for ; Sun, 25 Apr 2021 02:59:32 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id D8A8E4B51D for ; Sun, 25 Apr 2021 02:59:31 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 40FB46023B; Sun, 25 Apr 2021 06:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619333969; bh=ALZmUg3aLVOMwTOpSkzKAu3QbSkOH0nkV19EGy5CnWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZTkBA1bAi227vq8nv7Y3635yQJXT4Dm9rXiN9XadbtKqV0vegdA4EYsMfQGwBg7bh fTxh7S3Q+utvZRMgunLLzZR2H6SWAqRs3SM0bbIezJGwNJ65hYW0SQ0rDrnNxdsRgk STaTVMIop+tRNiVtTjMmeBPPfXP+Bu2zJxuAaeBZGvk5awCTT47WPZgCi5q3p7hga+ 7ZWjc0MfUT2awSF/RVlYPYoagO5R328dq/OVCYOIwewc9wMN+zkbedbqEtHk3lQ9k+ 1DmOGz2COpdWYXfZ03tPJqud7ZB8paNMhg5qZsTaOuzMEH5A83kANNkAAxOfZCfv0n sqFwgjLUO+5Yg== Date: Sun, 25 Apr 2021 09:59:20 +0300 From: Mike Rapoport To: Kefeng Wang Subject: Re: [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Message-ID: References: <20210421065108.1987-1-rppt@kernel.org> <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> Cc: David Hildenbrand , Catalin Marinas , Anshuman Khandual , linux-kernel@vger.kernel.org, Mike Rapoport , linux-mm@kvack.org, kvmarm@lists.cs.columbia.edu, Marc Zyngier , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVGh1LCBBcHIgMjIsIDIwMjEgYXQgMTE6Mjg6MjRQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3Jv dGU6Cj4gCj4gT24gMjAyMS80LzIyIDE1OjI5LCBNaWtlIFJhcG9wb3J0IHdyb3RlOgo+ID4gT24g VGh1LCBBcHIgMjIsIDIwMjEgYXQgMDM6MDA6MjBQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3JvdGU6 Cj4gPiA+IE9uIDIwMjEvNC8yMSAxNDo1MSwgTWlrZSBSYXBvcG9ydCB3cm90ZToKPiA+ID4gPiBG cm9tOiBNaWtlIFJhcG9wb3J0IDxycHB0QGxpbnV4LmlibS5jb20+Cj4gPiA+ID4gCj4gPiA+ID4g SGksCj4gPiA+ID4gCj4gPiA+ID4gVGhlc2UgcGF0Y2hlcyBhaW0gdG8gcmVtb3ZlIENPTkZJR19I T0xFU19JTl9aT05FIGFuZCBlc3NlbnRpYWxseSBoYXJkd2lyZQo+ID4gPiA+IHBmbl92YWxpZF93 aXRoaW4oKSB0byAxLgo+ID4gPiA+IAo+ID4gPiA+IFRoZSBpZGVhIGlzIHRvIG1hcmsgTk9NQVAg cGFnZXMgYXMgcmVzZXJ2ZWQgaW4gdGhlIG1lbW9yeSBtYXAgYW5kIHJlc3RvcmUKPiA+ID4gPiB0 aGUgaW50ZW5kZWQgc2VtYW50aWNzIG9mIHBmbl92YWxpZCgpIHRvIGRlc2lnbmF0ZSBhdmFpbGFi aWxpdHkgb2Ygc3RydWN0Cj4gPiA+ID4gcGFnZSBmb3IgYSBwZm4uCj4gPiA+ID4gCj4gPiA+ID4g V2l0aCB0aGlzIHRoZSBjb3JlIG1tIHdpbGwgYmUgYWJsZSB0byBjb3BlIHdpdGggdGhlIGZhY3Qg dGhhdCBpdCBjYW5ub3QgdXNlCj4gPiA+ID4gTk9NQVAgcGFnZXMgYW5kIHRoZSBob2xlcyBjcmVh dGVkIGJ5IE5PTUFQIHJhbmdlcyB3aXRoaW4gTUFYX09SREVSIGJsb2Nrcwo+ID4gPiA+IHdpbGwg YmUgdHJlYXRlZCBjb3JyZWN0bHkgZXZlbiB3aXRob3V0IHRoZSBuZWVkIGZvciBwZm5fdmFsaWRf d2l0aGluLgo+ID4gPiA+IAo+ID4gPiA+IFRoZSBwYXRjaGVzIGFyZSBvbmx5IGJvb3QgdGVzdGVk IG9uIHFlbXUtc3lzdGVtLWFhcmNoNjQgc28gSSdkIHJlYWxseQo+ID4gPiA+IGFwcHJlY2lhdGUg bWVtb3J5IHN0cmVzcyB0ZXN0cyBvbiByZWFsIGhhcmR3YXJlLgo+ID4gPiA+IAo+ID4gPiA+IElm IHRoaXMgYWN0dWFsbHkgd29ya3Mgd2UnbGwgYmUgb25lIHN0ZXAgY2xvc2VyIHRvIGRyb3AgY3Vz dG9tIHBmbl92YWxpZCgpCj4gPiA+ID4gb24gYXJtNjQgYWx0b2dldGhlci4KPiA+ID4gSGkgTWlr Ze+8jEkgaGF2ZSBhIHF1ZXN0aW9uLCB3aXRob3V0IEhPTEVTX0lOX1pPTkUsIHRoZSBwZm5fdmFs aWRfd2l0aGluKCkgaW4KPiA+ID4gbW92ZV9mcmVlcGFnZXNfYmxvY2soKS0+bW92ZV9mcmVlcGFn ZXMoKQo+ID4gPiB3aWxsIGJlIG9wdGltaXplZCwgaWYgdGhlcmUgYXJlIGhvbGVzIGluIHpvbmUs IHRoZSAnc3RydWNlIHBhZ2UnKG1lbW9yeSBtYXApCj4gPiA+IGZvciBwZm4gcmFuZ2Ugb2YgaG9s ZSB3aWxsIGJlIGZyZWUgYnkKPiA+ID4gZnJlZV9tZW1tYXAoKSwgYW5kIHRoZW4gdGhlIHBhZ2Ug dHJhdmVyc2UgaW4gdGhlIHpvbmUod2l0aCBob2xlcykgZnJvbQo+ID4gPiBtb3ZlX2ZyZWVwYWdl cygpIHdpbGwgbWVldCB0aGUgd3JvbmcgcGFnZe+8jAo+ID4gPiB0aGVuIGl0IGNvdWxkIHBhbmlj IGF0IFBhZ2VMUlUocGFnZSkgdGVzdCwgY2hlY2sgbGlua1sxXSwKPiA+IEZpcnN0LCBIT0xFU19J Tl9aT05FIG5hbWUgdXMgaHVnZWx5IG1pc2xlYWRpbmcsIHRoaXMgY29uZmlndXJhdGlvbiBvcHRp b24KPiA+IGhhcyBub3RoaW5nIHRvIHRvIHdpdGggbWVtb3J5IGhvbGVzLCBidXQgcmF0aGVyIGl0 IGlzIHRoZXJlIHRvIGRlYWwgd2l0aAo+ID4gaG9sZXMgb3IgdW5kZWZpbmVkIHN0cnVjdCBwYWdl cyBpbiB0aGUgbWVtb3J5IG1hcCwgd2hlbiB0aGVzZSBob2xlcyBjYW4gYmUKPiA+IGluc2lkZSBh IE1BWF9PUkRFUl9OUl9QQUdFUyByZWdpb24uCj4gPiAKPiA+IEluIGdlbmVyYWwgcGZuIHdhbGtl cnMgdXNlIHBmbl92YWxpZCgpIGFuZCBwZm5fdmFsaWRfd2l0aGluKCkgdG8gYXZvaWQKPiA+IGFj Y2Vzc2luZyAqbWlzc2luZyogc3RydWN0IHBhZ2VzLCBsaWtlIHRob3NlIHRoYXQgYXJlIGZyZWVk IGF0Cj4gPiBmcmVlX21lbW1hcCgpLiBCdXQgb24gYXJtNjQgdGhlc2UgdGVzdHMgYWxzbyBmaWx0 ZXIgb3V0IHRoZSBub21hcCBlbnRyaWVzCj4gPiBiZWNhdXNlIHRoZWlyIHN0cnVjdCBwYWdlcyBh cmUgbm90IGluaXRpYWxpemVkLgo+ID4gCj4gPiBUaGUgcGFuaWMgeW91IHJlZmVyIHRvIGhhcHBl bmVkIGJlY2F1c2UgdGhlcmUgd2FzIGFuIHVuaW5pdGlhbGl6ZWQgc3RydWN0Cj4gPiBwYWdlIGlu IHRoZSBtaWRkbGUgb2YgTUFYX09SREVSX05SX1BBR0VTIHJlZ2lvbiBiZWNhdXNlIGl0IGNvcnJl c3BvbmRlZCB0bwo+ID4gbm9tYXAgbWVtb3J5Lgo+ID4gCj4gPiBXaXRoIHRoZXNlIGNoYW5nZXMg SSBtYWtlIHN1cmUgdGhhdCBzdWNoIHBhZ2VzIHdpbGwgYmUgcHJvcGVybHkgaW5pdGlhbGl6ZWQK PiA+IGFzIFBhZ2VSZXNlcnZlZCBhbmQgdGhlIHBmbiB3YWxrZXJzIHdpbGwgYmUgYWJsZSB0byBy ZWx5IG9uIHRoZSBtZW1vcnkgbWFwLgo+ID4gCj4gPiBOb3RlIGFsc28sIHRoYXQgZnJlZV9tZW1t YXAoKSBhbGlnbnMgdGhlIHBhcnRzIGJlaW5nIGZyZWVkIG9uIE1BWF9PUkRFUgo+ID4gYm91bmRh cmllcywgc28gdGhlcmUgd2lsbCBiZSBubyBtaXNzaW5nIHBhcnRzIGluIHRoZSBtZW1vcnkgbWFw IHdpdGhpbiBhCj4gPiBNQVhfT1JERVJfTlJfUEFHRVMgcmVnaW9uLgo+IAo+IE9rLCB0aGFua3Ms IHdlIG1ldCBhIHNhbWUgcGFuaWMgbGlrZSB0aGUgbGluayBvbiBhcm0zMih3aXRob3V0Cj4gSE9M RVNfSU5fWk9ORSksCj4gCj4gdGhlIHNjaGVtZSBmb3IgYXJtNjQgY291bGQgYmUgc3VpdCBmb3Ig YXJtMzIsIHJpZ2h0PwoKSW4gZ2VuZXJhbCB5ZXMuIFlvdSBqdXN0IG5lZWQgdG8gbWFrZSBzdXJl IHRoYXQgdXNhZ2Ugb2YgcGZuX3ZhbGlkKCkgaW4KYXJjaC9hcm0gZG9lcyBub3QgcHJlc3VtZSB0 aGF0IGl0IHRlc3RzIHNvbWV0aGluZyBiZXlvbmQgYXZhaWxhYmlsaXR5IG9mCnN0cnVjdCBwYWdl IGZvciBhIHBmbi4KIAo+wqBJIHdpbGwgdHJ5IHRoZSBwYXRjaHNldCB3aXRoIHNvbWUgY2hhbmdl cyBvbiBhcm0zMiBhbmQgZ2l2ZSBzb21lCj4gZmVlZGJhY2suCj4gCj4gQWdhaW4sIHRoZSBzdHVw aWQgcXVlc3Rpb24sIHdoZXJlIHdpbGwgbWFyayB0aGUgcmVnaW9uIG9mIG1lbWJsb2NrIHdpdGgK PiBNRU1CTE9DS19OT01BUCBmbGFnID8KIApOb3Qgc3VyZSBJIHVuZGVyc3RhbmQgdGhlIHF1ZXN0 aW9uLiBUaGUgbWVtb3J5IHJlZ2lvbnMgd2l0aCAibm9tYXAiCnByb3BlcnR5IGluIHRoZSBkZXZp Y2UgdHJlZSB3aWxsIGJlIG1hcmtlZCBNRU1CTE9DS19OT01BUC4KIAo+ID4gPiAiVGhlIGlkZWEg aXMgdG8gbWFyayBOT01BUCBwYWdlcyBhcyByZXNlcnZlZCBpbiB0aGUgbWVtb3J5IG1hcCIsIEkg c2VlIHRoZQo+ID4gPiBwYXRjaDIgY2hlY2sgbWVtYmxvY2tfaXNfbm9tYXAoKSBpbiBtZW1vcnkg cmVnaW9uCj4gPiA+IG9mIG1lbWJsb2NrLCBidXQgaXQgc2VlbXMgdGhhdCBtZW1ibG9ja19tYXJr X25vbWFwKCkgaXMgbm90IGNhbGxlZChtYXliZSBJCj4gPiA+IG1pc3NlZCksIHRoZW4gbWVtbWFw X2luaXRfcmVzZXJ2ZWRfcGFnZXMoKSB3b24ndAo+ID4gPiB3b3JrLCBzbyBzaG91bGQgdGhlIEhP TEVTX0lOX1pPTkUgc3RpbGwgYmUgbmVlZGVkIGZvciBnZW5lcmljIG1tIGNvZGU/Cj4gPiA+IAo+ ID4gPiBbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtYXJtLWtlcm5lbC81NDExOTNh Ni0yYmNlLWYwNDItNWJiMi04ODkxM2Q1ZjEwNDdAYXJtLmNvbS8KPiA+ID4gCgotLSAKU2luY2Vy ZWx5IHlvdXJzLApNaWtlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUK aHR0cHM6Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A31CC433B4 for ; Sun, 25 Apr 2021 07:01:55 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06CE56023B for ; Sun, 25 Apr 2021 07:01:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06CE56023B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kW/qHY3psjn0jUdwDY6N+CEuAFRlmLhflCnm4gn91L8=; b=ERGwpv+vWktwHsn/0nDgvG7AD 9YDM1v5VuqXXFCDbLoruPF5AAYZPa/nCIrKDJOpwOSUgFIv2SyDQPLKQkJK+nv2UpyuIyRwCSrEPE yWDpulMpgzt7EStM7kb+mJgV/smTxe2aI5QjelMi4qnLqd3tfTGniY7f/j242GeU9mViQC/DhR0BK 7Dq5fTP+FdRZ3Cer+p4h61jvKEmRkAKddJmG4YYEY3qBTNNOrAqjbTLPIdy9M4JVVlwyW8keVTxQ+ B+zZ6kuiPV2P6h7CaXiTkPcWi4E0rZOvn9PeO4rE4ghqDvzlHIjZdyNyoYF+DNlDiR+SMzw/P05Ul fl4jOL/uw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1laYk0-005AGl-60; Sun, 25 Apr 2021 06:59:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1laYjx-005AGf-33 for linux-arm-kernel@desiato.infradead.org; Sun, 25 Apr 2021 06:59:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=DxzgvmMFykwMiUK5rWNSkS4INFYvFmZUlQ2HFmoThWE=; b=yh3LfRYfhwRa+C/gjJ/FZwVbui qXGc/sC9/jKDSmkz7orIJfrCRGswU97ASNIil9D6LBJ1ck2Btb6CcJui5gev4/rjwLx5ibLEPVpAa psI4VGFip9nsad9yvP9pHCvI1oRqpujVAHiaLWhwwFzTFW3ZHBfOU2v+NpQYYXb0TqnkiRWntXXRC RMKbRvKuEa8hvuGHJjTgrpDh94UbKYancvPWQ67EgC82e1UI3l/oF8Ncf5YkYoxkK7A7gh/luc2Y2 YWu7B8V9+xr4rfZvTgbk7wpmGObafW74xo5ZnB5pBhL9kHE451OELt/97YJ4Kcof+dyi/JcM/bqPh klfOXq+g==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1laYju-00FJbm-6c for linux-arm-kernel@lists.infradead.org; Sun, 25 Apr 2021 06:59:35 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 40FB46023B; Sun, 25 Apr 2021 06:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619333969; bh=ALZmUg3aLVOMwTOpSkzKAu3QbSkOH0nkV19EGy5CnWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZTkBA1bAi227vq8nv7Y3635yQJXT4Dm9rXiN9XadbtKqV0vegdA4EYsMfQGwBg7bh fTxh7S3Q+utvZRMgunLLzZR2H6SWAqRs3SM0bbIezJGwNJ65hYW0SQ0rDrnNxdsRgk STaTVMIop+tRNiVtTjMmeBPPfXP+Bu2zJxuAaeBZGvk5awCTT47WPZgCi5q3p7hga+ 7ZWjc0MfUT2awSF/RVlYPYoagO5R328dq/OVCYOIwewc9wMN+zkbedbqEtHk3lQ9k+ 1DmOGz2COpdWYXfZ03tPJqud7ZB8paNMhg5qZsTaOuzMEH5A83kANNkAAxOfZCfv0n sqFwgjLUO+5Yg== Date: Sun, 25 Apr 2021 09:59:20 +0300 From: Mike Rapoport To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Message-ID: References: <20210421065108.1987-1-rppt@kernel.org> <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210424_235934_304912_64A84916 X-CRM114-Status: GOOD ( 37.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMjIsIDIwMjEgYXQgMTE6Mjg6MjRQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3Jv dGU6Cj4gCj4gT24gMjAyMS80LzIyIDE1OjI5LCBNaWtlIFJhcG9wb3J0IHdyb3RlOgo+ID4gT24g VGh1LCBBcHIgMjIsIDIwMjEgYXQgMDM6MDA6MjBQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3JvdGU6 Cj4gPiA+IE9uIDIwMjEvNC8yMSAxNDo1MSwgTWlrZSBSYXBvcG9ydCB3cm90ZToKPiA+ID4gPiBG cm9tOiBNaWtlIFJhcG9wb3J0IDxycHB0QGxpbnV4LmlibS5jb20+Cj4gPiA+ID4gCj4gPiA+ID4g SGksCj4gPiA+ID4gCj4gPiA+ID4gVGhlc2UgcGF0Y2hlcyBhaW0gdG8gcmVtb3ZlIENPTkZJR19I T0xFU19JTl9aT05FIGFuZCBlc3NlbnRpYWxseSBoYXJkd2lyZQo+ID4gPiA+IHBmbl92YWxpZF93 aXRoaW4oKSB0byAxLgo+ID4gPiA+IAo+ID4gPiA+IFRoZSBpZGVhIGlzIHRvIG1hcmsgTk9NQVAg cGFnZXMgYXMgcmVzZXJ2ZWQgaW4gdGhlIG1lbW9yeSBtYXAgYW5kIHJlc3RvcmUKPiA+ID4gPiB0 aGUgaW50ZW5kZWQgc2VtYW50aWNzIG9mIHBmbl92YWxpZCgpIHRvIGRlc2lnbmF0ZSBhdmFpbGFi aWxpdHkgb2Ygc3RydWN0Cj4gPiA+ID4gcGFnZSBmb3IgYSBwZm4uCj4gPiA+ID4gCj4gPiA+ID4g V2l0aCB0aGlzIHRoZSBjb3JlIG1tIHdpbGwgYmUgYWJsZSB0byBjb3BlIHdpdGggdGhlIGZhY3Qg dGhhdCBpdCBjYW5ub3QgdXNlCj4gPiA+ID4gTk9NQVAgcGFnZXMgYW5kIHRoZSBob2xlcyBjcmVh dGVkIGJ5IE5PTUFQIHJhbmdlcyB3aXRoaW4gTUFYX09SREVSIGJsb2Nrcwo+ID4gPiA+IHdpbGwg YmUgdHJlYXRlZCBjb3JyZWN0bHkgZXZlbiB3aXRob3V0IHRoZSBuZWVkIGZvciBwZm5fdmFsaWRf d2l0aGluLgo+ID4gPiA+IAo+ID4gPiA+IFRoZSBwYXRjaGVzIGFyZSBvbmx5IGJvb3QgdGVzdGVk IG9uIHFlbXUtc3lzdGVtLWFhcmNoNjQgc28gSSdkIHJlYWxseQo+ID4gPiA+IGFwcHJlY2lhdGUg bWVtb3J5IHN0cmVzcyB0ZXN0cyBvbiByZWFsIGhhcmR3YXJlLgo+ID4gPiA+IAo+ID4gPiA+IElm IHRoaXMgYWN0dWFsbHkgd29ya3Mgd2UnbGwgYmUgb25lIHN0ZXAgY2xvc2VyIHRvIGRyb3AgY3Vz dG9tIHBmbl92YWxpZCgpCj4gPiA+ID4gb24gYXJtNjQgYWx0b2dldGhlci4KPiA+ID4gSGkgTWlr Ze+8jEkgaGF2ZSBhIHF1ZXN0aW9uLCB3aXRob3V0IEhPTEVTX0lOX1pPTkUsIHRoZSBwZm5fdmFs aWRfd2l0aGluKCkgaW4KPiA+ID4gbW92ZV9mcmVlcGFnZXNfYmxvY2soKS0+bW92ZV9mcmVlcGFn ZXMoKQo+ID4gPiB3aWxsIGJlIG9wdGltaXplZCwgaWYgdGhlcmUgYXJlIGhvbGVzIGluIHpvbmUs IHRoZSAnc3RydWNlIHBhZ2UnKG1lbW9yeSBtYXApCj4gPiA+IGZvciBwZm4gcmFuZ2Ugb2YgaG9s ZSB3aWxsIGJlIGZyZWUgYnkKPiA+ID4gZnJlZV9tZW1tYXAoKSwgYW5kIHRoZW4gdGhlIHBhZ2Ug dHJhdmVyc2UgaW4gdGhlIHpvbmUod2l0aCBob2xlcykgZnJvbQo+ID4gPiBtb3ZlX2ZyZWVwYWdl cygpIHdpbGwgbWVldCB0aGUgd3JvbmcgcGFnZe+8jAo+ID4gPiB0aGVuIGl0IGNvdWxkIHBhbmlj IGF0IFBhZ2VMUlUocGFnZSkgdGVzdCwgY2hlY2sgbGlua1sxXSwKPiA+IEZpcnN0LCBIT0xFU19J Tl9aT05FIG5hbWUgdXMgaHVnZWx5IG1pc2xlYWRpbmcsIHRoaXMgY29uZmlndXJhdGlvbiBvcHRp b24KPiA+IGhhcyBub3RoaW5nIHRvIHRvIHdpdGggbWVtb3J5IGhvbGVzLCBidXQgcmF0aGVyIGl0 IGlzIHRoZXJlIHRvIGRlYWwgd2l0aAo+ID4gaG9sZXMgb3IgdW5kZWZpbmVkIHN0cnVjdCBwYWdl cyBpbiB0aGUgbWVtb3J5IG1hcCwgd2hlbiB0aGVzZSBob2xlcyBjYW4gYmUKPiA+IGluc2lkZSBh IE1BWF9PUkRFUl9OUl9QQUdFUyByZWdpb24uCj4gPiAKPiA+IEluIGdlbmVyYWwgcGZuIHdhbGtl cnMgdXNlIHBmbl92YWxpZCgpIGFuZCBwZm5fdmFsaWRfd2l0aGluKCkgdG8gYXZvaWQKPiA+IGFj Y2Vzc2luZyAqbWlzc2luZyogc3RydWN0IHBhZ2VzLCBsaWtlIHRob3NlIHRoYXQgYXJlIGZyZWVk IGF0Cj4gPiBmcmVlX21lbW1hcCgpLiBCdXQgb24gYXJtNjQgdGhlc2UgdGVzdHMgYWxzbyBmaWx0 ZXIgb3V0IHRoZSBub21hcCBlbnRyaWVzCj4gPiBiZWNhdXNlIHRoZWlyIHN0cnVjdCBwYWdlcyBh cmUgbm90IGluaXRpYWxpemVkLgo+ID4gCj4gPiBUaGUgcGFuaWMgeW91IHJlZmVyIHRvIGhhcHBl bmVkIGJlY2F1c2UgdGhlcmUgd2FzIGFuIHVuaW5pdGlhbGl6ZWQgc3RydWN0Cj4gPiBwYWdlIGlu IHRoZSBtaWRkbGUgb2YgTUFYX09SREVSX05SX1BBR0VTIHJlZ2lvbiBiZWNhdXNlIGl0IGNvcnJl c3BvbmRlZCB0bwo+ID4gbm9tYXAgbWVtb3J5Lgo+ID4gCj4gPiBXaXRoIHRoZXNlIGNoYW5nZXMg SSBtYWtlIHN1cmUgdGhhdCBzdWNoIHBhZ2VzIHdpbGwgYmUgcHJvcGVybHkgaW5pdGlhbGl6ZWQK PiA+IGFzIFBhZ2VSZXNlcnZlZCBhbmQgdGhlIHBmbiB3YWxrZXJzIHdpbGwgYmUgYWJsZSB0byBy ZWx5IG9uIHRoZSBtZW1vcnkgbWFwLgo+ID4gCj4gPiBOb3RlIGFsc28sIHRoYXQgZnJlZV9tZW1t YXAoKSBhbGlnbnMgdGhlIHBhcnRzIGJlaW5nIGZyZWVkIG9uIE1BWF9PUkRFUgo+ID4gYm91bmRh cmllcywgc28gdGhlcmUgd2lsbCBiZSBubyBtaXNzaW5nIHBhcnRzIGluIHRoZSBtZW1vcnkgbWFw IHdpdGhpbiBhCj4gPiBNQVhfT1JERVJfTlJfUEFHRVMgcmVnaW9uLgo+IAo+IE9rLCB0aGFua3Ms IHdlIG1ldCBhIHNhbWUgcGFuaWMgbGlrZSB0aGUgbGluayBvbiBhcm0zMih3aXRob3V0Cj4gSE9M RVNfSU5fWk9ORSksCj4gCj4gdGhlIHNjaGVtZSBmb3IgYXJtNjQgY291bGQgYmUgc3VpdCBmb3Ig YXJtMzIsIHJpZ2h0PwoKSW4gZ2VuZXJhbCB5ZXMuIFlvdSBqdXN0IG5lZWQgdG8gbWFrZSBzdXJl IHRoYXQgdXNhZ2Ugb2YgcGZuX3ZhbGlkKCkgaW4KYXJjaC9hcm0gZG9lcyBub3QgcHJlc3VtZSB0 aGF0IGl0IHRlc3RzIHNvbWV0aGluZyBiZXlvbmQgYXZhaWxhYmlsaXR5IG9mCnN0cnVjdCBwYWdl IGZvciBhIHBmbi4KIAo+wqBJIHdpbGwgdHJ5IHRoZSBwYXRjaHNldCB3aXRoIHNvbWUgY2hhbmdl cyBvbiBhcm0zMiBhbmQgZ2l2ZSBzb21lCj4gZmVlZGJhY2suCj4gCj4gQWdhaW4sIHRoZSBzdHVw aWQgcXVlc3Rpb24sIHdoZXJlIHdpbGwgbWFyayB0aGUgcmVnaW9uIG9mIG1lbWJsb2NrIHdpdGgK PiBNRU1CTE9DS19OT01BUCBmbGFnID8KIApOb3Qgc3VyZSBJIHVuZGVyc3RhbmQgdGhlIHF1ZXN0 aW9uLiBUaGUgbWVtb3J5IHJlZ2lvbnMgd2l0aCAibm9tYXAiCnByb3BlcnR5IGluIHRoZSBkZXZp Y2UgdHJlZSB3aWxsIGJlIG1hcmtlZCBNRU1CTE9DS19OT01BUC4KIAo+ID4gPiAiVGhlIGlkZWEg aXMgdG8gbWFyayBOT01BUCBwYWdlcyBhcyByZXNlcnZlZCBpbiB0aGUgbWVtb3J5IG1hcCIsIEkg c2VlIHRoZQo+ID4gPiBwYXRjaDIgY2hlY2sgbWVtYmxvY2tfaXNfbm9tYXAoKSBpbiBtZW1vcnkg cmVnaW9uCj4gPiA+IG9mIG1lbWJsb2NrLCBidXQgaXQgc2VlbXMgdGhhdCBtZW1ibG9ja19tYXJr X25vbWFwKCkgaXMgbm90IGNhbGxlZChtYXliZSBJCj4gPiA+IG1pc3NlZCksIHRoZW4gbWVtbWFw X2luaXRfcmVzZXJ2ZWRfcGFnZXMoKSB3b24ndAo+ID4gPiB3b3JrLCBzbyBzaG91bGQgdGhlIEhP TEVTX0lOX1pPTkUgc3RpbGwgYmUgbmVlZGVkIGZvciBnZW5lcmljIG1tIGNvZGU/Cj4gPiA+IAo+ ID4gPiBbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtYXJtLWtlcm5lbC81NDExOTNh Ni0yYmNlLWYwNDItNWJiMi04ODkxM2Q1ZjEwNDdAYXJtLmNvbS8KPiA+ID4gCgotLSAKU2luY2Vy ZWx5IHlvdXJzLApNaWtlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D349C433B4 for ; Sun, 25 Apr 2021 06:59:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AAD761208 for ; Sun, 25 Apr 2021 06:59:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AAD761208 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D156A6B0036; Sun, 25 Apr 2021 02:59:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C77446B006C; Sun, 25 Apr 2021 02:59:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACACB6B006E; Sun, 25 Apr 2021 02:59:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 873376B0036 for ; Sun, 25 Apr 2021 02:59:31 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2D1A41801D001 for ; Sun, 25 Apr 2021 06:59:31 +0000 (UTC) X-FDA: 78069988542.06.A8BF0C0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf01.hostedemail.com (Postfix) with ESMTP id 194595001531 for ; Sun, 25 Apr 2021 06:59:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 40FB46023B; Sun, 25 Apr 2021 06:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619333969; bh=ALZmUg3aLVOMwTOpSkzKAu3QbSkOH0nkV19EGy5CnWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZTkBA1bAi227vq8nv7Y3635yQJXT4Dm9rXiN9XadbtKqV0vegdA4EYsMfQGwBg7bh fTxh7S3Q+utvZRMgunLLzZR2H6SWAqRs3SM0bbIezJGwNJ65hYW0SQ0rDrnNxdsRgk STaTVMIop+tRNiVtTjMmeBPPfXP+Bu2zJxuAaeBZGvk5awCTT47WPZgCi5q3p7hga+ 7ZWjc0MfUT2awSF/RVlYPYoagO5R328dq/OVCYOIwewc9wMN+zkbedbqEtHk3lQ9k+ 1DmOGz2COpdWYXfZ03tPJqud7ZB8paNMhg5qZsTaOuzMEH5A83kANNkAAxOfZCfv0n sqFwgjLUO+5Yg== Date: Sun, 25 Apr 2021 09:59:20 +0300 From: Mike Rapoport To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid() Message-ID: References: <20210421065108.1987-1-rppt@kernel.org> <9aa68d26-d736-3b75-4828-f148964eb7f0@huawei.com> <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 194595001531 X-Stat-Signature: e4e3gx9ywdakzkiwqjj9yrdhayz7tgfk Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619333965-280374 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 22, 2021 at 11:28:24PM +0800, Kefeng Wang wrote: >=20 > On 2021/4/22 15:29, Mike Rapoport wrote: > > On Thu, Apr 22, 2021 at 03:00:20PM +0800, Kefeng Wang wrote: > > > On 2021/4/21 14:51, Mike Rapoport wrote: > > > > From: Mike Rapoport > > > >=20 > > > > Hi, > > > >=20 > > > > These patches aim to remove CONFIG_HOLES_IN_ZONE and essentially = hardwire > > > > pfn_valid_within() to 1. > > > >=20 > > > > The idea is to mark NOMAP pages as reserved in the memory map and= restore > > > > the intended semantics of pfn_valid() to designate availability o= f struct > > > > page for a pfn. > > > >=20 > > > > With this the core mm will be able to cope with the fact that it = cannot use > > > > NOMAP pages and the holes created by NOMAP ranges within MAX_ORDE= R blocks > > > > will be treated correctly even without the need for pfn_valid_wit= hin. > > > >=20 > > > > The patches are only boot tested on qemu-system-aarch64 so I'd re= ally > > > > appreciate memory stress tests on real hardware. > > > >=20 > > > > If this actually works we'll be one step closer to drop custom pf= n_valid() > > > > on arm64 altogether. > > > Hi Mike=EF=BC=8CI have a question, without HOLES_IN_ZONE, the pfn_v= alid_within() in > > > move_freepages_block()->move_freepages() > > > will be optimized, if there are holes in zone, the 'struce page'(me= mory map) > > > for pfn range of hole will be free by > > > free_memmap(), and then the page traverse in the zone(with holes) f= rom > > > move_freepages() will meet the wrong page=EF=BC=8C > > > then it could panic at PageLRU(page) test, check link[1], > > First, HOLES_IN_ZONE name us hugely misleading, this configuration op= tion > > has nothing to to with memory holes, but rather it is there to deal w= ith > > holes or undefined struct pages in the memory map, when these holes c= an be > > inside a MAX_ORDER_NR_PAGES region. > >=20 > > In general pfn walkers use pfn_valid() and pfn_valid_within() to avoi= d > > accessing *missing* struct pages, like those that are freed at > > free_memmap(). But on arm64 these tests also filter out the nomap ent= ries > > because their struct pages are not initialized. > >=20 > > The panic you refer to happened because there was an uninitialized st= ruct > > page in the middle of MAX_ORDER_NR_PAGES region because it correspond= ed to > > nomap memory. > >=20 > > With these changes I make sure that such pages will be properly initi= alized > > as PageReserved and the pfn walkers will be able to rely on the memor= y map. > >=20 > > Note also, that free_memmap() aligns the parts being freed on MAX_ORD= ER > > boundaries, so there will be no missing parts in the memory map withi= n a > > MAX_ORDER_NR_PAGES region. >=20 > Ok, thanks, we met a same panic like the link on arm32(without > HOLES_IN_ZONE), >=20 > the scheme for arm64 could be suit for arm32, right? In general yes. You just need to make sure that usage of pfn_valid() in arch/arm does not presume that it tests something beyond availability of struct page for a pfn. =20 >=C2=A0I will try the patchset with some changes on arm32 and give some > feedback. >=20 > Again, the stupid question, where will mark the region of memblock with > MEMBLOCK_NOMAP flag ? =20 Not sure I understand the question. The memory regions with "nomap" property in the device tree will be marked MEMBLOCK_NOMAP. =20 > > > "The idea is to mark NOMAP pages as reserved in the memory map", I = see the > > > patch2 check memblock_is_nomap() in memory region > > > of memblock, but it seems that memblock_mark_nomap() is not called(= maybe I > > > missed), then memmap_init_reserved_pages() won't > > > work, so should the HOLES_IN_ZONE still be needed for generic mm co= de? > > >=20 > > > [1] https://lore.kernel.org/linux-arm-kernel/541193a6-2bce-f042-5bb= 2-88913d5f1047@arm.com/ > > >=20 --=20 Sincerely yours, Mike.