From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01620C433B4 for ; Mon, 26 Apr 2021 12:20:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9ED4610FA for ; Mon, 26 Apr 2021 12:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233218AbhDZMUw (ORCPT ); Mon, 26 Apr 2021 08:20:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233212AbhDZMUv (ORCPT ); Mon, 26 Apr 2021 08:20:51 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E776EC061574 for ; Mon, 26 Apr 2021 05:20:07 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id x7so55619642wrw.10 for ; Mon, 26 Apr 2021 05:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tpH+QQEkbZc6+vtMNeOllqTuD3uDWkTb+lWH8HNjCTs=; b=QSDEI20mzX1NnoNCWr08mq8SOEaY1vu6Paox4yhODe+p9Vk4c/WbJuSkwucgHtrqn+ JYN/hTK+Ted76ldmtSxQSYyEMRz89/ApAToWbgY8mU15k+/ekhB3gcKVZSSVCO0DrGWf iLzg+ju/21RrjGp8FzDTyvfoqOysebrPqgGokz4sWNZHO0W7fqjTea08mtgJr69s97LP hGtVOGRiIR30SykPHgG/RLCM0F9io7Nr/ZBlRajUZPDOm6sJuHETNSl58XuIfqkxt3UD 790INAQfiKqQ4lTFsbbrshGdVpkyw+G+g2z6y83S19LH7Xmog+iAR2FcEmdevjvN3XYr iO/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tpH+QQEkbZc6+vtMNeOllqTuD3uDWkTb+lWH8HNjCTs=; b=F6l2aHTszbLH2oB67kIbI/t1/acWQMwXuKoX/0uQKEXStsJiIeIjI0jTqwXb77GcJW 5GX2Y0xfrQO4v7wuiCr5gNXTmUV3EyW95PjepIQGBwArn9RElnJGCQ0DRniiQSAzEynI kwB7zfRJVC3wyNcOxohFq6/CbW33ozVZ4tuit9C0sJqqlbX79jUFhfuCmyUkiP/YChHF Bnm61bI3tFGGcuwcBLr8IGVLV3E1NCt5etk8JyM37ShXsuG5/rcqwOVhHj2WC7pOyMsY cvw8hTiFObvalkbx3mmm9EGczVfS+uEh0K5V/iYqB4qS/6GHOR/3eBKMwnbURLOwTTuu 3Itw== X-Gm-Message-State: AOAM533fW48YDba9UWcONNQiojJ3ZRlHMtpiZnKOpX2N3QjdSLZ18bzk J3Tm0a8lGFryFFV5N4Fv+10= X-Google-Smtp-Source: ABdhPJzmgju8kLtqMK9vbZukR6yA680YTwi+CYecPgmEhe2wJpBt7xaf9+QjA03ehGAFvSVYJ00D8w== X-Received: by 2002:a05:6000:10f:: with SMTP id o15mr23256702wrx.98.1619439606750; Mon, 26 Apr 2021 05:20:06 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id j7sm4062410wmi.21.2021.04.26.05.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 05:20:05 -0700 (PDT) Date: Mon, 26 Apr 2021 14:20:58 +0200 From: Thierry Reding To: Krzysztof Kozlowski Cc: Jon Hunter , Dmitry Osipenko , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/10] memory: tegra: Extract setup code into callback Message-ID: References: <20210420165237.3523732-1-thierry.reding@gmail.com> <20210420165237.3523732-6-thierry.reding@gmail.com> <25ea4721-f9d3-ae4e-6310-73182ad43d8f@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RmJ7DJaEJuep+6vi" Content-Disposition: inline In-Reply-To: <25ea4721-f9d3-ae4e-6310-73182ad43d8f@canonical.com> User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org --RmJ7DJaEJuep+6vi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 26, 2021 at 10:58:27AM +0200, Krzysztof Kozlowski wrote: > On 20/04/2021 18:52, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Separate the setup code for Tegra30 and later into a ->setup() callback > > and set it for all applicable chips. >=20 > I assume the code is functionally equivalent - the same > tegra_mc_setup_latency_allowance() will be executed on all these SoCs? Yes, that's what was previously the case and this holds true after the patch. Really the only thing that this patch does is move that code into a separate callback in tegra_mc_ops so that it can be changed for later chips. Thierry --RmJ7DJaEJuep+6vi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmCGsCoACgkQ3SOs138+ s6F7UhAApiDpsLHbeR93j7puRDYR1iR+i+Vp/3pSNod9gTINo8CWny4Nl7dujlUa 9IiKQHze0Aj0rpeppnuZU6DYhGQAiwwDgSB1PDMEymS7mTb6CZfDO+zH2zANPQzp t0L4PO45otYWNTO0kPEMSH92Q7tyEm8slUY2DvzNksv6B3deuWPvVYQZris9qOdy 93oGDoQNIMcctD2Q0t5nw8qqJIjjP9d0nZEhUiDKLga3+k6lJNIIQlI3fXQkhsNb cxPK+dInWTPtVT6CvLoiuvKwx5TRz/owBWY/sZndsm2OL0qBJoa4MR+CTee5K9Ki u43L/qhogHyaV+H/2uywQWiZQUlGvHIhLB/Vk8VxkQrAC1gsH+153uMK5U9eIv0K dzch+hCWxeTCoe1FujdjDLpv6mybGAeuB38bydWOQaKbFDWBVKAFIj01LpVVto+W wV2rFnUJgmWJ6CCDgria9wIgVcwZeootfBKPMcjqH7ilpbuLW5zspmcaTcVU5zMY uVSlrtxLjWMrSlFJBF7weXuFxhCkUkOXhlsVyG4WDRgYw3h12Bkzs6PvUlDZ2Gig UJ6N3hLnyO0/OM9I+0PLf9oUcIPzsysCvO24Lq0Ky3nX6hAh3bCAWuWF9AkiIEVq xZ3eqVbTWx1taUWMVHFpvdITaosCHLxqxfQP1tCTLIsrNmCdQqw= =66RF -----END PGP SIGNATURE----- --RmJ7DJaEJuep+6vi-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE981C433ED for ; Mon, 26 Apr 2021 12:21:49 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40DC760233 for ; Mon, 26 Apr 2021 12:21:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40DC760233 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9V1EzYPj9hFM3a5qmwHgF5aW8QKtkEG1ahaI9LpQ0D8=; b=HhRfDQPyWPL99jCc1Irp19a7k h+NUcKcS6gsMbEWua/rn6a+u9UYWRmzYMhfjXR35F0TzF0XOzO37frIV6p6vcDbukMcDXE0AyJuyH sn1FFQrWuIIdHv/dnjwmXIcfdoeT5rjOjsfVWOngRxGSvgrEyGv/C7x4MSZ5fbRE+GdLe7PbSM3Dh EC8gXIiMFL5dOUN6gdEXebVIyezEo+LSLsdTwWhjzrz1dh8LDNnEr4eWD8LKaY1n3EGjETgdirmXb 7TOO2+cS/e67YngBMadJqYGNOstFbZfX/a9OAy5mU4VHdGKOE0zW7P6eWwCu1mfPrC+xiT8o/WEmm TD7+C6f2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb0Dm-007aju-9K; Mon, 26 Apr 2021 12:20:14 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb0Dj-007ajU-VC for linux-arm-kernel@desiato.infradead.org; Mon, 26 Apr 2021 12:20:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tpH+QQEkbZc6+vtMNeOllqTuD3uDWkTb+lWH8HNjCTs=; b=C6IJ79CvADPZGMZp6GP8lpRViH PcJXQLFkaNIbwPa7wM6hq8g8cFnswCrktbrI7/oW5MB4vN2JrOfRI67S9ENkA3Na883lakPuDLYAM hIsEP7UlpASh3pwOWJbcYfouvhmgPGho4BuPXbOtm9Zv9i33JwbBwyvire4v/8pMp9iv9QJrlfXnU B2KSd8zd5SPk6ya3AVy4/dtjgKf9nqLIe0xLdQRj/KZ7hqJDtLBuQzzI5Y/I5xKJybiEE+uyusE7Z gHmuMciQlUYpu5nvyJzKWzUq5yQUWr5x5pcgo09Q5DdEHFNyP4ciEMkzaZxm/LnJEEtNC3iHdv3g/ mwcZgTYg==; Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb0Dh-00Fx1M-BJ for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 12:20:10 +0000 Received: by mail-wr1-x432.google.com with SMTP id n2so2500029wrm.0 for ; Mon, 26 Apr 2021 05:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tpH+QQEkbZc6+vtMNeOllqTuD3uDWkTb+lWH8HNjCTs=; b=QSDEI20mzX1NnoNCWr08mq8SOEaY1vu6Paox4yhODe+p9Vk4c/WbJuSkwucgHtrqn+ JYN/hTK+Ted76ldmtSxQSYyEMRz89/ApAToWbgY8mU15k+/ekhB3gcKVZSSVCO0DrGWf iLzg+ju/21RrjGp8FzDTyvfoqOysebrPqgGokz4sWNZHO0W7fqjTea08mtgJr69s97LP hGtVOGRiIR30SykPHgG/RLCM0F9io7Nr/ZBlRajUZPDOm6sJuHETNSl58XuIfqkxt3UD 790INAQfiKqQ4lTFsbbrshGdVpkyw+G+g2z6y83S19LH7Xmog+iAR2FcEmdevjvN3XYr iO/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tpH+QQEkbZc6+vtMNeOllqTuD3uDWkTb+lWH8HNjCTs=; b=D0UobUPVeune/Gmb1CQdAIyfn/7wVXNN1UN1Wb7vp1QAbqsCPWGEG+ys9CkwBz3E6H 5RjCXabHtaTHxvsjxUJG4lzffyx+ZBHEH+pkM7pPZgd0wKxZhHNF3b6wS1xXGgrC6Vvy 3peGO3FNmj0ZVsOSBOuemWoME/1rUv3Wszgnweq+Gie5lS1kXdTPXEZdCTjGJbDf/WAj SGDHE0JTn8v+EwkjYXyS9475h+rE3QJ4RGzLVEeMzWiJfgl9oSb/vm4wr+g68XUDJz70 FeS5jiyTTpNhcVdAmWiR4aZdlhPdY6ny2R4yZCjMlC9vPgHyxDiqdu3fPLFZu+SnPbKF qkWw== X-Gm-Message-State: AOAM533MPvYI8OdyR5UrxvHQPFZNHd9sOC88ZITIVxbmdu+E6aLPr43y +hIsDno4fP6ZAvNjerwDQQwY6Y9Eipo= X-Google-Smtp-Source: ABdhPJzmgju8kLtqMK9vbZukR6yA680YTwi+CYecPgmEhe2wJpBt7xaf9+QjA03ehGAFvSVYJ00D8w== X-Received: by 2002:a05:6000:10f:: with SMTP id o15mr23256702wrx.98.1619439606750; Mon, 26 Apr 2021 05:20:06 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id j7sm4062410wmi.21.2021.04.26.05.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 05:20:05 -0700 (PDT) Date: Mon, 26 Apr 2021 14:20:58 +0200 From: Thierry Reding To: Krzysztof Kozlowski Cc: Jon Hunter , Dmitry Osipenko , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 05/10] memory: tegra: Extract setup code into callback Message-ID: References: <20210420165237.3523732-1-thierry.reding@gmail.com> <20210420165237.3523732-6-thierry.reding@gmail.com> <25ea4721-f9d3-ae4e-6310-73182ad43d8f@canonical.com> MIME-Version: 1.0 In-Reply-To: <25ea4721-f9d3-ae4e-6310-73182ad43d8f@canonical.com> User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_052009_409169_BE17A35B X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3874439313446056397==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3874439313446056397== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RmJ7DJaEJuep+6vi" Content-Disposition: inline --RmJ7DJaEJuep+6vi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 26, 2021 at 10:58:27AM +0200, Krzysztof Kozlowski wrote: > On 20/04/2021 18:52, Thierry Reding wrote: > > From: Thierry Reding > >=20 > > Separate the setup code for Tegra30 and later into a ->setup() callback > > and set it for all applicable chips. >=20 > I assume the code is functionally equivalent - the same > tegra_mc_setup_latency_allowance() will be executed on all these SoCs? Yes, that's what was previously the case and this holds true after the patch. Really the only thing that this patch does is move that code into a separate callback in tegra_mc_ops so that it can be changed for later chips. Thierry --RmJ7DJaEJuep+6vi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmCGsCoACgkQ3SOs138+ s6F7UhAApiDpsLHbeR93j7puRDYR1iR+i+Vp/3pSNod9gTINo8CWny4Nl7dujlUa 9IiKQHze0Aj0rpeppnuZU6DYhGQAiwwDgSB1PDMEymS7mTb6CZfDO+zH2zANPQzp t0L4PO45otYWNTO0kPEMSH92Q7tyEm8slUY2DvzNksv6B3deuWPvVYQZris9qOdy 93oGDoQNIMcctD2Q0t5nw8qqJIjjP9d0nZEhUiDKLga3+k6lJNIIQlI3fXQkhsNb cxPK+dInWTPtVT6CvLoiuvKwx5TRz/owBWY/sZndsm2OL0qBJoa4MR+CTee5K9Ki u43L/qhogHyaV+H/2uywQWiZQUlGvHIhLB/Vk8VxkQrAC1gsH+153uMK5U9eIv0K dzch+hCWxeTCoe1FujdjDLpv6mybGAeuB38bydWOQaKbFDWBVKAFIj01LpVVto+W wV2rFnUJgmWJ6CCDgria9wIgVcwZeootfBKPMcjqH7ilpbuLW5zspmcaTcVU5zMY uVSlrtxLjWMrSlFJBF7weXuFxhCkUkOXhlsVyG4WDRgYw3h12Bkzs6PvUlDZ2Gig UJ6N3hLnyO0/OM9I+0PLf9oUcIPzsysCvO24Lq0Ky3nX6hAh3bCAWuWF9AkiIEVq xZ3eqVbTWx1taUWMVHFpvdITaosCHLxqxfQP1tCTLIsrNmCdQqw= =66RF -----END PGP SIGNATURE----- --RmJ7DJaEJuep+6vi-- --===============3874439313446056397== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3874439313446056397==--