From: Andrew Lunn <andrew@lunn.ch>
To: Andreas Roeseler <andreas.a.roeseler@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org
Subject: Re: [PATCH net-next] icmp: standardize naming of RFC 8335 PROBE constants
Date: Tue, 27 Apr 2021 14:28:44 +0200 [thread overview]
Message-ID: <YIgDfGZrSqQXjy54@lunn.ch> (raw)
In-Reply-To: <c522ffcadf479c3f1a46c401e38ad01bf3f3331c.camel@gmail.com>
> > You can't just remove the old constants. They have to stay there.
> > The #defines are part of the Linux API by now.
>
> Even in the case where these constants were added less than a month ago
> (3/30/2021) and are not used elsewhere in the kernel? I agree with your
> statement in the general sense, but I thought I could get ahead of it
> in this case and update them.
>
> For reference, they were added in commit
> 2b246b2569cd2ac6ff700d0dce56b8bae29b1842
You need to make this very clear in the commit message, that the code
you are changing is currently only in net-next, no released Kernels
are using these symbols, and you are not break the API.
Andrew
prev parent reply other threads:[~2021-04-27 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 3:40 [PATCH net-next] icmp: standardize naming of RFC 8335 PROBE constants Andreas Roeseler
2021-04-27 3:54 ` Stephen Hemminger
2021-04-27 4:03 ` Andreas Roeseler
2021-04-27 12:28 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIgDfGZrSqQXjy54@lunn.ch \
--to=andrew@lunn.ch \
--cc=andreas.a.roeseler@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.