From: Jiri Olsa <jolsa@redhat.com>
To: Michael Petlan <mpetlan@redhat.com>
Cc: acme@redhat.com, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: enable libtraceevent dynamic linking
Date: Wed, 28 Apr 2021 18:29:59 +0200 [thread overview]
Message-ID: <YImNh9SFs+Vr2EFc@krava> (raw)
In-Reply-To: <20210428092023.4009-1-mpetlan@redhat.com>
On Wed, Apr 28, 2021 at 11:20:23AM +0200, Michael Petlan wrote:
SNIP
> unexport LC_ALL
> @@ -309,7 +311,6 @@ endif
>
> LIBTRACEEVENT = $(TE_PATH)libtraceevent.a
> export LIBTRACEEVENT
> -
> LIBTRACEEVENT_DYNAMIC_LIST = $(PLUGINS_PATH)libtraceevent-dynamic-list
>
> #
> @@ -374,12 +375,15 @@ endif
>
> export PERL_PATH
>
> -PERFLIBS = $(LIBAPI) $(LIBTRACEEVENT) $(LIBSUBCMD) $(LIBPERF)
> +PERFLIBS = $(LIBAPI) $(LIBSUBCMD) $(LIBPERF)
> ifndef NO_LIBBPF
> ifndef LIBBPF_DYNAMIC
> PERFLIBS += $(LIBBPF)
> endif
> endif
> +ifndef LIBTRACEEVENT_DYNAMIC
> + PERFLIBS += $(LIBTRACEEVENT)
> +endif
there's also install-traceevent-plugins target called during install,
which should be skipped for LIBTRACEEVENT_DYNAMIC
jirka
>
> # We choose to avoid "if .. else if .. else .. endif endif"
> # because maintaining the nesting to match is a pain. If
> --
> 2.18.4
>
next prev parent reply other threads:[~2021-04-28 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 9:20 [PATCH] perf: enable libtraceevent dynamic linking Michael Petlan
2021-04-28 16:29 ` Jiri Olsa [this message]
2021-04-30 12:59 ` Michael Petlan
2021-04-30 13:28 ` Arnaldo Carvalho de Melo
2021-04-30 13:53 ` Michael Petlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YImNh9SFs+Vr2EFc@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mpetlan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.