From: Jarkko Sakkinen <jarkko@kernel.org>
To: "tiantao (H)" <tiantao6@huawei.com>
Cc: Tian Tao <tiantao6@hisilicon.com>,
peterhuewe@gmx.de, linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm_crb: Use IOMEM_ERR_PTR when function returns iomem
Date: Thu, 29 Apr 2021 09:48:36 +0300 [thread overview]
Message-ID: <YIpWxEqwQwOuDt5q@kernel.org> (raw)
In-Reply-To: <9bdc99ef-7407-5ae7-a412-18e695ca8c2d@huawei.com>
On Wed, Apr 28, 2021 at 04:43:46PM +0800, tiantao (H) wrote:
>
> 在 2021/4/28 7:44, Jarkko Sakkinen 写道:
> > On Tue, Apr 20, 2021 at 11:10:45AM +0800, Tian Tao wrote:
> > > Function returns 'void __iomem *' so use IOMEM_ERR_PTR for returning
> > > an error.
> > You should also tell why we want to to use IOMEM_ERR_PTR in the
> > description. If it makes sense, then you should know why it makes
> > sense.
>
> thank for review the code ,I'll send a v2 to update the commit message.
>
> This is to simplify the code, the definition of IOMEM_ERR_PTR is in
> include/linux/io.h
>
> #define IOMEM_ERR_PTR(err) (__force void __iomem *)ERR_PTR(err)
>
> I'll send it to v2 and put the above sentence in the commit messge, what do
> you think?
I don't pre-ack patches.
/Jarkko
prev parent reply other threads:[~2021-04-29 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 3:10 [PATCH] tpm_crb: Use IOMEM_ERR_PTR when function returns iomem Tian Tao
2021-04-27 23:44 ` Jarkko Sakkinen
2021-04-28 8:43 ` tiantao (H)
2021-04-29 6:48 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIpWxEqwQwOuDt5q@kernel.org \
--to=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tiantao6@hisilicon.com \
--cc=tiantao6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.