From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk
Date: Thu, 29 Apr 2021 08:52:49 +0200 [thread overview]
Message-ID: <YIpXwaKFw2e/vARq@pevik> (raw)
In-Reply-To: <20210429020922.24085-1-zhaogongyi@huawei.com>
Hi,
> We need replace tst_res with tst_brk to terminate the test immediately since
> there is no sence to go on.
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> v2->v3: split into two separate commits
> testcases/commands/lsmod/lsmod01.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/commands/lsmod/lsmod01.sh b/testcases/commands/lsmod/lsmod01.sh
> index 2e044c718..4ed91eca5 100755
> --- a/testcases/commands/lsmod/lsmod01.sh
> +++ b/testcases/commands/lsmod/lsmod01.sh
> @@ -23,7 +23,7 @@ setup()
> tst_require_cmds insmod
> insmod "$TST_MODPATH"
> if [ $? -ne 0 ]; then
> - tst_res TBROK "insmod failed"
> + tst_brk TBROK "insmod failed"
> return
There does not need to be return (in cleanup function tst_brk just prints
warning and continues, but elsewhere it just quits).
I'll fix that during merge.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
next prev parent reply other threads:[~2021-04-29 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 2:09 [LTP] [PATCH v3] commands/lsmod01.sh: Replace tst_res with tst_brk Zhao Gongyi
2021-04-29 6:52 ` Petr Vorel [this message]
2021-04-29 17:12 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIpXwaKFw2e/vARq@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.