From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A6FC433B4 for ; Thu, 29 Apr 2021 06:58:10 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 3FAA46144E for ; Thu, 29 Apr 2021 06:58:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FAA46144E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BFB344B31B; Thu, 29 Apr 2021 02:58:09 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zqf3U0or4aIh; Thu, 29 Apr 2021 02:58:08 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1EE564B316; Thu, 29 Apr 2021 02:58:08 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4C3DA4B316 for ; Thu, 29 Apr 2021 02:58:06 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZDFrQSVqD057 for ; Thu, 29 Apr 2021 02:58:05 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 30BC24B315 for ; Thu, 29 Apr 2021 02:58:05 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id BAD7A6144B; Thu, 29 Apr 2021 06:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619679483; bh=l1YNoSMCv4WqRE2vuNJAwrTs3h6UQBEivHBC6/hQdn4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aO7gxyhOVkLEx+raw89h1VPcYXGHTfGyqvHsdHo+ICI31y241io5QGGPJR12RCD/p 8AV8o5ax3nhSce+p3MiYHZSHqQ3/x1PJX8BN+6vIYtKheOallgAVi/YfSh3X7TEeB6 hjyaQyhwr1wfIx38apMX8lqS4GMc67eRdUkGB7x35fhWcDz6Fqm+yi56m8gChW4baP JKP9TA+UXsJKV0urjwKkeiV01FoQLOC2yqnzM0MqCY6C8bKYb1LBHxDpS0R9BsOMdw QP6NufksB+r1kxa/ucqzUL74NkyIi/gXA3Je3MbkdY2i2jyKJ9umoNjuWeNLy8ChHy yO1oOEtaPufSA== Date: Thu, 29 Apr 2021 09:57:53 +0300 From: Mike Rapoport To: Kefeng Wang Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) Message-ID: References: <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> <2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com> <52f7d03b-7219-46bc-c62d-b976bc31ebd5@huawei.com> <2d879629-3059-fd42-428f-4b7c2a73d698@huawei.com> <259d14df-a713-72e7-4ccb-c06a8ee31e13@huawei.com> <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> Cc: David Hildenbrand , Catalin Marinas , Anshuman Khandual , linux-kernel@vger.kernel.org, Mike Rapoport , linux-mm@kvack.org, kvmarm@lists.cs.columbia.edu, Marc Zyngier , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gVGh1LCBBcHIgMjksIDIwMjEgYXQgMDg6NDg6MjZBTSArMDgwMCwgS2VmZW5nIFdhbmcgd3Jv dGU6Cj4gCj4gT24gMjAyMS80LzI4IDEzOjU5LCBNaWtlIFJhcG9wb3J0IHdyb3RlOgo+ID4gT24g VHVlLCBBcHIgMjcsIDIwMjEgYXQgMDc6MDg6NTlQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3JvdGU6 Cj4gPiA+IE9uIDIwMjEvNC8yNyAxNDoyMywgTWlrZSBSYXBvcG9ydCB3cm90ZToKPiA+ID4gPiBP biBNb24sIEFwciAyNiwgMjAyMSBhdCAxMToyNjozOFBNICswODAwLCBLZWZlbmcgV2FuZyB3cm90 ZToKPiA+ID4gPiA+IE9uIDIwMjEvNC8yNiAxMzoyMCwgTWlrZSBSYXBvcG9ydCB3cm90ZToKPiA+ ID4gPiA+ID4gT24gU3VuLCBBcHIgMjUsIDIwMjEgYXQgMDM6NTE6NTZQTSArMDgwMCwgS2VmZW5n IFdhbmcgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gT24gMjAyMS80LzI1IDE1OjE5LCBNaWtlIFJhcG9w b3J0IHdyb3RlOgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ICAgICAgICBPbiBGcmksIEFw ciAyMywgMjAyMSBhdCAwNDoxMToxNlBNICswODAwLCBLZWZlbmcgV2FuZyB3cm90ZToKPiA+ID4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gPiAgICAgICAgICAgIEkgdGVzdGVkIHRoaXMgcGF0Y2hzZXQo cGx1cyBhcm0zMiBjaGFuZ2UsIGxpa2UgYXJtNjQgZG9lcykKPiA+ID4gPiA+ID4gPiAgICAgICAg ICAgIGJhc2VkIG9uIGx0cyA1LjEw77yMYWRkIHNvbWUgZGVidWcgbG9nLCB0aGUgdXNlZnVsIGlu Zm8gc2hvd3MKPiA+ID4gPiA+ID4gPiAgICAgICAgICAgIGJlbG93LCBpZiB3ZSBlbmFibGUgSE9M RVNfSU5fWk9ORSwgbm8gcGFuaWMsIGFueSBpZGVhLAo+ID4gPiA+ID4gPiA+ICAgICAgICAgICAg dGhhbmtzLgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ICAgICAgICBBcmUgdGhlcmUgYW55 IGNoYW5nZXMgb24gdG9wIG9mIDUuMTAgZXhjZXB0IGZvciBwZm5fdmFsaWQoKSBwYXRjaD8KPiA+ ID4gPiA+ID4gPiAgICAgICAgRG8geW91IHNlZSB0aGlzIHBhbmljIG9uIDUuMTAgd2l0aG91dCB0 aGUgY2hhbmdlcz8KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBZZXMsIHRoZXJlIGFyZSBz b21lIEJTUCBzdXBwb3J0IGZvciBhcm0gYm9hcmQgYmFzZWQgb24gNS4xMCwKPiA+ID4gPiBJcyBp dCBwb3NzaWJsZSB0byB0ZXN0IDUuMTI/Cj4gPiBEbyB5b3UgdXNlIFNQQVJTTUVNPyBJZiB5ZXMs IHdoYXQgaXMgeW91ciBzZWN0aW9uIHNpemU/Cj4gPiBXaGF0IGlzIHRoZSB2YWx1ZSBpZiBDT05G SUdfRk9SQ0VfTUFYX1pPTkVPUkRFUiBpbiB5b3VyIGNvbmZpZ3VyYXRpb24/Cj4gCj4gWWVzLAo+ IAo+IENPTkZJR19TUEFSU0VNRU09eQo+IAo+IENPTkZJR19TUEFSU0VNRU1fU1RBVElDPXkKPiAK PiBDT05GSUdfRk9SQ0VfTUFYX1pPTkVPUkRFUiA9IDExCj4gCj4gQ09ORklHX1BBR0VfT0ZGU0VU PTB4QzAwMDAwMDAKPiBDT05GSUdfSEFWRV9BUkNIX1BGTl9WQUxJRD15Cj4gQ09ORklHX0hJR0hN RU09eQo+ICNkZWZpbmUgU0VDVElPTl9TSVpFX0JJVFMgICAgMjYKPiAjZGVmaW5lIE1BWF9QSFlT QUREUl9CSVRTICAgIDMyCj4gI2RlZmluZSBNQVhfUEhZU01FTV9CSVRTICAgICAzMgoKSXQgc2Vl bXMgdGhhdCB3aXRoIFNQQVJTRU1FTSB3ZSBkb24ndCBhbGlnbiB0aGUgZnJlZWQgcGFydHMgb24g cGFnZWJsb2NrCmJvdW5kYXJpZXMuCgpDYW4geW91IHRyeSB0aGUgcGF0Y2ggYmVsb3c6CgpkaWZm IC0tZ2l0IGEvbW0vbWVtYmxvY2suYyBiL21tL21lbWJsb2NrLmMKaW5kZXggYWZhZWZhOGZjNmFi Li4xOTI2MzY5YjUyZWMgMTAwNjQ0Ci0tLSBhL21tL21lbWJsb2NrLmMKKysrIGIvbW0vbWVtYmxv Y2suYwpAQCAtMTk0MSwxNCArMTk0MSwxMyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgZnJlZV91bnVz ZWRfbWVtbWFwKHZvaWQpCiAJCSAqIGR1ZSB0byBTUEFSU0VNRU0gc2VjdGlvbnMgd2hpY2ggYXJl bid0IHByZXNlbnQuCiAJCSAqLwogCQlzdGFydCA9IG1pbihzdGFydCwgQUxJR04ocHJldl9lbmQs IFBBR0VTX1BFUl9TRUNUSU9OKSk7Ci0jZWxzZQorI2VuZGlmCiAJCS8qCiAJCSAqIEFsaWduIGRv d24gaGVyZSBzaW5jZSB0aGUgVk0gc3Vic3lzdGVtIGluc2lzdHMgdGhhdCB0aGUKIAkJICogbWVt bWFwIGVudHJpZXMgYXJlIHZhbGlkIGZyb20gdGhlIGJhbmsgc3RhcnQgYWxpZ25lZCB0bwogCQkg KiBNQVhfT1JERVJfTlJfUEFHRVMuCiAJCSAqLwogCQlzdGFydCA9IHJvdW5kX2Rvd24oc3RhcnQs IE1BWF9PUkRFUl9OUl9QQUdFUyk7Ci0jZW5kaWYKIAogCQkvKgogCQkgKiBJZiB3ZSBoYWQgYSBw cmV2aW91cyBiYW5rLCBhbmQgdGhlcmUgaXMgYSBzcGFjZQogCgotLSAKU2luY2VyZWx5IHlvdXJz LApNaWtlLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpr dm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6Ly9s aXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F33C433B4 for ; Thu, 29 Apr 2021 06:59:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3099B61449 for ; Thu, 29 Apr 2021 06:59:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3099B61449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YwNAesakDMZt3jL7mw8vn71Z40ad2iPrmpbpy7Wu5h0=; b=dF+YciFtCoqDSaAddjGg9Y4rG aGXA+LlANtBiQXLP3MNAJAKNd5uxaGOB4mScrdxbmmtsHZ8xwTGens5YkG/VOuqLo5ZDMDn81F6be ApShsv8w1dqrjTqGd1ZuRFJHUZXTWkvnXIPWNoyyfVKnYEAdr3FobWp+MEyXWsspmQ6v7T0zWS9S+ fRArnG56BUZWeOViQfzchOmPvyq4nK7jtXIZZWEUL3hDvlD5+NI6D12zDVspdApgNlj8GkPfUacHf 4tNQHbY7SN4dMBOkERe+/ZxOyr0HeLKesr1IEOMg4O8vCU/FkiyfQpb84mY7GtMsOW2x+oajpJuTH 16DnGLNwQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc0ck-0057KU-6k; Thu, 29 Apr 2021 06:58:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0ci-0057KM-2V for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 06:58:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=0o5fNcpmWxgaRFDBnwbg0r92wHA/SD5YD+JFtcgmsRM=; b=FMl3T+GHNHcoREdFkm/pFTDuml GL/4DRe6ZinmhAzGHVkjvXGFJT6lJQ2mvy3T/PwvASM7Gj+RNEMLGR6MTSCPEqIIt/MoLxNHjFg+W 3hU6UXPkk6KuygLVXRarr7Uij7h2YvirGyo3DGNT23nAFGc3V6+Xxi/jibJ8Y1LHam+nL2TMjno6K nOPg6nyASBGevK7/D5G+tzcPxdQ/BtG7L59s5f7frdRbO5fqYwoCj6IaqnnH2bYLpzUHl/SmqBShp J9kKKWypghSs6IebpsjQdO6Gt3esApqc3avgxPS2mxStqzMckjN1eipZLgV2owjtRFazVtO6VhoWu 66gu70Jw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc0cf-000QER-Dm for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 06:58:06 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BAD7A6144B; Thu, 29 Apr 2021 06:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619679483; bh=l1YNoSMCv4WqRE2vuNJAwrTs3h6UQBEivHBC6/hQdn4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aO7gxyhOVkLEx+raw89h1VPcYXGHTfGyqvHsdHo+ICI31y241io5QGGPJR12RCD/p 8AV8o5ax3nhSce+p3MiYHZSHqQ3/x1PJX8BN+6vIYtKheOallgAVi/YfSh3X7TEeB6 hjyaQyhwr1wfIx38apMX8lqS4GMc67eRdUkGB7x35fhWcDz6Fqm+yi56m8gChW4baP JKP9TA+UXsJKV0urjwKkeiV01FoQLOC2yqnzM0MqCY6C8bKYb1LBHxDpS0R9BsOMdw QP6NufksB+r1kxa/ucqzUL74NkyIi/gXA3Je3MbkdY2i2jyKJ9umoNjuWeNLy8ChHy yO1oOEtaPufSA== Date: Thu, 29 Apr 2021 09:57:53 +0300 From: Mike Rapoport To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) Message-ID: References: <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> <2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com> <52f7d03b-7219-46bc-c62d-b976bc31ebd5@huawei.com> <2d879629-3059-fd42-428f-4b7c2a73d698@huawei.com> <259d14df-a713-72e7-4ccb-c06a8ee31e13@huawei.com> <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_235805_558771_B599E52C X-CRM114-Status: GOOD ( 24.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBBcHIgMjksIDIwMjEgYXQgMDg6NDg6MjZBTSArMDgwMCwgS2VmZW5nIFdhbmcgd3Jv dGU6Cj4gCj4gT24gMjAyMS80LzI4IDEzOjU5LCBNaWtlIFJhcG9wb3J0IHdyb3RlOgo+ID4gT24g VHVlLCBBcHIgMjcsIDIwMjEgYXQgMDc6MDg6NTlQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3JvdGU6 Cj4gPiA+IE9uIDIwMjEvNC8yNyAxNDoyMywgTWlrZSBSYXBvcG9ydCB3cm90ZToKPiA+ID4gPiBP biBNb24sIEFwciAyNiwgMjAyMSBhdCAxMToyNjozOFBNICswODAwLCBLZWZlbmcgV2FuZyB3cm90 ZToKPiA+ID4gPiA+IE9uIDIwMjEvNC8yNiAxMzoyMCwgTWlrZSBSYXBvcG9ydCB3cm90ZToKPiA+ ID4gPiA+ID4gT24gU3VuLCBBcHIgMjUsIDIwMjEgYXQgMDM6NTE6NTZQTSArMDgwMCwgS2VmZW5n IFdhbmcgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gT24gMjAyMS80LzI1IDE1OjE5LCBNaWtlIFJhcG9w b3J0IHdyb3RlOgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ICAgICAgICBPbiBGcmksIEFw ciAyMywgMjAyMSBhdCAwNDoxMToxNlBNICswODAwLCBLZWZlbmcgV2FuZyB3cm90ZToKPiA+ID4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gPiAgICAgICAgICAgIEkgdGVzdGVkIHRoaXMgcGF0Y2hzZXQo cGx1cyBhcm0zMiBjaGFuZ2UsIGxpa2UgYXJtNjQgZG9lcykKPiA+ID4gPiA+ID4gPiAgICAgICAg ICAgIGJhc2VkIG9uIGx0cyA1LjEw77yMYWRkIHNvbWUgZGVidWcgbG9nLCB0aGUgdXNlZnVsIGlu Zm8gc2hvd3MKPiA+ID4gPiA+ID4gPiAgICAgICAgICAgIGJlbG93LCBpZiB3ZSBlbmFibGUgSE9M RVNfSU5fWk9ORSwgbm8gcGFuaWMsIGFueSBpZGVhLAo+ID4gPiA+ID4gPiA+ICAgICAgICAgICAg dGhhbmtzLgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ICAgICAgICBBcmUgdGhlcmUgYW55 IGNoYW5nZXMgb24gdG9wIG9mIDUuMTAgZXhjZXB0IGZvciBwZm5fdmFsaWQoKSBwYXRjaD8KPiA+ ID4gPiA+ID4gPiAgICAgICAgRG8geW91IHNlZSB0aGlzIHBhbmljIG9uIDUuMTAgd2l0aG91dCB0 aGUgY2hhbmdlcz8KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBZZXMsIHRoZXJlIGFyZSBz b21lIEJTUCBzdXBwb3J0IGZvciBhcm0gYm9hcmQgYmFzZWQgb24gNS4xMCwKPiA+ID4gPiBJcyBp dCBwb3NzaWJsZSB0byB0ZXN0IDUuMTI/Cj4gPiBEbyB5b3UgdXNlIFNQQVJTTUVNPyBJZiB5ZXMs IHdoYXQgaXMgeW91ciBzZWN0aW9uIHNpemU/Cj4gPiBXaGF0IGlzIHRoZSB2YWx1ZSBpZiBDT05G SUdfRk9SQ0VfTUFYX1pPTkVPUkRFUiBpbiB5b3VyIGNvbmZpZ3VyYXRpb24/Cj4gCj4gWWVzLAo+ IAo+IENPTkZJR19TUEFSU0VNRU09eQo+IAo+IENPTkZJR19TUEFSU0VNRU1fU1RBVElDPXkKPiAK PiBDT05GSUdfRk9SQ0VfTUFYX1pPTkVPUkRFUiA9IDExCj4gCj4gQ09ORklHX1BBR0VfT0ZGU0VU PTB4QzAwMDAwMDAKPiBDT05GSUdfSEFWRV9BUkNIX1BGTl9WQUxJRD15Cj4gQ09ORklHX0hJR0hN RU09eQo+ICNkZWZpbmUgU0VDVElPTl9TSVpFX0JJVFMgICAgMjYKPiAjZGVmaW5lIE1BWF9QSFlT QUREUl9CSVRTICAgIDMyCj4gI2RlZmluZSBNQVhfUEhZU01FTV9CSVRTICAgICAzMgoKSXQgc2Vl bXMgdGhhdCB3aXRoIFNQQVJTRU1FTSB3ZSBkb24ndCBhbGlnbiB0aGUgZnJlZWQgcGFydHMgb24g cGFnZWJsb2NrCmJvdW5kYXJpZXMuCgpDYW4geW91IHRyeSB0aGUgcGF0Y2ggYmVsb3c6CgpkaWZm IC0tZ2l0IGEvbW0vbWVtYmxvY2suYyBiL21tL21lbWJsb2NrLmMKaW5kZXggYWZhZWZhOGZjNmFi Li4xOTI2MzY5YjUyZWMgMTAwNjQ0Ci0tLSBhL21tL21lbWJsb2NrLmMKKysrIGIvbW0vbWVtYmxv Y2suYwpAQCAtMTk0MSwxNCArMTk0MSwxMyBAQCBzdGF0aWMgdm9pZCBfX2luaXQgZnJlZV91bnVz ZWRfbWVtbWFwKHZvaWQpCiAJCSAqIGR1ZSB0byBTUEFSU0VNRU0gc2VjdGlvbnMgd2hpY2ggYXJl bid0IHByZXNlbnQuCiAJCSAqLwogCQlzdGFydCA9IG1pbihzdGFydCwgQUxJR04ocHJldl9lbmQs IFBBR0VTX1BFUl9TRUNUSU9OKSk7Ci0jZWxzZQorI2VuZGlmCiAJCS8qCiAJCSAqIEFsaWduIGRv d24gaGVyZSBzaW5jZSB0aGUgVk0gc3Vic3lzdGVtIGluc2lzdHMgdGhhdCB0aGUKIAkJICogbWVt bWFwIGVudHJpZXMgYXJlIHZhbGlkIGZyb20gdGhlIGJhbmsgc3RhcnQgYWxpZ25lZCB0bwogCQkg KiBNQVhfT1JERVJfTlJfUEFHRVMuCiAJCSAqLwogCQlzdGFydCA9IHJvdW5kX2Rvd24oc3RhcnQs IE1BWF9PUkRFUl9OUl9QQUdFUyk7Ci0jZW5kaWYKIAogCQkvKgogCQkgKiBJZiB3ZSBoYWQgYSBw cmV2aW91cyBiYW5rLCBhbmQgdGhlcmUgaXMgYSBzcGFjZQogCgotLSAKU2luY2VyZWx5IHlvdXJz LApNaWtlLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDFDC433ED for ; Thu, 29 Apr 2021 06:58:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACA5D61449 for ; Thu, 29 Apr 2021 06:58:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACA5D61449 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1F8C36B006C; Thu, 29 Apr 2021 02:58:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 183646B006E; Thu, 29 Apr 2021 02:58:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3E466B0070; Thu, 29 Apr 2021 02:58:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id D38F36B006C for ; Thu, 29 Apr 2021 02:58:05 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8BF3A1801C399 for ; Thu, 29 Apr 2021 06:58:05 +0000 (UTC) X-FDA: 78084500130.26.B8E03C1 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id D660EC0007DA for ; Thu, 29 Apr 2021 06:58:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id BAD7A6144B; Thu, 29 Apr 2021 06:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619679483; bh=l1YNoSMCv4WqRE2vuNJAwrTs3h6UQBEivHBC6/hQdn4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aO7gxyhOVkLEx+raw89h1VPcYXGHTfGyqvHsdHo+ICI31y241io5QGGPJR12RCD/p 8AV8o5ax3nhSce+p3MiYHZSHqQ3/x1PJX8BN+6vIYtKheOallgAVi/YfSh3X7TEeB6 hjyaQyhwr1wfIx38apMX8lqS4GMc67eRdUkGB7x35fhWcDz6Fqm+yi56m8gChW4baP JKP9TA+UXsJKV0urjwKkeiV01FoQLOC2yqnzM0MqCY6C8bKYb1LBHxDpS0R9BsOMdw QP6NufksB+r1kxa/ucqzUL74NkyIi/gXA3Je3MbkdY2i2jyKJ9umoNjuWeNLy8ChHy yO1oOEtaPufSA== Date: Thu, 29 Apr 2021 09:57:53 +0300 From: Mike Rapoport To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) Message-ID: References: <33fa74c2-f32d-f224-eb30-acdb717179ff@huawei.com> <2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com> <52f7d03b-7219-46bc-c62d-b976bc31ebd5@huawei.com> <2d879629-3059-fd42-428f-4b7c2a73d698@huawei.com> <259d14df-a713-72e7-4ccb-c06a8ee31e13@huawei.com> <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> X-Stat-Signature: nysgnub1fkxbca53gqq674j51cismspy X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D660EC0007DA Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619679487-982668 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 29, 2021 at 08:48:26AM +0800, Kefeng Wang wrote: >=20 > On 2021/4/28 13:59, Mike Rapoport wrote: > > On Tue, Apr 27, 2021 at 07:08:59PM +0800, Kefeng Wang wrote: > > > On 2021/4/27 14:23, Mike Rapoport wrote: > > > > On Mon, Apr 26, 2021 at 11:26:38PM +0800, Kefeng Wang wrote: > > > > > On 2021/4/26 13:20, Mike Rapoport wrote: > > > > > > On Sun, Apr 25, 2021 at 03:51:56PM +0800, Kefeng Wang wrote: > > > > > > > On 2021/4/25 15:19, Mike Rapoport wrote: > > > > > > >=20 > > > > > > > On Fri, Apr 23, 2021 at 04:11:16PM +0800, Kefeng Wan= g wrote: > > > > > > >=20 > > > > > > > I tested this patchset(plus arm32 change, like a= rm64 does) > > > > > > > based on lts 5.10=EF=BC=8Cadd some debug log, th= e useful info shows > > > > > > > below, if we enable HOLES_IN_ZONE, no panic, any= idea, > > > > > > > thanks. > > > > > > >=20 > > > > > > > Are there any changes on top of 5.10 except for pfn_= valid() patch? > > > > > > > Do you see this panic on 5.10 without the changes? > > > > > > >=20 > > > > > > > Yes, there are some BSP support for arm board based on 5.10= , > > > > Is it possible to test 5.12? > > Do you use SPARSMEM? If yes, what is your section size? > > What is the value if CONFIG_FORCE_MAX_ZONEORDER in your configuration= ? >=20 > Yes, >=20 > CONFIG_SPARSEMEM=3Dy >=20 > CONFIG_SPARSEMEM_STATIC=3Dy >=20 > CONFIG_FORCE_MAX_ZONEORDER =3D 11 >=20 > CONFIG_PAGE_OFFSET=3D0xC0000000 > CONFIG_HAVE_ARCH_PFN_VALID=3Dy > CONFIG_HIGHMEM=3Dy > #define SECTION_SIZE_BITS 26 > #define MAX_PHYSADDR_BITS 32 > #define MAX_PHYSMEM_BITS 32 It seems that with SPARSEMEM we don't align the freed parts on pageblock boundaries. Can you try the patch below: diff --git a/mm/memblock.c b/mm/memblock.c index afaefa8fc6ab..1926369b52ec 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1941,14 +1941,13 @@ static void __init free_unused_memmap(void) * due to SPARSEMEM sections which aren't present. */ start =3D min(start, ALIGN(prev_end, PAGES_PER_SECTION)); -#else +#endif /* * Align down here since the VM subsystem insists that the * memmap entries are valid from the bank start aligned to * MAX_ORDER_NR_PAGES. */ start =3D round_down(start, MAX_ORDER_NR_PAGES); -#endif =20 /* * If we had a previous bank, and there is a space =20 --=20 Sincerely yours, Mike.