From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces
Date: Thu, 29 Apr 2021 18:37:41 +0300 [thread overview]
Message-ID: <YIrSxTrhAao9YPNc@intel.com> (raw)
In-Reply-To: <87r1it33yq.fsf@intel.com>
On Thu, Apr 29, 2021 at 11:11:25AM +0300, Jani Nikula wrote:
> On Thu, 29 Apr 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We lost the i915_reg_rw tracepoint for a lot of display registers
> > when we switched from the heavyweight normal register accessors to
> > the lightweight _fw() variants.
>
> Sorry, which change was that exactly?
commit dd584fc0711a ("drm/i915: Use I915_READ_FW for plane updates")
and probably a few others like it.
>
> > Put the tracepoints back so that
> > the register traces might actually be useful. Hopefully these should
> > be close to free when the tracepoint is not enabled and thus not
> > slow down our vblank critical sections significantly.
> >
> > The biggest hurdle is untangling the include order. Fortunately just
> > pulling intel_de.h out from intel_display_types.h seems to have been
> > sufficient to make it build.
>
> This is something I've been meaning to fix independently. Thanks.
Hmm. Maybe I should split this into two commits...
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Ta.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-29 15:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 2:35 [Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces Ville Syrjala
2021-04-29 3:24 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2021-04-29 7:34 ` [Intel-gfx] [PATCH] " Gupta, Anshuman
2021-04-29 15:59 ` Ville Syrjälä
2021-04-29 8:11 ` Jani Nikula
2021-04-29 15:37 ` Ville Syrjälä [this message]
2021-04-29 17:49 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIrSxTrhAao9YPNc@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=cooper.chiou@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.