From: Dan Carpenter <dan.carpenter@oracle.com>
To: parav@nvidia.com
Cc: linux-rdma@vger.kernel.org
Subject: [bug report] net/mlx5: E-Switch, Consider SF ports of host PF
Date: Fri, 30 Apr 2021 09:02:05 +0300 [thread overview]
Message-ID: <YIudXfl7K83HgIzM@mwanda> (raw)
Hello Parav Pandit,
The patch 87bd418ea751: "net/mlx5: E-Switch, Consider SF ports of
host PF" from Mar 2, 2021, leads to the following static checker
warning:
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c:1571 mlx5_query_hca_cap_host_pf()
warn: odd binop '0x0 & 0x1'
drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
1569 static int mlx5_query_hca_cap_host_pf(struct mlx5_core_dev *dev, void *out)
1570 {
1571 u16 opmod = (MLX5_CAP_GENERAL << 1) | (HCA_CAP_OPMOD_GET_MAX & 0x01);
^^^^^^^^^^^^^^^^^^^^^
HCA_CAP_OPMOD_GET_MAX is zero.
1572 u8 in[MLX5_ST_SZ_BYTES(query_hca_cap_in)] = {};
1573
1574 MLX5_SET(query_hca_cap_in, in, opcode, MLX5_CMD_OP_QUERY_HCA_CAP);
1575 MLX5_SET(query_hca_cap_in, in, op_mod, opmod);
1576 MLX5_SET(query_hca_cap_in, in, function_id, MLX5_VPORT_PF);
1577 MLX5_SET(query_hca_cap_in, in, other_function, true);
1578 return mlx5_cmd_exec_inout(dev, query_hca_cap, in, out);
1579 }
regards,
dan carpenter
reply other threads:[~2021-04-30 6:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIudXfl7K83HgIzM@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.