From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B89BC433ED for ; Fri, 30 Apr 2021 15:28:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB6AE61139 for ; Fri, 30 Apr 2021 15:28:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB6AE61139 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23F0A6F54B; Fri, 30 Apr 2021 15:28:21 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CBBB6F54B for ; Fri, 30 Apr 2021 15:28:19 +0000 (UTC) IronPort-SDR: M0HuxesnKkktSnCgiPMt20PAkaQAUATCdhN6vY9Koq0JEiqIeflGKc2gHrORX2F6RShApLZidD Vx9D3BqbA5Ag== X-IronPort-AV: E=McAfee;i="6200,9189,9970"; a="177457858" X-IronPort-AV: E=Sophos;i="5.82,263,1613462400"; d="scan'208";a="177457858" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 08:28:19 -0700 IronPort-SDR: tzvZIJHaQKm0nng8w5SSUZHN8det0RhqTfhIKAzz7SokX/lfNpphrgmb2l51GwdqwImA6NMn1d lQ241eMOk1sQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,263,1613462400"; d="scan'208";a="394412862" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 30 Apr 2021 08:28:16 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 30 Apr 2021 18:28:15 +0300 Date: Fri, 30 Apr 2021 18:28:15 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Simon Ser Subject: Re: [PATCH] drm: log errors in drm_gem_fb_init_with_funcs Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Sam Ravnborg , dri-devel@lists.freedesktop.org, Andrzej Pietrasiewicz Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Apr 30, 2021 at 02:40:02PM +0000, Simon Ser wrote: > Let the user know what went wrong in drm_gem_fb_init_with_funcs > failure paths. > = > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Sam Ravnborg > Cc: Noralf Tr=F8nnes > Cc: Andrzej Pietrasiewicz > --- > drivers/gpu/drm/drm_gem_framebuffer_helper.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/drm_gem_framebuffer_helper.c b/drivers/gpu/d= rm/drm_gem_framebuffer_helper.c > index 109d11fb4cd4..e4a3c7eb43b2 100644 > --- a/drivers/gpu/drm/drm_gem_framebuffer_helper.c > +++ b/drivers/gpu/drm/drm_gem_framebuffer_helper.c > @@ -155,8 +155,10 @@ int drm_gem_fb_init_with_funcs(struct drm_device *de= v, > int ret, i; > = > info =3D drm_get_format_info(dev, mode_cmd); > - if (!info) > + if (!info) { > + drm_dbg_kms(dev, "Failed to get FB format info\n"); > return -EINVAL; > + } Assuming this thing gets plugged into .fb_create() getting this far with a bogus format would be rather suprising. > = > for (i =3D 0; i < info->num_planes; i++) { > unsigned int width =3D mode_cmd->width / (i ? info->hsub : 1); > @@ -175,6 +177,9 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev, > + mode_cmd->offsets[i]; > = > if (objs[i]->size < min_size) { > + drm_dbg_kms(dev, > + "GEM object size (%u) smaller than minimum size (%u) for plane %= d\n", > + objs[i]->size, min_size, i); > drm_gem_object_put(objs[i]); > ret =3D -EINVAL; > goto err_gem_object_put; > -- = > 2.31.1 > = > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel