All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/unshare02: Fix failures on Debian
Date: Fri, 14 May 2021 11:12:11 +0200	[thread overview]
Message-ID: <YJ4+6+QJPF2XmYio@pevik> (raw)
In-Reply-To: <20210514080708.20036-1-chrubis@suse.cz>

Hi Cyril,

> The order of checks in kernel is not defined and on Debian we end up
> getting eperm even before the flags are checked which fails the invalid
> flags testcase.

> The fix is simple, we change the test to setuid() only for the EPERM
> test.

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>

Thanks!

Kind regards,
Petr


  reply	other threads:[~2021-05-14  9:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  8:07 [LTP] [PATCH] syscalls/unshare02: Fix failures on Debian Cyril Hrubis
2021-05-14  9:12 ` Petr Vorel [this message]
2021-05-17  8:34   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ4+6+QJPF2XmYio@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.