From: Jarkko Sakkinen <jarkko@kernel.org>
To: trix@redhat.com
Cc: jejb@linux.ibm.com, zohar@linux.ibm.com, dhowells@redhat.com,
jmorris@namei.org, serge@hallyn.com,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KEYS: trusted: fix memory leak
Date: Mon, 3 May 2021 17:56:12 +0300 [thread overview]
Message-ID: <YJAPDLo/FPIbdJR9@kernel.org> (raw)
In-Reply-To: <20210430185810.3331311-1-trix@redhat.com>
On Fri, Apr 30, 2021 at 11:58:10AM -0700, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> Static analysis reports this problem
> trusted-keys/trusted_tpm1.c:496:10: warning: Potential memory leak
> return ret;
> ^~~
>
> In tpm_seal() some failure handling returns directly, without
> freeing memory.
>
> Fixes: 5df16caada3f ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
> Signed-off-by: Tom Rix <trix@redhat.com>
Hi, thanks appreciate this but unfortunately applied Colin's fix already
:-/
/Jarkko
prev parent reply other threads:[~2021-05-03 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 18:58 [PATCH] KEYS: trusted: fix memory leak trix
2021-04-30 19:50 ` Ben Boeckel
2021-04-30 23:08 ` Tom Rix
2021-05-03 14:56 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJAPDLo/FPIbdJR9@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=trix@redhat.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.