From: Jarkko Sakkinen <jarkko@kernel.org>
To: Tim Gardner <tim.gardner@canonical.com>
Cc: dave.hansen@linux.intel.com, shuah@kernel.org,
linux-sgx@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Subject: [PATCH 0/1] SGX self test fails
Date: Mon, 3 May 2021 18:38:07 +0300 [thread overview]
Message-ID: <YJAY345r2GZ0X9bP@kernel.org> (raw)
In-Reply-To: <20210429183952.22797-1-tim.gardner@canonical.com>
On Thu, Apr 29, 2021 at 12:39:51PM -0600, Tim Gardner wrote:
> I'm just starting my learning curve on SGX, so I don't know if I've missed
> some setup for the SGX device entries. After looking at arch/x86/kernel/cpu/sgx/driver.c
> I see that there is no mode value for either sgx_dev_enclave or sgx_dev_provision.
Take a look at
https://github.com/systemd/systemd/pull/18944
> With this patch I can get the SGX self test to complete:
>
> sudo ./test_sgx
> Warning: no execute permissions on device file /dev/sgx_enclave
> 0x0000000000000000 0x0000000000002000 0x03
> 0x0000000000002000 0x0000000000001000 0x05
> 0x0000000000003000 0x0000000000003000 0x03
> SUCCESS
>
> Is the warning even necessary ?
>
> Tim
With a quick look, I think that check is too strict. AFAIK, mmap(PROT_EXEC)
can be done, as long as the file is not in a noexec FS.
Dave?
For reference:
https://lore.kernel.org/linux-sgx/20210318194301.11D9A984@viggo.jf.intel.com/
/Jarkko
prev parent reply other threads:[~2021-05-03 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 18:39 Subject: [PATCH 0/1] SGX self test fails Tim Gardner
2021-04-29 18:39 ` [PATCH] selftests/sgx: Defeat execute permissions test Tim Gardner
2021-04-29 18:55 ` Subject: [PATCH 0/1] SGX self test fails Dave Hansen
2021-04-30 9:25 ` Dr. Greg
2021-05-03 15:41 ` Jarkko Sakkinen
2021-05-03 16:39 ` Dave Hansen
2021-05-03 22:37 ` Jarkko Sakkinen
2021-05-03 15:38 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJAY345r2GZ0X9bP@kernel.org \
--to=jarkko@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.