All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: wangyunjian <wangyunjian@huawei.com>
Cc: kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com,
	netdev@vger.kernel.org, dingxiaoxiong@huawei.com
Subject: Re: [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps
Date: Tue, 4 May 2021 10:27:13 +0300	[thread overview]
Message-ID: <YJD3UQXFJfow86kl@unreal> (raw)
In-Reply-To: <1618902026-16588-1-git-send-email-wangyunjian@huawei.com>

On Tue, Apr 20, 2021 at 03:00:26PM +0800, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> The 'comps' struct field in 'moder' is not being initialized in
> mlx5e_get_def_rx_moderation() and mlx5e_get_def_tx_moderation().
> So initialize 'moder' to zero to avoid the issue.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v2: update mlx5e_get_def_tx_moderation() also needs fixing

Actually grep other all "struct dim_cq_moder ...;" declarations shows
many places like this. Are you going to change them too?

Thanks

      parent reply	other threads:[~2021-05-04  7:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  7:00 [PATCH net-next v2] net/mlx5e: Fix uninitialised struct field moder.comps wangyunjian
2021-04-20  7:09 ` Zhu Yanjun
2021-04-20  9:21   ` Leon Romanovsky
2021-04-20  9:28     ` Zhu Yanjun
2021-04-20 11:05       ` Leon Romanovsky
2021-05-04  7:27 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJD3UQXFJfow86kl@unreal \
    --to=leon@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dingxiaoxiong@huawei.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=wangyunjian@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.