From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 527A2C43460 for ; Tue, 4 May 2021 17:44:47 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id BE37C613CB for ; Tue, 4 May 2021 17:44:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE37C613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4973D4B2D1; Tue, 4 May 2021 13:44:46 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KZVt7lMV5SDC; Tue, 4 May 2021 13:44:45 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3DB3A4B328; Tue, 4 May 2021 13:44:45 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9878B4B2D1 for ; Tue, 4 May 2021 13:44:44 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xqJ-9yrAmhPR for ; Tue, 4 May 2021 13:44:43 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 927E44B314 for ; Tue, 4 May 2021 13:44:43 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9249C61166; Tue, 4 May 2021 17:44:39 +0000 (UTC) Date: Tue, 4 May 2021 18:44:37 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v11 5/6] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: References: <20210416154309.22129-1-steven.price@arm.com> <20210416154309.22129-6-steven.price@arm.com> <20210427175844.GB17872@arm.com> <340d35c2-46ed-35ea-43fa-e5cb64c27230@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <340d35c2-46ed-35ea-43fa-e5cb64c27230@arm.com> Cc: "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, Apr 29, 2021 at 05:06:07PM +0100, Steven Price wrote: > On 27/04/2021 18:58, Catalin Marinas wrote: > > On Fri, Apr 16, 2021 at 04:43:08PM +0100, Steven Price wrote: > > > diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > > > index 24223adae150..2b85a047c37d 100644 > > > --- a/arch/arm64/include/uapi/asm/kvm.h > > > +++ b/arch/arm64/include/uapi/asm/kvm.h > > > @@ -184,6 +184,20 @@ struct kvm_vcpu_events { > > > __u32 reserved[12]; > > > }; > > > +struct kvm_arm_copy_mte_tags { > > > + __u64 guest_ipa; > > > + __u64 length; > > > + union { > > > + void __user *addr; > > > + __u64 padding; > > > + }; > > > + __u64 flags; > > > + __u64 reserved[2]; > > > +}; [...] > > Maybe add the two reserved > > values to the union in case we want to store something else in the > > future. > > I'm not sure what you mean here. What would the reserved fields be unioned > with? And surely they are no longer reserved in that case? In case you want to keep the structure size the same for future expansion and the expansion only happens via the union, you'd add some padding in there just in case. We do this for struct siginfo with an _si_pad[] array in the union. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53593C433B4 for ; Tue, 4 May 2021 17:46:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12550613C6 for ; Tue, 4 May 2021 17:46:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12550613C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TV4puDmMQP7ymcBdWrh1TJ/7hFOlPjICvRVZxRcc/UE=; b=q/W8lxHtpJZkWh1SOQcV2Fbvp 8KLBCpDEFAK71QoBFosH6xI+Lg7MJgg4ckiE8RPH/2S5oRwPwEQDf8psVvVHOcSsXvKx0bBhozxKQ y10vRAFjeYJn0s86pMIma3EiQw6PpJ59tCz4vRZaumtGM65cJmzHRAz0gM3T8glYhR0YjwEf81PY7 H47yFZaF1KumiR4Gw4JZIyCLnUqqYszZmDt9RtT6T6yKxujxZR8DNR4/M/u78YQqv8rZDj+CT5jAO WJuOoS24MpPrNaXnpPWE4oJtIlUu7k8da4aIJJYoCCupMjJoG+v8cBp+aj4C6YQDSuuxxvkkHQvbB 5zNs0jnxg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldz6F-00Ghzy-OY; Tue, 04 May 2021 17:44:47 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldz6D-00Ghzj-En for linux-arm-kernel@desiato.infradead.org; Tue, 04 May 2021 17:44:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lF4nm+wvc4Yrm4LaUJNB73cSo0GhO9PUVP8UbJ37uvw=; b=MBC145gJIEbUi68gHXRc1F5gwi a/rzuQUCFABcFsBsfnkQ6q9epDlCwKyOhmXq6Q+2DykIskKyb/XkfWLZyqWpOBvZlEww5+tMbPRFB rWEeYZU+wxdnf0ortxSM81uE4F+f9O2zv4v2JlIxF8tITOalfdYlAlqOoWf5lcyHWloUFFT6EF95K XWAzcOOF+Sba2EeIxLPVMCIL8203Me7vgeY2zYHWENAsgEbnXiiknVcdRbAT7pUSH6Eb2WbiSHeji 6/mphQEgzS4GaXSBWG1gV7PzD6rjANxODeGtXU7oM3ETUTbXI3EA+kXNAoCAcTcoh28yJ8YCQXBou Sm8JNO+w==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldz6A-0049Jv-Uv for linux-arm-kernel@lists.infradead.org; Tue, 04 May 2021 17:44:44 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9249C61166; Tue, 4 May 2021 17:44:39 +0000 (UTC) Date: Tue, 4 May 2021 18:44:37 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v11 5/6] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: References: <20210416154309.22129-1-steven.price@arm.com> <20210416154309.22129-6-steven.price@arm.com> <20210427175844.GB17872@arm.com> <340d35c2-46ed-35ea-43fa-e5cb64c27230@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <340d35c2-46ed-35ea-43fa-e5cb64c27230@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210504_104443_038639_ECB51396 X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 29, 2021 at 05:06:07PM +0100, Steven Price wrote: > On 27/04/2021 18:58, Catalin Marinas wrote: > > On Fri, Apr 16, 2021 at 04:43:08PM +0100, Steven Price wrote: > > > diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > > > index 24223adae150..2b85a047c37d 100644 > > > --- a/arch/arm64/include/uapi/asm/kvm.h > > > +++ b/arch/arm64/include/uapi/asm/kvm.h > > > @@ -184,6 +184,20 @@ struct kvm_vcpu_events { > > > __u32 reserved[12]; > > > }; > > > +struct kvm_arm_copy_mte_tags { > > > + __u64 guest_ipa; > > > + __u64 length; > > > + union { > > > + void __user *addr; > > > + __u64 padding; > > > + }; > > > + __u64 flags; > > > + __u64 reserved[2]; > > > +}; [...] > > Maybe add the two reserved > > values to the union in case we want to store something else in the > > future. > > I'm not sure what you mean here. What would the reserved fields be unioned > with? And surely they are no longer reserved in that case? In case you want to keep the structure size the same for future expansion and the expansion only happens via the union, you'd add some padding in there just in case. We do this for struct siginfo with an _si_pad[] array in the union. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F034C433B4 for ; Tue, 4 May 2021 17:44:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31B03613CB for ; Tue, 4 May 2021 17:44:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231944AbhEDRpi (ORCPT ); Tue, 4 May 2021 13:45:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:40056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbhEDRph (ORCPT ); Tue, 4 May 2021 13:45:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9249C61166; Tue, 4 May 2021 17:44:39 +0000 (UTC) Date: Tue, 4 May 2021 18:44:37 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones Subject: Re: [PATCH v11 5/6] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: References: <20210416154309.22129-1-steven.price@arm.com> <20210416154309.22129-6-steven.price@arm.com> <20210427175844.GB17872@arm.com> <340d35c2-46ed-35ea-43fa-e5cb64c27230@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <340d35c2-46ed-35ea-43fa-e5cb64c27230@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 29, 2021 at 05:06:07PM +0100, Steven Price wrote: > On 27/04/2021 18:58, Catalin Marinas wrote: > > On Fri, Apr 16, 2021 at 04:43:08PM +0100, Steven Price wrote: > > > diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > > > index 24223adae150..2b85a047c37d 100644 > > > --- a/arch/arm64/include/uapi/asm/kvm.h > > > +++ b/arch/arm64/include/uapi/asm/kvm.h > > > @@ -184,6 +184,20 @@ struct kvm_vcpu_events { > > > __u32 reserved[12]; > > > }; > > > +struct kvm_arm_copy_mte_tags { > > > + __u64 guest_ipa; > > > + __u64 length; > > > + union { > > > + void __user *addr; > > > + __u64 padding; > > > + }; > > > + __u64 flags; > > > + __u64 reserved[2]; > > > +}; [...] > > Maybe add the two reserved > > values to the union in case we want to store something else in the > > future. > > I'm not sure what you mean here. What would the reserved fields be unioned > with? And surely they are no longer reserved in that case? In case you want to keep the structure size the same for future expansion and the expansion only happens via the union, you'd add some padding in there just in case. We do this for struct siginfo with an _si_pad[] array in the union. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71AC3C433B4 for ; Tue, 4 May 2021 17:48:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BDF3613C6 for ; Tue, 4 May 2021 17:48:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BDF3613C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldz9a-0002Q3-5n for qemu-devel@archiver.kernel.org; Tue, 04 May 2021 13:48:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldz6S-00013a-M8 for qemu-devel@nongnu.org; Tue, 04 May 2021 13:45:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:56990) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldz6F-00078G-Im for qemu-devel@nongnu.org; Tue, 04 May 2021 13:44:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9249C61166; Tue, 4 May 2021 17:44:39 +0000 (UTC) Date: Tue, 4 May 2021 18:44:37 +0100 From: Catalin Marinas To: Steven Price Subject: Re: [PATCH v11 5/6] KVM: arm64: ioctl to fetch/store tags in a guest Message-ID: References: <20210416154309.22129-1-steven.price@arm.com> <20210416154309.22129-6-steven.price@arm.com> <20210427175844.GB17872@arm.com> <340d35c2-46ed-35ea-43fa-e5cb64c27230@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <340d35c2-46ed-35ea-43fa-e5cb64c27230@arm.com> Received-SPF: pass client-ip=198.145.29.99; envelope-from=cmarinas@kernel.org; helo=mail.kernel.org X-Spam_score_int: -66 X-Spam_score: -6.7 X-Spam_bar: ------ X-Spam_report: (-6.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , "Dr. David Alan Gilbert" , Andrew Jones , Haibo Xu , Suzuki K Poulose , qemu-devel@nongnu.org, Marc Zyngier , Juan Quintela , Richard Henderson , linux-kernel@vger.kernel.org, Dave Martin , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Apr 29, 2021 at 05:06:07PM +0100, Steven Price wrote: > On 27/04/2021 18:58, Catalin Marinas wrote: > > On Fri, Apr 16, 2021 at 04:43:08PM +0100, Steven Price wrote: > > > diff --git a/arch/arm64/include/uapi/asm/kvm.h b/arch/arm64/include/uapi/asm/kvm.h > > > index 24223adae150..2b85a047c37d 100644 > > > --- a/arch/arm64/include/uapi/asm/kvm.h > > > +++ b/arch/arm64/include/uapi/asm/kvm.h > > > @@ -184,6 +184,20 @@ struct kvm_vcpu_events { > > > __u32 reserved[12]; > > > }; > > > +struct kvm_arm_copy_mte_tags { > > > + __u64 guest_ipa; > > > + __u64 length; > > > + union { > > > + void __user *addr; > > > + __u64 padding; > > > + }; > > > + __u64 flags; > > > + __u64 reserved[2]; > > > +}; [...] > > Maybe add the two reserved > > values to the union in case we want to store something else in the > > future. > > I'm not sure what you mean here. What would the reserved fields be unioned > with? And surely they are no longer reserved in that case? In case you want to keep the structure size the same for future expansion and the expansion only happens via the union, you'd add some padding in there just in case. We do this for struct siginfo with an _si_pad[] array in the union. -- Catalin