All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: "André Almeida" <andrealmeid@collabora.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Darren Hart <dvhart@infradead.org>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	kernel@collabora.com, krisman@collabora.com,
	pgriffais@valvesoftware.com, z.figura12@gmail.com,
	joel@joelfernandes.org, malteskarupke@fastmail.fm,
	linux-api@vger.kernel.org, fweimer@redhat.com,
	libc-alpha@sourceware.org, linux-kselftest@vger.kernel.org,
	shuah@kernel.org, acme@kernel.org, corbet@lwn.net,
	Peter Oskolkov <posk@posk.io>
Subject: Re: [PATCH v3 00/13] Add futex2 syscalls
Date: Wed, 5 May 2021 14:31:42 +0200	[thread overview]
Message-ID: <YJKQLkHuTH3EWJoR@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210427231248.220501-1-andrealmeid@collabora.com>

On Tue, Apr 27, 2021 at 08:12:35PM -0300, André Almeida wrote:
> Hi,
> 
> This patch series introduces the futex2 syscalls.

I still utterly detest that this adds a second hash-table for no
descernable reason.

The new syscall interface does not depend on that in any way, you
previously implemented the multi-wait thing in the current futex code.

Like I said last time; I'm okay with the new interface, but I don't see
why you need to reimplement the insides, that's all pointless code
duplication.

  parent reply	other threads:[~2021-05-05 12:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 23:12 [PATCH v3 00/13] Add futex2 syscalls André Almeida
2021-04-27 23:12 ` [PATCH v3 01/13] futex2: Implement wait and wake functions André Almeida
2021-04-28  7:22   ` kernel test robot
2021-04-27 23:12 ` [PATCH v3 02/13] futex2: Add support for shared futexes André Almeida
2021-04-27 23:12 ` [PATCH v3 03/13] futex2: Implement vectorized wait André Almeida
2021-04-27 23:12 ` [PATCH v3 04/13] futex2: Implement requeue operation André Almeida
2021-04-27 23:12 ` [PATCH v3 05/13] futex2: Add compatibility entry point for x86_x32 ABI André Almeida
2021-04-27 23:12 ` [PATCH v3 06/13] docs: locking: futex2: Add documentation André Almeida
2021-04-27 23:12 ` [PATCH v3 07/13] selftests: futex2: Add wake/wait test André Almeida
2021-04-27 23:12 ` [PATCH v3 08/13] selftests: futex2: Add timeout test André Almeida
2021-04-27 23:12 ` [PATCH v3 09/13] selftests: futex2: Add wouldblock test André Almeida
2021-04-27 23:12 ` [PATCH v3 10/13] selftests: futex2: Add waitv test André Almeida
2021-04-27 23:12 ` [PATCH v3 11/13] selftests: futex2: Add requeue test André Almeida
2021-04-27 23:12 ` [PATCH v3 12/13] perf bench: Add futex2 benchmark tests André Almeida
2021-04-27 23:12 ` [PATCH v3 13/13] kernel: Enable waitpid() for futex2 André Almeida
2021-05-05 12:31 ` Peter Zijlstra [this message]
2021-05-05 14:23   ` [PATCH v3 00/13] Add futex2 syscalls Thomas Gleixner
2021-05-06 14:48     ` André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJKQLkHuTH3EWJoR@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=andrealmeid@collabora.com \
    --cc=bigeasy@linutronix.de \
    --cc=corbet@lwn.net \
    --cc=dvhart@infradead.org \
    --cc=fweimer@redhat.com \
    --cc=joel@joelfernandes.org \
    --cc=kernel@collabora.com \
    --cc=krisman@collabora.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=malteskarupke@fastmail.fm \
    --cc=mingo@redhat.com \
    --cc=pgriffais@valvesoftware.com \
    --cc=posk@posk.io \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=z.figura12@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.