From: Matthias Kaehlcke <mka@chromium.org>
To: satya priya <skakit@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp
Date: Wed, 5 May 2021 07:46:12 -0700 [thread overview]
Message-ID: <YJKvtLMPCg56DO1E@google.com> (raw)
In-Reply-To: <1620197726-23802-8-git-send-email-skakit@codeaurora.org>
On Wed, May 05, 2021 at 12:25:25PM +0530, satya priya wrote:
> Subject: arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp
nit: just 'channel nodes' is a bit vague. In case you respin maybe
change it to something like 'Add ADC channel nodes for PMIC
temperatures to sc7280-idp'
In any case it doesn't seem worth to respin just for this.
>
> Add channel nodes for the on die temperatures of PMICS
> pmk8350, pm8350, pmr735a and pmr735b.
>
> Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2021-05-05 14:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 6:55 [PATCH V4 0/8] Add PMIC DT files for sc7280 satya priya
2021-05-05 6:55 ` [PATCH V4 1/8] arm64: dts: qcom: sm8350: Add label for thermal-zones node satya priya
2021-05-05 13:33 ` Matthias Kaehlcke
2021-05-05 6:55 ` [PATCH V4 2/8] arm64: dts: qcom: sc7280: Add " satya priya
2021-05-05 13:41 ` Matthias Kaehlcke
2021-05-05 6:55 ` [PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file satya priya
2021-05-05 6:55 ` [PATCH V4 4/8] arm64: dts: qcom: pm8350c: Add temp-alarm support satya priya
2021-05-05 6:55 ` [PATCH V4 5/8] arm64: dts: qcom: pmr735a: " satya priya
2021-05-05 6:55 ` [PATCH V4 6/8] arm64: dts: qcom: pmk8350: Add peripherals for pmk8350 satya priya
2021-05-05 14:35 ` Matthias Kaehlcke
2021-05-05 6:55 ` [PATCH V4 7/8] arm64: dts: qcom: sc7280: Add channel nodes for sc7280-idp satya priya
2021-05-05 14:46 ` Matthias Kaehlcke [this message]
2021-05-17 5:28 ` skakit
2021-05-05 6:55 ` [PATCH V4 8/8] arm64: dts: qcom: sc7280: Include PMIC DT files " satya priya
2021-05-05 14:57 ` Matthias Kaehlcke
2021-05-17 5:27 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJKvtLMPCg56DO1E@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.