From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/4] syscalls/modify_ldt: Replace TINFO with TPASS or TFAIL
Date: Thu, 6 May 2021 12:44:41 +0200 [thread overview]
Message-ID: <YJPImeHT9rVsVtON@pevik> (raw)
In-Reply-To: <20210429125255.31510-1-zhaogongyi@huawei.com>
Hi Zhao, Cyril,
> diff --git a/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c b/testcases/kernel/syscalls/modify_ldt/modify_ldt01.c
...
> @@ -149,15 +132,13 @@ int main(int ac, char **av)
> (void)waitpid(pid, &status, 0);
> if (WEXITSTATUS(status) != 0) {
> - flag = FAILED;
> tst_resm(TFAIL, "Did not generate SEGV, child returned "
> "unexpected status");
> - }
> -
> - if (flag) {
> - tst_resm(TINFO, "block 2 FAILED");
> } else {
> - tst_resm(TINFO, "block 2 PASSED");
> + if (WIFSIGNALED(status) && (WTERMSIG(status) == SIGSEGV))
> + tst_resm(TPASS, "generate SEGV as expected");
> + else
> + tst_resm(TFAIL, "Did not generate SEGV");
FYI: since merging this patch (f5e8e6b11) test fails on this. Is it expected?
I haven't looked closer whether it's a test bug or real issue.
Kind regards,
Petr
next prev parent reply other threads:[~2021-05-06 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 12:52 [LTP] [PATCH 2/4] syscalls/modify_ldt: Replace TINFO with TPASS or TFAIL Zhao Gongyi
2021-04-30 13:24 ` Cyril Hrubis
2021-05-06 10:44 ` Petr Vorel [this message]
2021-05-06 11:05 ` Cyril Hrubis
2021-05-06 12:06 ` Petr Vorel
2021-05-06 11:47 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2021-05-06 11:15 zhaogongyi
2021-05-06 11:23 zhaogongyi
2021-05-06 11:57 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJPImeHT9rVsVtON@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.