From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leifP-006HYm-W3 for kexec@lists.infradead.org; Thu, 06 May 2021 18:24:09 +0000 Date: Thu, 6 May 2021 20:24:01 +0200 From: Joerg Roedel Subject: Re: [PATCH 1/2] kexec: Allow architecture code to opt-out at runtime Message-ID: References: <20210506093122.28607-1-joro@8bytes.org> <20210506093122.28607-2-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Sean Christopherson Cc: Joerg Roedel , Eric Biederman , x86@kernel.org, kexec@lists.infradead.org, stable@vger.kernel.org, hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Martin Radev , Arvind Sankar , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org On Thu, May 06, 2021 at 03:43:23PM +0000, Sean Christopherson wrote: > This misses kexec_file_load. Right, thanks, I will fix that in the next version. > Also, is a new hook really needed? E.g. the SEV-ES check be shoved > into machine_kexec_prepare(). The downside is that we'd do a fair > amount of work before detecting failure, but that doesn't seem hugely > problematic. That could work, but I think its more user-friendly to just claim that the syscalls are not supported at all. Regards, Joerg _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B7C71 for ; Thu, 6 May 2021 18:24:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 26F63AF98; Thu, 6 May 2021 18:24:04 +0000 (UTC) Date: Thu, 6 May 2021 20:24:01 +0200 From: Joerg Roedel To: Sean Christopherson Cc: Joerg Roedel , Eric Biederman , x86@kernel.org, kexec@lists.infradead.org, stable@vger.kernel.org, hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Mike Stunes , Martin Radev , Arvind Sankar , linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 1/2] kexec: Allow architecture code to opt-out at runtime Message-ID: References: <20210506093122.28607-1-joro@8bytes.org> <20210506093122.28607-2-joro@8bytes.org> X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 06, 2021 at 03:43:23PM +0000, Sean Christopherson wrote: > This misses kexec_file_load. Right, thanks, I will fix that in the next version. > Also, is a new hook really needed? E.g. the SEV-ES check be shoved > into machine_kexec_prepare(). The downside is that we'd do a fair > amount of work before detecting failure, but that doesn't seem hugely > problematic. That could work, but I think its more user-friendly to just claim that the syscalls are not supported at all. Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_RED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47712C433ED for ; Thu, 6 May 2021 18:24:10 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF45F61157 for ; Thu, 6 May 2021 18:24:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF45F61157 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 70E446075E; Thu, 6 May 2021 18:24:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nu2aof82AFHz; Thu, 6 May 2021 18:24:08 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTP id 3E5C860732; Thu, 6 May 2021 18:24:08 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 15C2CC000E; Thu, 6 May 2021 18:24:08 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 49C07C0001 for ; Thu, 6 May 2021 18:24:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2A79860732 for ; Thu, 6 May 2021 18:24:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b1Tz-eokdH_F for ; Thu, 6 May 2021 18:24:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by smtp3.osuosl.org (Postfix) with ESMTPS id 734A4606A5 for ; Thu, 6 May 2021 18:24:06 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 26F63AF98; Thu, 6 May 2021 18:24:04 +0000 (UTC) Date: Thu, 6 May 2021 20:24:01 +0200 From: Joerg Roedel To: Sean Christopherson Subject: Re: [PATCH 1/2] kexec: Allow architecture code to opt-out at runtime Message-ID: References: <20210506093122.28607-1-joro@8bytes.org> <20210506093122.28607-2-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: kvm@vger.kernel.org, Peter Zijlstra , Dave Hansen , virtualization@lists.linux-foundation.org, Arvind Sankar , hpa@zytor.com, Jiri Slaby , Joerg Roedel , x86@kernel.org, David Rientjes , Masami Hiramatsu , Martin Radev , Tom Lendacky , Kees Cook , Cfir Cohen , linux-coco@lists.linux.dev, Andy Lutomirski , Dan Williams , Juergen Gross , Mike Stunes , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Eric Biederman , Erdem Aktas X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Thu, May 06, 2021 at 03:43:23PM +0000, Sean Christopherson wrote: > This misses kexec_file_load. Right, thanks, I will fix that in the next version. > Also, is a new hook really needed? E.g. the SEV-ES check be shoved > into machine_kexec_prepare(). The downside is that we'd do a fair > amount of work before detecting failure, but that doesn't seem hugely > problematic. That could work, but I think its more user-friendly to just claim that the syscalls are not supported at all. Regards, Joerg _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization