From: "Theodore Ts'o" <tytso@mit.edu>
To: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] e2fsck: fix unaligned accesses to ext4_fc_tl struct
Date: Thu, 6 May 2021 23:10:59 -0400 [thread overview]
Message-ID: <YJSvw6oy1Rg6eIrJ@mit.edu> (raw)
In-Reply-To: <20210507002110.3933387-2-harshads@google.com>
On Thu, May 06, 2021 at 05:21:10PM -0700, Harshad Shirwadkar wrote:
> From: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
>
> Fast commit related struct ext4_fc_tl can be unaligned on disk. So,
> while accessing that we should ensure that the pointers are
> aligned. This patch fixes unaligned accesses to ext4_fc_tl and also
> gets rid of macros fc_for_each_tl and ext4_fc_tag_val that may result
> in unaligned accesses to struct ext4_fc_tl.
>
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Looks good. I wrote my reply with a proposed version of
ext4_fc_tag_val() before I saw your patch.
This patch wasn't enough to fix the sparc64 crash, but after doing
some additional investigation, I was able to figure out how to fix
things so that j_recovery_fast_commit is working on sparc64. Patch
follows on this thread...
- Ted
next prev parent reply other threads:[~2021-05-07 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 0:21 [PATCH 1/2] e2fsck: fix portability problems caused by unaligned accesses Harshad Shirwadkar
2021-05-07 0:21 ` [PATCH 2/2] e2fsck: fix unaligned accesses to ext4_fc_tl struct Harshad Shirwadkar
2021-05-07 3:10 ` Theodore Ts'o [this message]
2021-05-07 3:13 ` [PATCH] e2fsck: fix unaligned accesses to ext4_fc_add_range and fc_raw_inode Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJSvw6oy1Rg6eIrJ@mit.edu \
--to=tytso@mit.edu \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.