From: Petr Vorel <pvorel@suse.cz>
To: NeilBrown <neilb@suse.de>
Cc: "J . Bruce Fields" <bfields@fieldses.org>,
linux-nfs@vger.kernel.org, Steve Dickson <steved@redhat.com>,
Chuck Lever <chuck.lever@oracle.com>,
Alexey Kodanev <alexey.kodanev@oracle.com>
Subject: Re: [PATCH/RFC nfs-utils] Fix NFSv4 export of tmpfs filesystems.
Date: Fri, 7 May 2021 12:06:40 +0200 [thread overview]
Message-ID: <YJURMBWOxqGK7rh1@pevik> (raw)
In-Reply-To: <162035212343.24322.12361160756597283121@noble.neil.brown.name>
Hi Neil,
> [[This is a proposed fix. It seems to work. I'd like
> some review comments before it is committed.
> Petr: it would be great if you could test it to confirm
> it actually works in your case.
> ]]
Thanks for a quick fix. It runs nicely in newer kernels (5.11.12-1-default
openSUSE and 5.10.0-6-amd64 Debian). But it somehow fails on older ones
(SLES 5.3.18-54-default heavily patched and 4.9.0-11-amd64).
I have some problem on Debian with 4.9.0-11-amd64 fails on both tmpfs and ext4,
others work fine (testing tmpfs, btrfs and ext4). But maybe I did something
wrong during testing. I did:
cp ./utils/mountd/mountd /usr/sbin/rpc.mountd
systemctl restart nfs-mountd.service
Failure is regardless I use new mount.nfs (master) or the original from
Debian (1.3.3).
strace looks nearly the same on tmpfs and ext4:
socket(AF_INET, SOCK_STREAM, IPPROTO_TCP) = 5
fcntl(5, F_GETFL) = 0x2 (flags O_RDWR)
fcntl(5, F_SETFL, O_RDWR|O_NONBLOCK) = 0
connect(5, {sa_family=AF_INET, sin_port=htons(111), sin_addr=inet_addr("10.0.0.2")}, 16) = -1 EINPROGRESS (Operation now in progress)
select(6, NULL, [5], NULL, {tv_sec=10, tv_usec=0}) = 1 (out [5], left {tv_sec=9, tv_usec=999997})
getsockopt(5, SOL_SOCKET, SO_ERROR, [0], [4]) = 0
fcntl(5, F_SETFL, O_RDWR) = 0
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0
getpeername(5, {sa_family=AF_INET, sin_port=htons(111), sin_addr=inet_addr("10.0.0.2")}, [128->16]) = 0
getsockname(5, {sa_family=AF_INET, sin_port=htons(54140), sin_addr=inet_addr("10.0.0.1")}, [128->16]) = 0
getsockopt(5, SOL_SOCKET, SO_TYPE, [1], [4]) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
getpid() = 920
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0
write(5, "\200\0\0008bZ\360\303\0\0\0\0\0\0\0\2\0\1\206\240\0\0\0\2\0\0\0\3\0\0\0\0"..., 60) = 60
poll([{fd=5, events=POLLIN}], 1, 9999) = 1 ([{fd=5, revents=POLLIN}])
read(5, "\200\0\0\34bZ\360\303\0\0\0\1\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\10\1", 65536) = 32
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
rt_sigprocmask(SIG_SETMASK, ~[RTMIN RT_1], [], 8) = 0
close(5) = 0
rt_sigprocmask(SIG_SETMASK, [], NULL, 8) = 0
socket(AF_INET, SOCK_STREAM, IPPROTO_TCP) = 5
fcntl(5, F_GETFL) = 0x2 (flags O_RDWR)
fcntl(5, F_SETFL, O_RDWR|O_NONBLOCK) = 0
Kind regards,
Petr
next prev parent reply other threads:[~2021-05-07 10:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 19:18 [RFC PATCH 1/1] mount.nfs: Fix mounting on tmpfs Petr Vorel
2021-04-22 20:23 ` J . Bruce Fields
2021-04-23 2:17 ` Petr Vorel
2021-04-23 14:23 ` J . Bruce Fields
2021-04-23 17:04 ` Petr Vorel
2021-04-23 18:13 ` J . Bruce Fields
2021-04-23 20:37 ` Petr Vorel
2021-05-03 2:21 ` NeilBrown
2021-05-03 8:10 ` Petr Vorel
2021-05-03 14:15 ` J . Bruce Fields
2021-04-23 13:50 ` Petr Vorel
2021-05-07 1:48 ` [PATCH/RFC nfs-utils] Fix NFSv4 export of tmpfs filesystems NeilBrown
2021-05-07 10:06 ` Petr Vorel [this message]
2021-05-13 4:07 ` NeilBrown
2021-05-13 18:38 ` Petr Vorel
2021-05-13 18:51 ` Petr Vorel
2021-05-17 3:08 ` NeilBrown
2021-05-17 14:27 ` Petr Vorel
2021-05-07 13:55 ` Chuck Lever III
2021-05-07 23:13 ` NeilBrown
2021-05-17 4:45 ` [PATCH/RFC v2 " NeilBrown
2021-05-17 15:00 ` Petr Vorel
2021-05-18 17:54 ` Petr Vorel
2021-05-20 17:37 ` Steve Dickson
2021-05-20 20:39 ` Petr Vorel
2021-05-21 1:38 ` NeilBrown
2021-05-21 1:40 ` [PATCH nfs-utils 1/2] Remove 'force' arg from cache_flush() NeilBrown
2021-05-21 1:41 ` [PATCH nfs-utils 2/2] Move declaration of etab and rmtab into libraries NeilBrown
2021-05-21 13:57 ` Petr Vorel
2021-05-23 18:31 ` Steve Dickson
2021-05-21 13:52 ` [PATCH nfs-utils 1/2] Remove 'force' arg from cache_flush() Petr Vorel
2021-05-23 18:30 ` Steve Dickson
2021-05-23 18:29 ` [PATCH/RFC v2 nfs-utils] Fix NFSv4 export of tmpfs filesystems Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJURMBWOxqGK7rh1@pevik \
--to=pvorel@suse.cz \
--cc=alexey.kodanev@oracle.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.