From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2558BC433B4 for ; Fri, 7 May 2021 10:30:50 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 8B9696143F for ; Fri, 7 May 2021 10:30:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B9696143F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2A8E84B2C5; Fri, 7 May 2021 06:30:49 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SAPY74sIfeZY; Fri, 7 May 2021 06:30:47 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E3CE24B49B; Fri, 7 May 2021 06:30:47 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3DEA64B444 for ; Fri, 7 May 2021 06:30:46 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VTZ32Y3OLmkE for ; Fri, 7 May 2021 06:30:45 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id CE01E4B2C5 for ; Fri, 7 May 2021 06:30:44 -0400 (EDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 17B75613F0; Fri, 7 May 2021 10:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620383443; bh=xO2yiNtWQ2O7eOAXqEu52tCA2HTisM05D8ogUeVRGIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I3wci5mv4Gs6EyRYz2OZSjpzVQI/OLGQ7wJFnSwJzXhSaAZezyd872uqmd8eixDl2 rFFe4IKS7TI1CU69Ujl5e9Qak2z6h7yGx0BJacxyzPTLMnHFOeTfrCTAQvPgGxOZ/3 2MtQGiRFNnfqAjpay08cGhYotePU1XN36qEKlKPqQiNZgDVPcYRIJ4wOJDDZ8SjD0V QMcmkJr6dqXSPBgebph8z/PdGUnNKfZLKvG7sVr944ubJVoyhTk2YEQxv5vRYHKsAo 75YjeuioJyCebAUNHpVf0f6O6/x/FqVOx5f1rf+PIOFaZadL9MsZadfp0YvXsJPFf3 0t9HnWVV6NieA== Date: Fri, 7 May 2021 13:30:35 +0300 From: Mike Rapoport To: Kefeng Wang Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) Message-ID: References: <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> <0cb013e4-1157-f2fa-96ec-e69e60833f72@huawei.com> <24b37c01-fc75-d459-6e61-d67e8f0cf043@redhat.com> <82cfbb7f-dd4f-12d8-dc76-847f06172200@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Anshuman Khandual , Catalin Marinas , David Hildenbrand , linux-kernel@vger.kernel.org, Mike Rapoport , linux-mm@kvack.org, kvmarm@lists.cs.columbia.edu, Marc Zyngier , Andrew Morton , Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gRnJpLCBNYXkgMDcsIDIwMjEgYXQgMDM6MTc6MDhQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3Jv dGU6Cj4gCj4gT24gMjAyMS81LzYgMjA6NDcsIEtlZmVuZyBXYW5nIHdyb3RlOgo+ID4gCj4gPiAK PiA+ID4gPiA+ID4gbm8sIHRoZSBDT05GSUdfQVJNX0xQQUUgaXMgbm90IHNldCwgYW5kIHllcyB3 aXRoIHNhbWUgcGFuaWMgYXQKPiA+ID4gPiA+ID4gbW92ZV9mcmVlcGFnZXMgYXQKPiA+ID4gPiA+ ID4gCj4gPiA+ID4gPiA+IHN0YXJ0X3Bmbi9lbmRfcGZuIFtkZTYwMCwgZGU3ZmZdLCBbZGU2MDAw MDAsIGRlN2ZmMDAwXQo+ID4gPiA+ID4gPiA6wqAgcGZuID1kZTYwMCwgcGFnZQo+ID4gPiA+ID4g PiA9ZWYzY2MwMDAsIHBhZ2UtZmxhZ3MgPSBmZmZmZmZmZizCoCBwZm4ycGh5ID0gZGU2MDAwMDAK PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiBfX2ZyZWVfbWVtb3J5X2NvcmUsIHJhbmdlOiAw eGIwMjAwMDAwIC0KPiA+ID4gPiA+ID4gPiA+IDB4YzAwMDAwMDAsIHBmbjogYjAyMDAgLSBiMDIw MAo+ID4gPiA+ID4gPiA+ID4gX19mcmVlX21lbW9yeV9jb3JlLCByYW5nZTogMHhjYzAwMDAwMCAt Cj4gPiA+ID4gPiA+ID4gPiAweGRjYTAwMDAwLCBwZm46IGNjMDAwIC0gYjAyMDAKPiA+ID4gPiA+ ID4gPiA+IF9fZnJlZV9tZW1vcnlfY29yZSwgcmFuZ2U6IDB4ZGU3MDAwMDAgLQo+ID4gPiA+ID4g PiA+ID4gMHhkZWEwMDAwMCwgcGZuOiBkZTcwMCAtIGIwMjAwCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IEhtbSwgW2RlNjAwLCBkZTdmZl0gaXMgbm90IGFkZGVkIHRvIHRoZSBmcmVlIGxpc3RzIHdoaWNo IGlzCj4gPiA+ID4gPiBjb3JyZWN0LiBCdXQKPiA+ID4gPiA+IHRoZW4gaXQncyB1bmNsZWFyIGhv dyB0aGUgcGFnZSBmb3IgZGU2MDAgZ2V0cyB0byBtb3ZlX2ZyZWVwYWdlcygpLi4uCj4gPiA+ID4g PiAKPiA+ID4gPiA+IENhbid0IHNheSBJIGhhdmUgYW55IGJyaWdodCBpZGVhcyB0byB0cnkgaGVy ZS4uLgo+ID4gPiA+IAo+ID4gPiA+IEFyZSB3ZSBtaXNzaW5nIHNvbWUgY2hlY2tzIChlLmcuLCBQ YWdlUmVzZXJ2ZWQoKSkgdGhhdAo+ID4gPiA+IHBmbl92YWxpZF93aXRoaW4oKQo+ID4gPiA+IHdv dWxkIGhhdmUgImNhdWdodCIgYmVmb3JlPwo+ID4gPiAKPiA+ID4gVW5sZXNzIEknbSBtaXNzaW5n IHNvbWV0aGluZyB0aGUgY3Jhc2ggaGFwcGVucyBpbiBfX3JtcXVldWVfZmFsbGJhY2soKToKPiA+ ID4gCj4gPiA+IGRvX3N0ZWFsOgo+ID4gPiDCoMKgwqDCoHBhZ2UgPSBnZXRfcGFnZV9mcm9tX2Zy ZWVfYXJlYShhcmVhLCBmYWxsYmFja19tdCk7Cj4gPiA+IAo+ID4gPiDCoMKgwqDCoHN0ZWFsX3N1 aXRhYmxlX2ZhbGxiYWNrKHpvbmUsIHBhZ2UsIGFsbG9jX2ZsYWdzLCBzdGFydF9taWdyYXRldHlw ZSwKPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgY2FuX3N0ZWFsKTsKPiA+ID4gwqDCoMKgwqDCoMKgwqAgLT4gbW92ZV9m cmVlcGFnZXMoKQo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC0+IEJVRygpCj4gPiA+IAo+ ID4gPiBTbyBhIHBhZ2UgZnJvbSBmcmVlIGFyZWEgc2hvdWxkIGJlIHNhbmUgYXMgdGhlIGZyZWVk IHJhbmdlIHdhcyBuZXZlcgo+ID4gPiBhZGRlZAo+ID4gPiBpdCB0byB0aGUgZnJlZSBsaXN0cy4K PiA+IAo+ID4gU29ycnkgZm9yIHRoZSBsYXRlIHJlc3BvbnNlIGR1ZSB0byB0aGUgdmFjYXRpb24u Cj4gPiAKPiA+IFRoZSBwZm4gaW4gcmFuZ2UgW2RlNjAwLCBkZTdmZl0gd29uJ3QgYmUgYWRkZWQg aW50byB0aGUgZnJlZSBsaXN0cyB2aWEKPiA+IF9fZnJlZV9tZW1vcnlfY29yZSgpLCBidXQgdGhl IHBmbiBjb3VsZCBiZSBhZGRlZCBpbnRvIGZyZWVsaXN0cyB2aWEKPiA+IGZyZWVfaGlnaG1lbV9w YWdlKCkKPiA+IAo+ID4gSSBhZGQgc29tZSBkZWJ1Z1sxXSBpbiBhZGRfdG9fZnJlZV9saXN0KCks IHdlIGNvdWxkIHNlZSB0aGUgY2FsbHRyYWNlCj4gPiAKPiA+IGZyZWVfaGlnaHBhZ2VzLCByYW5n ZV9wZm4gW2IwMjAwLCBjMDAwMF0sIHJhbmdlX2FkZHIgW2IwMjAwMDAwLCBjMDAwMDAwMF0KPiA+ IGZyZWVfaGlnaHBhZ2VzLCByYW5nZV9wZm4gW2NjMDAwLCBkY2EwMF0sIHJhbmdlX2FkZHIgW2Nj MDAwMDAwLCBkY2EwMDAwMF0KPiA+IGZyZWVfaGlnaHBhZ2VzLCByYW5nZV9wZm4gW2RlNzAwLCBk ZWEwMF0sIHJhbmdlX2FkZHIgW2RlNzAwMDAwLCBkZWEwMDAwMF0KPiA+IGFkZF90b19mcmVlX2xp c3QsID09PT4gcGZuID0gZGU3MDAKPiA+IC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0t LS0tLQo+ID4gV0FSTklORzogQ1BVOiAwIFBJRDogMCBhdCBtbS9wYWdlX2FsbG9jLmM6OTAwIGFk ZF90b19mcmVlX2xpc3QrMHg4Yy8weGVjCj4gPiBwZm4gPSBkZTcwMAo+ID4gTW9kdWxlcyBsaW5r ZWQgaW46Cj4gPiBDUFU6IDAgUElEOiAwIENvbW06IHN3YXBwZXIgTm90IHRhaW50ZWQgNS4xMC4w KyAjNDgKPiA+IEhhcmR3YXJlIG5hbWU6IEhpc2lsaWNvbiBBOQo+ID4gWzxjMDEwYTYwMD5dIChz aG93X3N0YWNrKSBmcm9tIFs8YzA0YjIxYzQ+XSAoZHVtcF9zdGFjaysweDljLzB4YzApCj4gPiBb PGMwNGIyMWM0Pl0gKGR1bXBfc3RhY2spIGZyb20gWzxjMDExYzcwOD5dIChfX3dhcm4rMHhjMC8w eGVjKQo+ID4gWzxjMDExYzcwOD5dIChfX3dhcm4pIGZyb20gWzxjMDExYzdhOD5dICh3YXJuX3Ns b3dwYXRoX2ZtdCsweDc0LzB4YTQpCj4gPiBbPGMwMTFjN2E4Pl0gKHdhcm5fc2xvd3BhdGhfZm10 KSBmcm9tIFs8YzAyMzcyMWM+XQo+ID4gKGFkZF90b19mcmVlX2xpc3QrMHg4Yy8weGVjKQo+ID4g WzxjMDIzNzIxYz5dIChhZGRfdG9fZnJlZV9saXN0KSBmcm9tIFs8YzAyMzdlMDA+XQo+ID4gKGZy ZWVfcGNwcGFnZXNfYnVsaysweDIwMC8weDI3OCkKPiA+IFs8YzAyMzdlMDA+XSAoZnJlZV9wY3Bw YWdlc19idWxrKSBmcm9tIFs8YzAyMzhkMTQ+XQo+ID4gKGZyZWVfdW5yZWZfcGFnZSsweDU4LzB4 NjgpCj4gPiBbPGMwMjM4ZDE0Pl0gKGZyZWVfdW5yZWZfcGFnZSkgZnJvbSBbPGMwMjNiYjU0Pl0K PiA+IChmcmVlX2hpZ2htZW1fcGFnZSsweGMvMHg1MCkKPiA+IFs8YzAyM2JiNTQ+XSAoZnJlZV9o aWdobWVtX3BhZ2UpIGZyb20gWzxjMDcwNjIwYz5dIChtZW1faW5pdCsweDIxYy8weDI1NCkKPiA+ IFs8YzA3MDYyMGM+XSAobWVtX2luaXQpIGZyb20gWzxjMDcwMGIzOD5dIChzdGFydF9rZXJuZWwr MHgyNTgvMHg1YzApCj4gPiBbPGMwNzAwYjM4Pl0gKHN0YXJ0X2tlcm5lbCkgZnJvbSBbPDAwMDAw MDAwPl0gKDB4MCkKPiA+IAo+ID4gc28gYW55IGlkZWE/Cj4gCj4gSWYgcGZuID0gMHhkZTcwMCwg ZHVlIHRvIHRoZSBwYWdlYmxvY2tfbnJfcGFnZXMgPSAweDIwMCwgdGhlbiB0aGUKPiBzdGFydF9w Zm4sZW5kX3BmbiBwYXNzZWQgdG8gbW92ZV9mcmVlcGFnZXMoKSB3aWxsIGJlIFtkZTYwMCwgZGU3 ZmZdLAo+IGJ1dCB0aGUgcmFuZ2Ugb2YgW2RlNjAwLGRlNzAwXSB3aXRob3V0IOKAmHN0cnVjdCBw YWdlJyB3aWxsIGxlYWQgdG8KPiB0aGlzIHBhbmljIHdoZW4gcGZuX3ZhbGlkX3dpdGhpbiBub3Qg ZW5hYmxlZCBpZiBubyBIT0xFU19JTl9aT05FLAo+IGFuZCB0aGUgc2FtZSBpc3N1ZSB3aWxsIG9j Y3VycmVkIGluIGlzb2xhdGVfZnJlZXBhZ2VzX2Jsb2NrKCksIG1heWJlCgpJIHRoaW5rIHlvdXIg YW5hbHlzaXMgaXMgY29ycmVjdCBleGNlcHQgb25lIG1pbm9yIGRldGFpbC4gV2l0aCB0aGUgI2lm ZGVmCmZpeCBJJ3ZlIHByb3Bvc2VkIGVhcmxpZXJpIFsxXSB0aGUgbWVtbWFwIGZvciBbMHhkZTYw MCwgMHhkZTcwMF0gc2hvdWxkIG5vdApiZSBmcmVlZCBzbyB0aGVyZSBzaG91bGQgYmUgYSBzdHJ1 Y3QgcGFnZS4gRGlkIHlvdSBjaGVjayB3aGF0IHBhcnRzIG9mIHRoZQptZW1tYXAgYXJlIGFjdHVh bGx5IGZyZWVkIHdpdGggdGhpcyBwYXRjaCBhcHBsaWVkPwpXb3VsZCB5b3UgZ2V0IGEgcGFuaWMg aWYgeW91IGFkZAoKCWR1bXBfcGFnZShwZm5fdG9fcGFnZSgweGRlNjAwKSwgIiIpOwoKc2F5LCBp biB0aGUgZW5kIG9mIG1lbWJsb2NrX2ZyZWVfYWxsKCk/Cgo+IHRoZXJlIGFyZSBzb21lIHNjZW5l LCBzbyBJIHNlbGVjdCBIT0xFU19JTl9aT05FIGluIEFSQ0hfSElTSShBUk0pIHRvIHNvbHZlCj4g dGhpcyBpc3N1ZSBpbiBvdXIgNS4xMCwgc2hvdWxkIHdlIHNlbGVjdCBIT0xFU19JTl9aT05FIGlu IGFsbCBBUk0gb3Igb25seSBpbgo+IEFSQ0hfSElTSSwgYW55IGJldHRlciBzb2x1dGlvbj8gIFRo YW5rcy4KCkkgZG9uJ3QgdGhpbmsgdGhhdCBIT0xFU19JTl9aT05FIGlzIHRoZSByaWdodCBzb2x1 dGlvbi4gSSBiZWxpZXZlIHRoYXQgd2UKbXVzdCBrZWVwIHRoZSBtZW1vcnkgbWFwIGFsaWduZWQg b24gcGFnZWJsb2NrIGJvdW5kYXJpZXMuIFRoYXQncyBzdXJlbHkgbm90IHRoZQpjYXNlIGZvciBT UEFSU0VNRU0gYXMgb2Ygbm93LCBhbmQgaWYgbXkgZml4IGlzIG5vdCBlbm91Z2ggd2UgbmVlZCB0 byBmaW5kCndoZXJlIGl0IHdlbnQgd3JvbmcuCgpCZXNpZGVzLCBJJ2Qgc2F5IHRoYXQgaWYgaXQg aXMgcG9zc2libGUgdG8gdXBkYXRlIHlvdXIgZmlybXdhcmUgdG8gbWFrZSB0aGUKbWVtb3J5IGxh eW91dCByZXBvcnRlZCB0byB0aGUga2VybmVsIGxlc3MsIGhtbSwgZXNvdGVyaWMsIHlvdSB3b3Vs ZCBoaXQKbGVzcyBjb3JuZXIgY2FzZXMuCgpbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGtt bC9ZSXBZOFRYQ1NjN0xmYTJaQGtlcm5lbC5vcmcKCi0tIApTaW5jZXJlbHkgeW91cnMsCk1pa2Uu Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBt YWlsaW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNz LmNvbHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E8CC433B4 for ; Fri, 7 May 2021 10:32:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AF0F61456 for ; Fri, 7 May 2021 10:32:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AF0F61456 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hM46rHDhAIavhQI+Pb6CnJC26LtVpK/M4TEOUP+s2Q0=; b=cUpQ87mGxqK0onDoJW5R5d7S/ A9thSghoXm694yFZOd2CaK8h8JHhz5g0H782BLXQ8aU9So9QaK2WYYxUABnb2jVyMUHvPbT2W8MJY oDoup+ym1LrXim7mJ0iPAHmdSLXJ0tgnV3TfBg2RS5HlADwK75Oz+/L8TlV5Vmi9zYKS0Tswj99Dq juCz6ogZTMPW8129fNeztUPUHvSJl9ARKTAt+iAFyKqbzrVYKpmvNuivv1zdk15ZIsjd5dcu76OmM nL8TTllcAHaAxPm+yk933LVff8jMbg84nPLoe0bkZ9BIuFdTapqb2l4NHDb/x1Jf+XDK+zE/3GLqK VwApAQkVw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lexl0-006qKU-8i; Fri, 07 May 2021 10:30:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lexku-006qIo-IY for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 10:30:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=LcBbB3xrbgws3QbBQpke6ZuKvzaDfHgi4KcNZNwf42k=; b=gJr+miCj63WEEiL+vs/TVdy156 lqFlW8xw3t4Ytcb+4tIZp4Y3M4Sx/BkEQAodKx2UUUQInUlM8amdvj0emy+cA28v31ERnAX4DBniu V1TXbR0p2fCAMCzP9Ze0TZwuGsePlYvTrowGqgcILF6yov+58V2Yy4ECQ1iwS8u8Tv3grwE9LkHhb kupLTN5Em/h4JaHC6qQt/ZwsPTMVhRiF76BudhBvdt1t2t14C9mDIcVkajQaDIhFQ98kEgx9a1n5n U+LaGDOxatcblSFEriplubMHJNPYLvv+trd3LDLyp3ND+t9LCaZQ6kNR+K+qHwuW5v7BKs3wL5wQ/ BeUrcMWw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lexkq-006ml1-Lt for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 10:30:47 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 17B75613F0; Fri, 7 May 2021 10:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620383443; bh=xO2yiNtWQ2O7eOAXqEu52tCA2HTisM05D8ogUeVRGIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I3wci5mv4Gs6EyRYz2OZSjpzVQI/OLGQ7wJFnSwJzXhSaAZezyd872uqmd8eixDl2 rFFe4IKS7TI1CU69Ujl5e9Qak2z6h7yGx0BJacxyzPTLMnHFOeTfrCTAQvPgGxOZ/3 2MtQGiRFNnfqAjpay08cGhYotePU1XN36qEKlKPqQiNZgDVPcYRIJ4wOJDDZ8SjD0V QMcmkJr6dqXSPBgebph8z/PdGUnNKfZLKvG7sVr944ubJVoyhTk2YEQxv5vRYHKsAo 75YjeuioJyCebAUNHpVf0f6O6/x/FqVOx5f1rf+PIOFaZadL9MsZadfp0YvXsJPFf3 0t9HnWVV6NieA== Date: Fri, 7 May 2021 13:30:35 +0300 From: Mike Rapoport To: Kefeng Wang Cc: David Hildenbrand , linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) Message-ID: References: <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> <0cb013e4-1157-f2fa-96ec-e69e60833f72@huawei.com> <24b37c01-fc75-d459-6e61-d67e8f0cf043@redhat.com> <82cfbb7f-dd4f-12d8-dc76-847f06172200@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_033044_799147_B1100EC9 X-CRM114-Status: GOOD ( 33.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXkgMDcsIDIwMjEgYXQgMDM6MTc6MDhQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3Jv dGU6Cj4gCj4gT24gMjAyMS81LzYgMjA6NDcsIEtlZmVuZyBXYW5nIHdyb3RlOgo+ID4gCj4gPiAK PiA+ID4gPiA+ID4gbm8sIHRoZSBDT05GSUdfQVJNX0xQQUUgaXMgbm90IHNldCwgYW5kIHllcyB3 aXRoIHNhbWUgcGFuaWMgYXQKPiA+ID4gPiA+ID4gbW92ZV9mcmVlcGFnZXMgYXQKPiA+ID4gPiA+ ID4gCj4gPiA+ID4gPiA+IHN0YXJ0X3Bmbi9lbmRfcGZuIFtkZTYwMCwgZGU3ZmZdLCBbZGU2MDAw MDAsIGRlN2ZmMDAwXQo+ID4gPiA+ID4gPiA6wqAgcGZuID1kZTYwMCwgcGFnZQo+ID4gPiA+ID4g PiA9ZWYzY2MwMDAsIHBhZ2UtZmxhZ3MgPSBmZmZmZmZmZizCoCBwZm4ycGh5ID0gZGU2MDAwMDAK PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiBfX2ZyZWVfbWVtb3J5X2NvcmUsIHJhbmdlOiAw eGIwMjAwMDAwIC0KPiA+ID4gPiA+ID4gPiA+IDB4YzAwMDAwMDAsIHBmbjogYjAyMDAgLSBiMDIw MAo+ID4gPiA+ID4gPiA+ID4gX19mcmVlX21lbW9yeV9jb3JlLCByYW5nZTogMHhjYzAwMDAwMCAt Cj4gPiA+ID4gPiA+ID4gPiAweGRjYTAwMDAwLCBwZm46IGNjMDAwIC0gYjAyMDAKPiA+ID4gPiA+ ID4gPiA+IF9fZnJlZV9tZW1vcnlfY29yZSwgcmFuZ2U6IDB4ZGU3MDAwMDAgLQo+ID4gPiA+ID4g PiA+ID4gMHhkZWEwMDAwMCwgcGZuOiBkZTcwMCAtIGIwMjAwCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IEhtbSwgW2RlNjAwLCBkZTdmZl0gaXMgbm90IGFkZGVkIHRvIHRoZSBmcmVlIGxpc3RzIHdoaWNo IGlzCj4gPiA+ID4gPiBjb3JyZWN0LiBCdXQKPiA+ID4gPiA+IHRoZW4gaXQncyB1bmNsZWFyIGhv dyB0aGUgcGFnZSBmb3IgZGU2MDAgZ2V0cyB0byBtb3ZlX2ZyZWVwYWdlcygpLi4uCj4gPiA+ID4g PiAKPiA+ID4gPiA+IENhbid0IHNheSBJIGhhdmUgYW55IGJyaWdodCBpZGVhcyB0byB0cnkgaGVy ZS4uLgo+ID4gPiA+IAo+ID4gPiA+IEFyZSB3ZSBtaXNzaW5nIHNvbWUgY2hlY2tzIChlLmcuLCBQ YWdlUmVzZXJ2ZWQoKSkgdGhhdAo+ID4gPiA+IHBmbl92YWxpZF93aXRoaW4oKQo+ID4gPiA+IHdv dWxkIGhhdmUgImNhdWdodCIgYmVmb3JlPwo+ID4gPiAKPiA+ID4gVW5sZXNzIEknbSBtaXNzaW5n IHNvbWV0aGluZyB0aGUgY3Jhc2ggaGFwcGVucyBpbiBfX3JtcXVldWVfZmFsbGJhY2soKToKPiA+ ID4gCj4gPiA+IGRvX3N0ZWFsOgo+ID4gPiDCoMKgwqDCoHBhZ2UgPSBnZXRfcGFnZV9mcm9tX2Zy ZWVfYXJlYShhcmVhLCBmYWxsYmFja19tdCk7Cj4gPiA+IAo+ID4gPiDCoMKgwqDCoHN0ZWFsX3N1 aXRhYmxlX2ZhbGxiYWNrKHpvbmUsIHBhZ2UsIGFsbG9jX2ZsYWdzLCBzdGFydF9taWdyYXRldHlw ZSwKPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgY2FuX3N0ZWFsKTsKPiA+ID4gwqDCoMKgwqDCoMKgwqAgLT4gbW92ZV9m cmVlcGFnZXMoKQo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC0+IEJVRygpCj4gPiA+IAo+ ID4gPiBTbyBhIHBhZ2UgZnJvbSBmcmVlIGFyZWEgc2hvdWxkIGJlIHNhbmUgYXMgdGhlIGZyZWVk IHJhbmdlIHdhcyBuZXZlcgo+ID4gPiBhZGRlZAo+ID4gPiBpdCB0byB0aGUgZnJlZSBsaXN0cy4K PiA+IAo+ID4gU29ycnkgZm9yIHRoZSBsYXRlIHJlc3BvbnNlIGR1ZSB0byB0aGUgdmFjYXRpb24u Cj4gPiAKPiA+IFRoZSBwZm4gaW4gcmFuZ2UgW2RlNjAwLCBkZTdmZl0gd29uJ3QgYmUgYWRkZWQg aW50byB0aGUgZnJlZSBsaXN0cyB2aWEKPiA+IF9fZnJlZV9tZW1vcnlfY29yZSgpLCBidXQgdGhl IHBmbiBjb3VsZCBiZSBhZGRlZCBpbnRvIGZyZWVsaXN0cyB2aWEKPiA+IGZyZWVfaGlnaG1lbV9w YWdlKCkKPiA+IAo+ID4gSSBhZGQgc29tZSBkZWJ1Z1sxXSBpbiBhZGRfdG9fZnJlZV9saXN0KCks IHdlIGNvdWxkIHNlZSB0aGUgY2FsbHRyYWNlCj4gPiAKPiA+IGZyZWVfaGlnaHBhZ2VzLCByYW5n ZV9wZm4gW2IwMjAwLCBjMDAwMF0sIHJhbmdlX2FkZHIgW2IwMjAwMDAwLCBjMDAwMDAwMF0KPiA+ IGZyZWVfaGlnaHBhZ2VzLCByYW5nZV9wZm4gW2NjMDAwLCBkY2EwMF0sIHJhbmdlX2FkZHIgW2Nj MDAwMDAwLCBkY2EwMDAwMF0KPiA+IGZyZWVfaGlnaHBhZ2VzLCByYW5nZV9wZm4gW2RlNzAwLCBk ZWEwMF0sIHJhbmdlX2FkZHIgW2RlNzAwMDAwLCBkZWEwMDAwMF0KPiA+IGFkZF90b19mcmVlX2xp c3QsID09PT4gcGZuID0gZGU3MDAKPiA+IC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0t LS0tLQo+ID4gV0FSTklORzogQ1BVOiAwIFBJRDogMCBhdCBtbS9wYWdlX2FsbG9jLmM6OTAwIGFk ZF90b19mcmVlX2xpc3QrMHg4Yy8weGVjCj4gPiBwZm4gPSBkZTcwMAo+ID4gTW9kdWxlcyBsaW5r ZWQgaW46Cj4gPiBDUFU6IDAgUElEOiAwIENvbW06IHN3YXBwZXIgTm90IHRhaW50ZWQgNS4xMC4w KyAjNDgKPiA+IEhhcmR3YXJlIG5hbWU6IEhpc2lsaWNvbiBBOQo+ID4gWzxjMDEwYTYwMD5dIChz aG93X3N0YWNrKSBmcm9tIFs8YzA0YjIxYzQ+XSAoZHVtcF9zdGFjaysweDljLzB4YzApCj4gPiBb PGMwNGIyMWM0Pl0gKGR1bXBfc3RhY2spIGZyb20gWzxjMDExYzcwOD5dIChfX3dhcm4rMHhjMC8w eGVjKQo+ID4gWzxjMDExYzcwOD5dIChfX3dhcm4pIGZyb20gWzxjMDExYzdhOD5dICh3YXJuX3Ns b3dwYXRoX2ZtdCsweDc0LzB4YTQpCj4gPiBbPGMwMTFjN2E4Pl0gKHdhcm5fc2xvd3BhdGhfZm10 KSBmcm9tIFs8YzAyMzcyMWM+XQo+ID4gKGFkZF90b19mcmVlX2xpc3QrMHg4Yy8weGVjKQo+ID4g WzxjMDIzNzIxYz5dIChhZGRfdG9fZnJlZV9saXN0KSBmcm9tIFs8YzAyMzdlMDA+XQo+ID4gKGZy ZWVfcGNwcGFnZXNfYnVsaysweDIwMC8weDI3OCkKPiA+IFs8YzAyMzdlMDA+XSAoZnJlZV9wY3Bw YWdlc19idWxrKSBmcm9tIFs8YzAyMzhkMTQ+XQo+ID4gKGZyZWVfdW5yZWZfcGFnZSsweDU4LzB4 NjgpCj4gPiBbPGMwMjM4ZDE0Pl0gKGZyZWVfdW5yZWZfcGFnZSkgZnJvbSBbPGMwMjNiYjU0Pl0K PiA+IChmcmVlX2hpZ2htZW1fcGFnZSsweGMvMHg1MCkKPiA+IFs8YzAyM2JiNTQ+XSAoZnJlZV9o aWdobWVtX3BhZ2UpIGZyb20gWzxjMDcwNjIwYz5dIChtZW1faW5pdCsweDIxYy8weDI1NCkKPiA+ IFs8YzA3MDYyMGM+XSAobWVtX2luaXQpIGZyb20gWzxjMDcwMGIzOD5dIChzdGFydF9rZXJuZWwr MHgyNTgvMHg1YzApCj4gPiBbPGMwNzAwYjM4Pl0gKHN0YXJ0X2tlcm5lbCkgZnJvbSBbPDAwMDAw MDAwPl0gKDB4MCkKPiA+IAo+ID4gc28gYW55IGlkZWE/Cj4gCj4gSWYgcGZuID0gMHhkZTcwMCwg ZHVlIHRvIHRoZSBwYWdlYmxvY2tfbnJfcGFnZXMgPSAweDIwMCwgdGhlbiB0aGUKPiBzdGFydF9w Zm4sZW5kX3BmbiBwYXNzZWQgdG8gbW92ZV9mcmVlcGFnZXMoKSB3aWxsIGJlIFtkZTYwMCwgZGU3 ZmZdLAo+IGJ1dCB0aGUgcmFuZ2Ugb2YgW2RlNjAwLGRlNzAwXSB3aXRob3V0IOKAmHN0cnVjdCBw YWdlJyB3aWxsIGxlYWQgdG8KPiB0aGlzIHBhbmljIHdoZW4gcGZuX3ZhbGlkX3dpdGhpbiBub3Qg ZW5hYmxlZCBpZiBubyBIT0xFU19JTl9aT05FLAo+IGFuZCB0aGUgc2FtZSBpc3N1ZSB3aWxsIG9j Y3VycmVkIGluIGlzb2xhdGVfZnJlZXBhZ2VzX2Jsb2NrKCksIG1heWJlCgpJIHRoaW5rIHlvdXIg YW5hbHlzaXMgaXMgY29ycmVjdCBleGNlcHQgb25lIG1pbm9yIGRldGFpbC4gV2l0aCB0aGUgI2lm ZGVmCmZpeCBJJ3ZlIHByb3Bvc2VkIGVhcmxpZXJpIFsxXSB0aGUgbWVtbWFwIGZvciBbMHhkZTYw MCwgMHhkZTcwMF0gc2hvdWxkIG5vdApiZSBmcmVlZCBzbyB0aGVyZSBzaG91bGQgYmUgYSBzdHJ1 Y3QgcGFnZS4gRGlkIHlvdSBjaGVjayB3aGF0IHBhcnRzIG9mIHRoZQptZW1tYXAgYXJlIGFjdHVh bGx5IGZyZWVkIHdpdGggdGhpcyBwYXRjaCBhcHBsaWVkPwpXb3VsZCB5b3UgZ2V0IGEgcGFuaWMg aWYgeW91IGFkZAoKCWR1bXBfcGFnZShwZm5fdG9fcGFnZSgweGRlNjAwKSwgIiIpOwoKc2F5LCBp biB0aGUgZW5kIG9mIG1lbWJsb2NrX2ZyZWVfYWxsKCk/Cgo+IHRoZXJlIGFyZSBzb21lIHNjZW5l LCBzbyBJIHNlbGVjdCBIT0xFU19JTl9aT05FIGluIEFSQ0hfSElTSShBUk0pIHRvIHNvbHZlCj4g dGhpcyBpc3N1ZSBpbiBvdXIgNS4xMCwgc2hvdWxkIHdlIHNlbGVjdCBIT0xFU19JTl9aT05FIGlu IGFsbCBBUk0gb3Igb25seSBpbgo+IEFSQ0hfSElTSSwgYW55IGJldHRlciBzb2x1dGlvbj8gIFRo YW5rcy4KCkkgZG9uJ3QgdGhpbmsgdGhhdCBIT0xFU19JTl9aT05FIGlzIHRoZSByaWdodCBzb2x1 dGlvbi4gSSBiZWxpZXZlIHRoYXQgd2UKbXVzdCBrZWVwIHRoZSBtZW1vcnkgbWFwIGFsaWduZWQg b24gcGFnZWJsb2NrIGJvdW5kYXJpZXMuIFRoYXQncyBzdXJlbHkgbm90IHRoZQpjYXNlIGZvciBT UEFSU0VNRU0gYXMgb2Ygbm93LCBhbmQgaWYgbXkgZml4IGlzIG5vdCBlbm91Z2ggd2UgbmVlZCB0 byBmaW5kCndoZXJlIGl0IHdlbnQgd3JvbmcuCgpCZXNpZGVzLCBJJ2Qgc2F5IHRoYXQgaWYgaXQg aXMgcG9zc2libGUgdG8gdXBkYXRlIHlvdXIgZmlybXdhcmUgdG8gbWFrZSB0aGUKbWVtb3J5IGxh eW91dCByZXBvcnRlZCB0byB0aGUga2VybmVsIGxlc3MsIGhtbSwgZXNvdGVyaWMsIHlvdSB3b3Vs ZCBoaXQKbGVzcyBjb3JuZXIgY2FzZXMuCgpbMV0gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGtt bC9ZSXBZOFRYQ1NjN0xmYTJaQGtlcm5lbC5vcmcKCi0tIApTaW5jZXJlbHkgeW91cnMsCk1pa2Uu CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1h cm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0t a2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A84BC433ED for ; Fri, 7 May 2021 10:30:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2C10161460 for ; Fri, 7 May 2021 10:30:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C10161460 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 924FD8D000A; Fri, 7 May 2021 06:30:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C1798D0006; Fri, 7 May 2021 06:30:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728558D000A; Fri, 7 May 2021 06:30:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 53A358D0006 for ; Fri, 7 May 2021 06:30:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 179C282499A8 for ; Fri, 7 May 2021 10:30:45 +0000 (UTC) X-FDA: 78114066450.22.7ADBD36 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP id 5B0D180192E7 for ; Fri, 7 May 2021 10:30:19 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 17B75613F0; Fri, 7 May 2021 10:30:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620383443; bh=xO2yiNtWQ2O7eOAXqEu52tCA2HTisM05D8ogUeVRGIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I3wci5mv4Gs6EyRYz2OZSjpzVQI/OLGQ7wJFnSwJzXhSaAZezyd872uqmd8eixDl2 rFFe4IKS7TI1CU69Ujl5e9Qak2z6h7yGx0BJacxyzPTLMnHFOeTfrCTAQvPgGxOZ/3 2MtQGiRFNnfqAjpay08cGhYotePU1XN36qEKlKPqQiNZgDVPcYRIJ4wOJDDZ8SjD0V QMcmkJr6dqXSPBgebph8z/PdGUnNKfZLKvG7sVr944ubJVoyhTk2YEQxv5vRYHKsAo 75YjeuioJyCebAUNHpVf0f6O6/x/FqVOx5f1rf+PIOFaZadL9MsZadfp0YvXsJPFf3 0t9HnWVV6NieA== Date: Fri, 7 May 2021 13:30:35 +0300 From: Mike Rapoport To: Kefeng Wang Cc: David Hildenbrand , linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) Message-ID: References: <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> <0cb013e4-1157-f2fa-96ec-e69e60833f72@huawei.com> <24b37c01-fc75-d459-6e61-d67e8f0cf043@redhat.com> <82cfbb7f-dd4f-12d8-dc76-847f06172200@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I3wci5mv; spf=pass (imf08.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5B0D180192E7 X-Stat-Signature: 9aw3ze77rfcjmcp6m8p6oaj3hi8kdfwj Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620383419-198612 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 07, 2021 at 03:17:08PM +0800, Kefeng Wang wrote: >=20 > On 2021/5/6 20:47, Kefeng Wang wrote: > >=20 > >=20 > > > > > > no, the CONFIG_ARM_LPAE is not set, and yes with same panic a= t > > > > > > move_freepages at > > > > > >=20 > > > > > > start_pfn/end_pfn [de600, de7ff], [de600000, de7ff000] > > > > > > :=C2=A0 pfn =3Dde600, page > > > > > > =3Def3cc000, page-flags =3D ffffffff,=C2=A0 pfn2phy =3D de600= 000 > > > > > >=20 > > > > > > > > __free_memory_core, range: 0xb0200000 - > > > > > > > > 0xc0000000, pfn: b0200 - b0200 > > > > > > > > __free_memory_core, range: 0xcc000000 - > > > > > > > > 0xdca00000, pfn: cc000 - b0200 > > > > > > > > __free_memory_core, range: 0xde700000 - > > > > > > > > 0xdea00000, pfn: de700 - b0200 > > > > >=20 > > > > > Hmm, [de600, de7ff] is not added to the free lists which is > > > > > correct. But > > > > > then it's unclear how the page for de600 gets to move_freepages= ()... > > > > >=20 > > > > > Can't say I have any bright ideas to try here... > > > >=20 > > > > Are we missing some checks (e.g., PageReserved()) that > > > > pfn_valid_within() > > > > would have "caught" before? > > >=20 > > > Unless I'm missing something the crash happens in __rmqueue_fallbac= k(): > > >=20 > > > do_steal: > > > =C2=A0=C2=A0=C2=A0=C2=A0page =3D get_page_from_free_area(area, fall= back_mt); > > >=20 > > > =C2=A0=C2=A0=C2=A0=C2=A0steal_suitable_fallback(zone, page, alloc_f= lags, start_migratetype, > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 can_steal); > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -> move_freepages() > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = -> BUG() > > >=20 > > > So a page from free area should be sane as the freed range was neve= r > > > added > > > it to the free lists. > >=20 > > Sorry for the late response due to the vacation. > >=20 > > The pfn in range [de600, de7ff] won't be added into the free lists vi= a > > __free_memory_core(), but the pfn could be added into freelists via > > free_highmem_page() > >=20 > > I add some debug[1] in add_to_free_list(), we could see the calltrace > >=20 > > free_highpages, range_pfn [b0200, c0000], range_addr [b0200000, c0000= 000] > > free_highpages, range_pfn [cc000, dca00], range_addr [cc000000, dca00= 000] > > free_highpages, range_pfn [de700, dea00], range_addr [de700000, dea00= 000] > > add_to_free_list, =3D=3D=3D> pfn =3D de700 > > ------------[ cut here ]------------ > > WARNING: CPU: 0 PID: 0 at mm/page_alloc.c:900 add_to_free_list+0x8c/0= xec > > pfn =3D de700 > > Modules linked in: > > CPU: 0 PID: 0 Comm: swapper Not tainted 5.10.0+ #48 > > Hardware name: Hisilicon A9 > > [] (show_stack) from [] (dump_stack+0x9c/0xc0) > > [] (dump_stack) from [] (__warn+0xc0/0xec) > > [] (__warn) from [] (warn_slowpath_fmt+0x74/0xa4) > > [] (warn_slowpath_fmt) from [] > > (add_to_free_list+0x8c/0xec) > > [] (add_to_free_list) from [] > > (free_pcppages_bulk+0x200/0x278) > > [] (free_pcppages_bulk) from [] > > (free_unref_page+0x58/0x68) > > [] (free_unref_page) from [] > > (free_highmem_page+0xc/0x50) > > [] (free_highmem_page) from [] (mem_init+0x21c/0x= 254) > > [] (mem_init) from [] (start_kernel+0x258/0x5c0) > > [] (start_kernel) from [<00000000>] (0x0) > >=20 > > so any idea? >=20 > If pfn =3D 0xde700, due to the pageblock_nr_pages =3D 0x200, then the > start_pfn,end_pfn passed to move_freepages() will be [de600, de7ff], > but the range of [de600,de700] without =E2=80=98struct page' will lead = to > this panic when pfn_valid_within not enabled if no HOLES_IN_ZONE, > and the same issue will occurred in isolate_freepages_block(), maybe I think your analysis is correct except one minor detail. With the #ifdef fix I've proposed earlieri [1] the memmap for [0xde600, 0xde700] should n= ot be freed so there should be a struct page. Did you check what parts of th= e memmap are actually freed with this patch applied? Would you get a panic if you add dump_page(pfn_to_page(0xde600), ""); say, in the end of memblock_free_all()? > there are some scene, so I select HOLES_IN_ZONE in ARCH_HISI(ARM) to so= lve > this issue in our 5.10, should we select HOLES_IN_ZONE in all ARM or on= ly in > ARCH_HISI, any better solution? Thanks. I don't think that HOLES_IN_ZONE is the right solution. I believe that we must keep the memory map aligned on pageblock boundaries. That's surely n= ot the case for SPARSEMEM as of now, and if my fix is not enough we need to find where it went wrong. Besides, I'd say that if it is possible to update your firmware to make t= he memory layout reported to the kernel less, hmm, esoteric, you would hit less corner cases. [1] https://lore.kernel.org/lkml/YIpY8TXCSc7Lfa2Z@kernel.org --=20 Sincerely yours, Mike.