From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
selinux@vger.kernel.org, linux-security-module@vger.kernel.org,
James Morris <jmorris@namei.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: fix security_locked_down() call for SELinux
Date: Fri, 7 May 2021 14:03:04 +0200 [thread overview]
Message-ID: <YJUseJLHBdvKYEOK@kroah.com> (raw)
In-Reply-To: <20210507114150.139102-1-omosnace@redhat.com>
On Fri, May 07, 2021 at 01:41:50PM +0200, Ondrej Mosnacek wrote:
> Make sure that security_locked_down() is checked last so that a bogus
> denial is not reported by SELinux when (ia->ia_valid & (ATTR_MODE |
> ATTR_UID | ATTR_GID)) is zero.
Why would this be "bogus"?
> Note: this was introduced by commit 5496197f9b08 ("debugfs: Restrict
> debugfs when the kernel is locked down"), but it didn't matter at that
> time, as the SELinux support came in later.
>
> Fixes: 59438b46471a ("security,lockdown,selinux: implement SELinux lockdown")
What does this "fix"?
What is happening in selinux that it can not handle this sequence now?
That commit showed up a long time ago, this feels "odd"...
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-07 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 11:41 [PATCH] debugfs: fix security_locked_down() call for SELinux Ondrej Mosnacek
2021-05-07 12:03 ` Greg Kroah-Hartman [this message]
2021-05-07 12:12 ` Matthew Wilcox
2021-05-07 12:16 ` Greg Kroah-Hartman
2021-05-07 12:41 ` Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJUseJLHBdvKYEOK@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=rafael@kernel.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.