From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
Leo Yan <leo.yan@linaro.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/perf: Fix a build error on arm64 with clang
Date: Sun, 9 May 2021 09:50:57 -0300 [thread overview]
Message-ID: <YJfase9GYiy8d3ah@kernel.org> (raw)
In-Reply-To: <162037767540.94840.15758657049033010518.stgit@devnote2>
Em Fri, May 07, 2021 at 05:54:35PM +0900, Masami Hiramatsu escreveu:
> Since Clang's -Wmissing-field-initializers warns if a data
> structure is initialized with a signle NULL as below,
>
> ----
> tools/perf $ make CC=clang LLVM=1
> ...
> arch/arm64/util/kvm-stat.c:74:9: error: missing field 'ops' initializer [-Werror,-Wmissing-field-initializers]
> { NULL },
> ^
> 1 error generated.
> ----
Thanks, applied.
- Arnaldo
> add another field initializer expressly as same as other
> arch's kvm-stat.c code.
>
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/perf/arch/arm64/util/kvm-stat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/arm64/util/kvm-stat.c b/tools/perf/arch/arm64/util/kvm-stat.c
> index 2303256b7d05..73d18e0ed6f6 100644
> --- a/tools/perf/arch/arm64/util/kvm-stat.c
> +++ b/tools/perf/arch/arm64/util/kvm-stat.c
> @@ -71,7 +71,7 @@ struct kvm_reg_events_ops kvm_reg_events_ops[] = {
> .name = "vmexit",
> .ops = &exit_events,
> },
> - { NULL },
> + { NULL, NULL },
> };
>
> const char * const kvm_skip_events[] = {
>
--
- Arnaldo
next prev parent reply other threads:[~2021-05-09 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 8:54 [PATCH] tools/perf: build issues with Clang on arm64 and CFLAGS Masami Hiramatsu
2021-05-07 8:54 ` [PATCH] tools/perf: Fix a build error on arm64 with clang Masami Hiramatsu
2021-05-09 12:50 ` Arnaldo Carvalho de Melo [this message]
2021-05-10 12:14 ` [PATCH] tools/perf: build issues with Clang on arm64 and CFLAGS Arnaldo Carvalho de Melo
2021-05-11 10:36 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJfase9GYiy8d3ah@kernel.org \
--to=acme@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.