Re: [PATCH] Input: tsc200x: Drop hard-coded IRQ edge

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Linus,

On Mon, May 10, 2021 at 01:38:30AM +0200, Linus Walleij wrote:
> This edge setting should come from the device tree not
> the driver. Also, most device trees sets this to the
> falling edge, which is contradictory to what is hardcoded.

I see there are 2 possibilities:

1. The driver has never worked
2. DT interrupt annotation is wrong.

It would be nice to know if we are dealing with 1 or 2, as in case of #2
we need to adjust DTSes before this patch can be applied.

> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/input/touchscreen/tsc200x-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/tsc200x-core.c b/drivers/input/touchscreen/tsc200x-core.c
> index ce2fe30d6b8a..5f0ce663a2dc 100644
> --- a/drivers/input/touchscreen/tsc200x-core.c
> +++ b/drivers/input/touchscreen/tsc200x-core.c
> @@ -540,7 +540,7 @@ int tsc200x_probe(struct device *dev, int irq, const struct input_id *tsc_id,
>  
>  	error = devm_request_threaded_irq(dev, irq, NULL,
>  					  tsc200x_irq_thread,
> -					  IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> +					  IRQF_ONESHOT,
>  					  "tsc200x", ts);
>  	if (error) {
>  		dev_err(dev, "Failed to request irq, err: %d\n", error);
> -- 
> 2.30.2
> 

Thanks.

-- 
Dmitry