From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:e20e:0:0:0:0:0 with SMTP id z14csp4556250lfg; Tue, 11 May 2021 19:32:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEaCHTDM5i9KAOmK7vH9RHoIEmiQWPEv31OEeUqsqYM2NRzak5LIN5eYfpNcU87NsVBIl9 X-Received: by 2002:a0c:c446:: with SMTP id t6mr32805648qvi.3.1620786753530; Tue, 11 May 2021 19:32:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620786753; cv=none; d=google.com; s=arc-20160816; b=Iq9Zb7YWGjyd6QqatUx0PvqA2+aL+Mgs0hzCIYJKwere2tRQFtWwrVVwk3FMiH4R7A 6mXdFqhjKUlT6/0dtsjQZoXQ0zsCXlXLp7M3HBmR/QWjjDQEZCBhq986LJ4kCj6dO6Ym ohwWspUtXLd5OG2FdddShR+ZwhFJXzVVl0A1JsutRiZZcnlXYJBOlT61XxgsmhOHXYWy 2fc9MhW7D/xgofyXtf20yEndkRm8ty7U0d5xOS/rk8VOFAKwVnEIfUaQs85BuAiPXR5+ G8eK6ErEVbz7N5W1Mfk3fjjEGVCWbXyOGLcXHH3P0M7LFT799KCQXpE57mXPcrH8P2NB dO8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=VlWxmfelEVovOz+4+OHnihyOlFaRgg3z49TW7n8Wl4U=; b=HgpamLDD9XzIOBHxaxB6tMlY7xswyKPVASTQA8G7lCN6uisVz+lsFHRcrXapXXZk5Y gottoYyQUhya+sRiBi/faev92Ku3rbnpRUjxcj20ep/TUcOBot7WAnzgkrVElUInkiv9 +NWmYTr27atG7nNmJV5FORiIHdQf57pOlGk0ISzTQt76LtNKoV5RoCG34CY57ZB7OhqR H171faBl1nbcEd+sQNk0Ai5/aNX4WdRMS2D4V32VhFq9Eewq0nPGL+sDUOPcrNyxx/Wm xfso1IiMJHze7tjyDegjvi2FvCb1qq9SzxGNI8q1jbPx2ecowgyMcG5HhMP66GeUxiqt MJhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gibson.dropbear.id.au header.s=201602 header.b=aqzBghEf; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id p14si4256302qkh.365.2021.05.11.19.32.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 May 2021 19:32:33 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gibson.dropbear.id.au header.s=201602 header.b=aqzBghEf; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1]:35246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgefo-0001oo-Sy for alex.bennee@linaro.org; Tue, 11 May 2021 22:32:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgeff-0001o4-01; Tue, 11 May 2021 22:32:23 -0400 Received: from ozlabs.org ([203.11.71.1]:48267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgefc-0003uY-Vp; Tue, 11 May 2021 22:32:22 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4FfzMg1FJbz9sX2; Wed, 12 May 2021 12:32:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1620786735; bh=zWdzIevbLWun4MXmfWXa1h05wVUtNcgnYYA3jie2884=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aqzBghEfJpZwyPnz0SVfzkVOEMAVTRuRGREEuR6NF4mhOqB4Yi2VjKNzCMK5sw4AW o4MSVQ3n8+8I1ZAby1ieQ2uJwVTLBH8VGDZ1f7Vtoc5qt80XaROCONcLSg0gfQkIdM cz+pFy4sWv4Skq+Xn0uhqNqX4eXuyL1yn9jf3RqA= Date: Wed, 12 May 2021 12:24:42 +1000 From: David Gibson To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Message-ID: References: <20210511155354.3069141-1-philmd@redhat.com> <20210511155354.3069141-2-philmd@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qMWwRlmE27uFItL/" Content-Disposition: inline In-Reply-To: <20210511155354.3069141-2-philmd@redhat.com> Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Eduardo Habkost , "Michael S. Tsirkin" , Alexey Kardashevskiy , Richard Henderson , qemu-devel@nongnu.org, Greg Kurz , Igor Mammedov , "open list:ARM TCG CPUs" , qemu-ppc@nongnu.org, Marcel Apfelbaum , John Paul Adrian Glaubitz , Paolo Bonzini Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: zm5OOv4qcPA1 --qMWwRlmE27uFItL/ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daud=E9 wrote: > Per the kconfig.rst: >=20 > A device should be listed [...] ``imply`` if (depending on > the QEMU command line) the board may or may not be started > without it. >=20 > This is the case with the NVDIMM device, so use the 'imply' > weak reverse dependency to select the symbol. Uh.. It should definitely be possible to start a pseries machine without NVDIMM. I would have guessed the same for PC. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > default-configs/devices/ppc64-softmmu.mak | 1 - > hw/arm/Kconfig | 1 + > hw/i386/Kconfig | 1 + > hw/mem/Kconfig | 2 -- > hw/ppc/Kconfig | 1 + > 5 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/default-configs/devices/ppc64-softmmu.mak b/default-configs/= devices/ppc64-softmmu.mak > index ae0841fa3a1..cca52665d90 100644 > --- a/default-configs/devices/ppc64-softmmu.mak > +++ b/default-configs/devices/ppc64-softmmu.mak > @@ -8,4 +8,3 @@ CONFIG_POWERNV=3Dy > =20 > # For pSeries > CONFIG_PSERIES=3Dy > -CONFIG_NVDIMM=3Dy > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index b887f6a5b17..67723d9ea6a 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -6,6 +6,7 @@ config ARM_VIRT > imply VFIO_PLATFORM > imply VFIO_XGMAC > imply TPM_TIS_SYSBUS > + imply NVDIMM > select ARM_GIC > select ACPI > select ARM_SMMUV3 > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index 7f91f30877f..66838fa397b 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -23,6 +23,7 @@ config PC > imply TPM_TIS_ISA > imply VGA_PCI > imply VIRTIO_VGA > + imply NVDIMM > select FDC > select I8259 > select I8254 > diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig > index a0ef2cf648e..8b19fdc49f1 100644 > --- a/hw/mem/Kconfig > +++ b/hw/mem/Kconfig > @@ -7,6 +7,4 @@ config MEM_DEVICE > =20 > config NVDIMM > bool > - default y > - depends on (PC || PSERIES || ARM_VIRT) > select MEM_DEVICE > diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig > index e51e0e5e5ac..66e0b15d9ef 100644 > --- a/hw/ppc/Kconfig > +++ b/hw/ppc/Kconfig > @@ -3,6 +3,7 @@ config PSERIES > imply PCI_DEVICES > imply TEST_DEVICES > imply VIRTIO_VGA > + imply NVDIMM > select DIMM > select PCI > select SPAPR_VSCSI --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --qMWwRlmE27uFItL/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmCbPGYACgkQbDjKyiDZ s5IhMw//XHuWL0LI52jnQCIrwW5E5UE+x9LXCm+gDEg5BtjCpmTeE2esuGGpoOrC W3Q2sgDe434cj4wXvCPZJ+aXPt0ktFhScDS1aGA5mkvhn2pZ6k2j63ELk/jot68x DMDy5NK+z8UQo3nAKc+lS3j2oECh75oBVaXvI0I8QZqIzrhzqIKwb1meJTSoAa1H kq5houW6R42TvPQCfbPKuMpPxnuTTpxpyvIKvHX03qqFqyayxFf5FrvEU6ccm/RX 0Ow+f5efCGzM9FhWzWpw0ukXey7RSeYO92YtrW1c3aLJrHRuZZaA6ZUpER4tLjiG t/kK790CvQflts3Ge+NzMfpPFkOPtuJiqnhM353NSC3rYagNrTlnxOCa+BHTvEW+ E2ISj5B3G+bcslrt1IgAsJGM/pkgZLT3dl1h2P+Li66mAizuWijTMvH1SjWXqHJF EU6xyZhaN06P0BoCR2MRhVvLKkdtI/1CZyyhlcTWXjuKORmPagfIysvldAuMmkzX mmZpPss5GJ18Ny1WY1fZ4jdUZa333uUoIMceays0jSlMUgUIQxAAhOXmzfgznAkV nDIO6ay2/JXSKzPcOmoOBA/xzs2Gt67rPhcBLuojHqD+jcQkaSLJulfJl2k1MTgF 6R2yqeVMiBDugl4tctNF6E+plPzilTr4FnUiADifgrUZPUWD/tY= =AgV4 -----END PGP SIGNATURE----- --qMWwRlmE27uFItL/-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D6AC433B4 for ; Wed, 12 May 2021 02:33:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0C4D616E8 for ; Wed, 12 May 2021 02:33:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0C4D616E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgeh5-0003lV-5y for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 22:33:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgeff-0001o4-01; Tue, 11 May 2021 22:32:23 -0400 Received: from ozlabs.org ([203.11.71.1]:48267) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgefc-0003uY-Vp; Tue, 11 May 2021 22:32:22 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4FfzMg1FJbz9sX2; Wed, 12 May 2021 12:32:13 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1620786735; bh=zWdzIevbLWun4MXmfWXa1h05wVUtNcgnYYA3jie2884=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aqzBghEfJpZwyPnz0SVfzkVOEMAVTRuRGREEuR6NF4mhOqB4Yi2VjKNzCMK5sw4AW o4MSVQ3n8+8I1ZAby1ieQ2uJwVTLBH8VGDZ1f7Vtoc5qt80XaROCONcLSg0gfQkIdM cz+pFy4sWv4Skq+Xn0uhqNqX4eXuyL1yn9jf3RqA= Date: Wed, 12 May 2021 12:24:42 +1000 From: David Gibson To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Message-ID: References: <20210511155354.3069141-1-philmd@redhat.com> <20210511155354.3069141-2-philmd@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qMWwRlmE27uFItL/" Content-Disposition: inline In-Reply-To: <20210511155354.3069141-2-philmd@redhat.com> Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Eduardo Habkost , "Michael S. Tsirkin" , Alexey Kardashevskiy , Richard Henderson , qemu-devel@nongnu.org, Greg Kurz , Igor Mammedov , "open list:ARM TCG CPUs" , qemu-ppc@nongnu.org, John Paul Adrian Glaubitz , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --qMWwRlmE27uFItL/ Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daud=E9 wrote: > Per the kconfig.rst: >=20 > A device should be listed [...] ``imply`` if (depending on > the QEMU command line) the board may or may not be started > without it. >=20 > This is the case with the NVDIMM device, so use the 'imply' > weak reverse dependency to select the symbol. Uh.. It should definitely be possible to start a pseries machine without NVDIMM. I would have guessed the same for PC. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > default-configs/devices/ppc64-softmmu.mak | 1 - > hw/arm/Kconfig | 1 + > hw/i386/Kconfig | 1 + > hw/mem/Kconfig | 2 -- > hw/ppc/Kconfig | 1 + > 5 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/default-configs/devices/ppc64-softmmu.mak b/default-configs/= devices/ppc64-softmmu.mak > index ae0841fa3a1..cca52665d90 100644 > --- a/default-configs/devices/ppc64-softmmu.mak > +++ b/default-configs/devices/ppc64-softmmu.mak > @@ -8,4 +8,3 @@ CONFIG_POWERNV=3Dy > =20 > # For pSeries > CONFIG_PSERIES=3Dy > -CONFIG_NVDIMM=3Dy > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index b887f6a5b17..67723d9ea6a 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -6,6 +6,7 @@ config ARM_VIRT > imply VFIO_PLATFORM > imply VFIO_XGMAC > imply TPM_TIS_SYSBUS > + imply NVDIMM > select ARM_GIC > select ACPI > select ARM_SMMUV3 > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index 7f91f30877f..66838fa397b 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -23,6 +23,7 @@ config PC > imply TPM_TIS_ISA > imply VGA_PCI > imply VIRTIO_VGA > + imply NVDIMM > select FDC > select I8259 > select I8254 > diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig > index a0ef2cf648e..8b19fdc49f1 100644 > --- a/hw/mem/Kconfig > +++ b/hw/mem/Kconfig > @@ -7,6 +7,4 @@ config MEM_DEVICE > =20 > config NVDIMM > bool > - default y > - depends on (PC || PSERIES || ARM_VIRT) > select MEM_DEVICE > diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig > index e51e0e5e5ac..66e0b15d9ef 100644 > --- a/hw/ppc/Kconfig > +++ b/hw/ppc/Kconfig > @@ -3,6 +3,7 @@ config PSERIES > imply PCI_DEVICES > imply TEST_DEVICES > imply VIRTIO_VGA > + imply NVDIMM > select DIMM > select PCI > select SPAPR_VSCSI --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --qMWwRlmE27uFItL/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmCbPGYACgkQbDjKyiDZ s5IhMw//XHuWL0LI52jnQCIrwW5E5UE+x9LXCm+gDEg5BtjCpmTeE2esuGGpoOrC W3Q2sgDe434cj4wXvCPZJ+aXPt0ktFhScDS1aGA5mkvhn2pZ6k2j63ELk/jot68x DMDy5NK+z8UQo3nAKc+lS3j2oECh75oBVaXvI0I8QZqIzrhzqIKwb1meJTSoAa1H kq5houW6R42TvPQCfbPKuMpPxnuTTpxpyvIKvHX03qqFqyayxFf5FrvEU6ccm/RX 0Ow+f5efCGzM9FhWzWpw0ukXey7RSeYO92YtrW1c3aLJrHRuZZaA6ZUpER4tLjiG t/kK790CvQflts3Ge+NzMfpPFkOPtuJiqnhM353NSC3rYagNrTlnxOCa+BHTvEW+ E2ISj5B3G+bcslrt1IgAsJGM/pkgZLT3dl1h2P+Li66mAizuWijTMvH1SjWXqHJF EU6xyZhaN06P0BoCR2MRhVvLKkdtI/1CZyyhlcTWXjuKORmPagfIysvldAuMmkzX mmZpPss5GJ18Ny1WY1fZ4jdUZa333uUoIMceays0jSlMUgUIQxAAhOXmzfgznAkV nDIO6ay2/JXSKzPcOmoOBA/xzs2Gt67rPhcBLuojHqD+jcQkaSLJulfJl2k1MTgF 6R2yqeVMiBDugl4tctNF6E+plPzilTr4FnUiADifgrUZPUWD/tY= =AgV4 -----END PGP SIGNATURE----- --qMWwRlmE27uFItL/--