From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:e20e:0:0:0:0:0 with SMTP id z14csp5503099lfg; Wed, 12 May 2021 17:02:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2iSRhwQRIpRzt7qjO2DlHwEngcKwYprWYNJfNDg/aW+cAPNlq+pj01zrEB3RwkPFhj5BA X-Received: by 2002:a92:c5c1:: with SMTP id s1mr34184785ilt.295.1620864156566; Wed, 12 May 2021 17:02:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620864156; cv=none; d=google.com; s=arc-20160816; b=suUF3jYBbs608IRMjt5MoWqQD7Dp3KzDLQAfVatYEfd21T8uN8TJ1F/jTMTbw9dZUD G/q7YHg25XnQR+I0Ditc/qqq0ShoZlF5cNo5nybVw1RSrylt17aIyxv9sGiIhM/BNxeR WDdJKtijIK6GQnVsMIehGMQvK7u1KkqhMORh4Wv/QgM8en6fULXR0J1z3diOXCyH5ov2 IC6SKmK7vVOoMkfDEIt4PHq0PJhqDC74Ul377dQKo4UuxTSH5qN2JV/G8LYqmxR7W4VT s3lxf04uLGsw0LNvPSloGHxrU6Qy5/jV8uJUqNnXQ4YgCdLbwcallkgijsdAQER/ey7O 3hUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=y1CFM04l0I45oujRVMBzHsziHe+gBdEDEcJPYINu8rQ=; b=Z+oM5MwQf2VYFmgfWDTiibWKBRU6mbIBUfPdg1Kb/0tCgFH3OnG0qayKN+0TUzWCpm 0xcBw7ZdrkddTnN0WncK8qR3e//RCjNfgpj+ANdP0xiLs+VqtqeerpuFBotN/3BKL+X9 awJbvk1CLudkc4NwjYkNfPaJoqU6IY181aF16UOz66iIOIAMYh9lDUfivu9n3FFLDg56 uOMLp/Oyny/PPmKWC+B2RPBrmYOzehNxiQhbfC7nnakmFA1E2U8hKYGygh7pyEclnZt8 llViKNqzSTa6GdA5JNBLuGUrcXPhWyVsfDq39cWkksjpxQSW1s1fZ98/pKGxxW1VkKTo ljPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gibson.dropbear.id.au header.s=201602 header.b=idFYreAk; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y12si281333ilm.51.2021.05.12.17.02.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 May 2021 17:02:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gibson.dropbear.id.au header.s=201602 header.b=idFYreAk; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1]:41692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgyoF-0003Jc-Tq for alex.bennee@linaro.org; Wed, 12 May 2021 20:02:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgyo6-0003FC-6l; Wed, 12 May 2021 20:02:26 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:32959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgyo1-0003yO-3T; Wed, 12 May 2021 20:02:23 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4FgX0467smz9sWD; Thu, 13 May 2021 10:02:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1620864132; bh=ivdo1KTYrGth/+JkAaFNI5iI3U0rU7smdj9joehPMxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=idFYreAkWMxOgRZfM7gdR8RMFC3m5We+wolF3Dj09hd9BgRGa7GPMQuaZCYJkfJPD q9E8pO4cLbfAprILNts7gyH1E63NACQ6y0xclnH3TdXCE3C9bHM9iSp8sV1S1Wg0Vt 8SKHIle9zbXyVliYZH259JSrtqyCn4c1ePEbwbqw= Date: Wed, 12 May 2021 17:02:34 +1000 From: David Gibson To: Thomas Huth Subject: Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Message-ID: References: <20210511155354.3069141-1-philmd@redhat.com> <20210511155354.3069141-2-philmd@redhat.com> <21e0a306-ccfb-a627-1496-14f831fe80a7@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fC7dX5wvbkpFIsSX" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , "Michael S. Tsirkin" , Alexey Kardashevskiy , Richard Henderson , qemu-devel@nongnu.org, Greg Kurz , Igor Mammedov , "open list:ARM TCG CPUs" , qemu-ppc@nongnu.org, Marcel Apfelbaum , John Paul Adrian Glaubitz , Paolo Bonzini , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: +m/Sm30sqcyh --fC7dX5wvbkpFIsSX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 12, 2021 at 06:53:22AM +0200, Thomas Huth wrote: > On 12/05/2021 05.57, Philippe Mathieu-Daud=E9 wrote: > > On 5/12/21 4:24 AM, David Gibson wrote: > > > On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daud=E9 wr= ote: > > > > Per the kconfig.rst: > > > >=20 > > > > A device should be listed [...] ``imply`` if (depending on > > > > the QEMU command line) the board may or may not be started > > > > without it. > > > >=20 > > > > This is the case with the NVDIMM device, so use the 'imply' > > > > weak reverse dependency to select the symbol. > > >=20 > > > Uh.. It should definitely be possible to start a pseries machine > > > without NVDIMM. I would have guessed the same for PC. > >=20 > > Yes, this is what this patch does. With it we can build with: > > CONFIG_NVDIMM=3Dn >=20 > But with "imply" you could end up with a PSERIES that does not have NVDIMM > when also using --without-default-devices, couldn't you? Why don't you use > "select" instead of "imply" ? Oh.. clearly I misunderstand the semantics of "imply". If we don't need NVDIMM for PSERIES, why does there need to be any Kconfig connection between them at all? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --fC7dX5wvbkpFIsSX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmCbfYcACgkQbDjKyiDZ s5Jofw/9FCrSSe6dOlMYzTYhM54r6tz+JwuCU4UU4+RscM/Q/splCZ5Hf/gSPTrq tiLti0vUrkTCISkwaTFhuWoZIcrC1uL5wyIcr7cpl0xrw+7q6uz5S4zvXxZZxdS7 ++7MXeyg/FhhdJlSbfUUAqM9ZZ3Yr8Ye2NzjI0qhowEAI6s5i00HPQQe2HvwwtLd snjaTLeE9fioXuv0V+2YISVjsX1rsIOHC/pdNmj948qQhbFeDO+C301wQKJL5s+N ytK/mxUyuRqh1FXf59fuDTukNlrqrTOi96LwZIuuKgwWcBZ1X/x0zn2En2iJQT64 KGWz5PLvdldkVB9yOaMOHAL8mN97BxB2NWNCUBYTztW/m2aLb4SyAj1eastj4a2O 3YH+Clp+PwURJBVWa357BwJFtzegXvSeGf55A+5Rldhv4AWNegHlKbTAl+Lw9ZUE 08CMtsbqkXoRca5I1KZbJdyc7yy4udwAB92YJNCUDNRHpgZ/l98HuJKeJOkmvwJL +KpmAck25ssipmkhbwSKUGZfn3xfeir4xo/DK9KPa1KPFe/MmVK0alvIhPBM5ZBr Y7B7NjoR6q3XdPSZPA6MhfklCvOPiS4DmLaJG7eOdpkZ6WW4pI/wKS8798m8q/EZ xPdFeN6wIH6uZGH5PJ1Hp3dQYoHPw1QgU+7Vr9hcduNrVu+pNEk= =MVAO -----END PGP SIGNATURE----- --fC7dX5wvbkpFIsSX-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DATE_IN_PAST_12_24, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2761C433B4 for ; Thu, 13 May 2021 00:03:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5469661183 for ; Thu, 13 May 2021 00:03:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5469661183 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgypT-0004lu-BG for qemu-devel@archiver.kernel.org; Wed, 12 May 2021 20:03:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgyo6-0003FC-6l; Wed, 12 May 2021 20:02:26 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:32959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgyo1-0003yO-3T; Wed, 12 May 2021 20:02:23 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4FgX0467smz9sWD; Thu, 13 May 2021 10:02:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1620864132; bh=ivdo1KTYrGth/+JkAaFNI5iI3U0rU7smdj9joehPMxM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=idFYreAkWMxOgRZfM7gdR8RMFC3m5We+wolF3Dj09hd9BgRGa7GPMQuaZCYJkfJPD q9E8pO4cLbfAprILNts7gyH1E63NACQ6y0xclnH3TdXCE3C9bHM9iSp8sV1S1Wg0Vt 8SKHIle9zbXyVliYZH259JSrtqyCn4c1ePEbwbqw= Date: Wed, 12 May 2021 17:02:34 +1000 From: David Gibson To: Thomas Huth Subject: Re: [RFC PATCH 1/5] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Message-ID: References: <20210511155354.3069141-1-philmd@redhat.com> <20210511155354.3069141-2-philmd@redhat.com> <21e0a306-ccfb-a627-1496-14f831fe80a7@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fC7dX5wvbkpFIsSX" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , "Michael S. Tsirkin" , Alexey Kardashevskiy , Richard Henderson , qemu-devel@nongnu.org, Greg Kurz , Igor Mammedov , "open list:ARM TCG CPUs" , qemu-ppc@nongnu.org, John Paul Adrian Glaubitz , Paolo Bonzini , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --fC7dX5wvbkpFIsSX Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 12, 2021 at 06:53:22AM +0200, Thomas Huth wrote: > On 12/05/2021 05.57, Philippe Mathieu-Daud=E9 wrote: > > On 5/12/21 4:24 AM, David Gibson wrote: > > > On Tue, May 11, 2021 at 05:53:50PM +0200, Philippe Mathieu-Daud=E9 wr= ote: > > > > Per the kconfig.rst: > > > >=20 > > > > A device should be listed [...] ``imply`` if (depending on > > > > the QEMU command line) the board may or may not be started > > > > without it. > > > >=20 > > > > This is the case with the NVDIMM device, so use the 'imply' > > > > weak reverse dependency to select the symbol. > > >=20 > > > Uh.. It should definitely be possible to start a pseries machine > > > without NVDIMM. I would have guessed the same for PC. > >=20 > > Yes, this is what this patch does. With it we can build with: > > CONFIG_NVDIMM=3Dn >=20 > But with "imply" you could end up with a PSERIES that does not have NVDIMM > when also using --without-default-devices, couldn't you? Why don't you use > "select" instead of "imply" ? Oh.. clearly I misunderstand the semantics of "imply". If we don't need NVDIMM for PSERIES, why does there need to be any Kconfig connection between them at all? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --fC7dX5wvbkpFIsSX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmCbfYcACgkQbDjKyiDZ s5Jofw/9FCrSSe6dOlMYzTYhM54r6tz+JwuCU4UU4+RscM/Q/splCZ5Hf/gSPTrq tiLti0vUrkTCISkwaTFhuWoZIcrC1uL5wyIcr7cpl0xrw+7q6uz5S4zvXxZZxdS7 ++7MXeyg/FhhdJlSbfUUAqM9ZZ3Yr8Ye2NzjI0qhowEAI6s5i00HPQQe2HvwwtLd snjaTLeE9fioXuv0V+2YISVjsX1rsIOHC/pdNmj948qQhbFeDO+C301wQKJL5s+N ytK/mxUyuRqh1FXf59fuDTukNlrqrTOi96LwZIuuKgwWcBZ1X/x0zn2En2iJQT64 KGWz5PLvdldkVB9yOaMOHAL8mN97BxB2NWNCUBYTztW/m2aLb4SyAj1eastj4a2O 3YH+Clp+PwURJBVWa357BwJFtzegXvSeGf55A+5Rldhv4AWNegHlKbTAl+Lw9ZUE 08CMtsbqkXoRca5I1KZbJdyc7yy4udwAB92YJNCUDNRHpgZ/l98HuJKeJOkmvwJL +KpmAck25ssipmkhbwSKUGZfn3xfeir4xo/DK9KPa1KPFe/MmVK0alvIhPBM5ZBr Y7B7NjoR6q3XdPSZPA6MhfklCvOPiS4DmLaJG7eOdpkZ6WW4pI/wKS8798m8q/EZ xPdFeN6wIH6uZGH5PJ1Hp3dQYoHPw1QgU+7Vr9hcduNrVu+pNEk= =MVAO -----END PGP SIGNATURE----- --fC7dX5wvbkpFIsSX--