All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-staging@lists.linux.dev, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH] staging: rtl8723bs: remove the repeated declaration
Date: Tue, 25 May 2021 18:21:54 +0200	[thread overview]
Message-ID: <YK0kIsNcPHDhvT8D@kroah.com> (raw)
In-Reply-To: <1621923531-21262-1-git-send-email-zhangshaokun@hisilicon.com>

On Tue, May 25, 2021 at 02:18:51PM +0800, Shaokun Zhang wrote:
> Function 'Hal_SetBandwidth' is declared twice, remove the
> repeated declaration.
> 
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  drivers/staging/rtl8723bs/include/rtw_mp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtw_mp.h b/drivers/staging/rtl8723bs/include/rtw_mp.h
> index 2788ad80b114..ea3abee325ef 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_mp.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_mp.h
> @@ -348,7 +348,6 @@ void Hal_SetCarrierSuppressionTx(struct adapter *padapter, u8 bStart);
>  void Hal_SetSingleToneTx(struct adapter *padapter, u8 bStart);
>  void Hal_SetSingleCarrierTx(struct adapter *padapter, u8 bStart);
>  void Hal_SetContinuousTx(struct adapter *padapter, u8 bStart);
> -void Hal_SetBandwidth(struct adapter *padapter);
>  
>  void Hal_SetDataRate(struct adapter *padapter);
>  void Hal_SetChannel(struct adapter *padapter);
> -- 
> 2.7.4
> 
> 

You sent 2 patches with identical subjects, yet they did different
things :(

Please fix up and send a patch series that properly identifies what is
happening here.

thanks,

greg k-h

  reply	other threads:[~2021-05-25 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  6:18 [PATCH] staging: rtl8723bs: remove the repeated declaration Shaokun Zhang
2021-05-25 16:21 ` Greg Kroah-Hartman [this message]
2021-05-26  6:14   ` Shaokun Zhang
2021-05-26  6:22     ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2021-05-25  5:41 Shaokun Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YK0kIsNcPHDhvT8D@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-staging@lists.linux.dev \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.