From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A758C47088 for ; Wed, 26 May 2021 14:02:26 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E003613C9; Wed, 26 May 2021 14:02:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E003613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1llu75-0005UL-F2; Wed, 26 May 2021 14:02:23 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llu74-0005U9-EV for linux-f2fs-devel@lists.sourceforge.net; Wed, 26 May 2021 14:02:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=M/MlrD8MpdY2dHVit2eFCgTTGbgNWZmMBF1oBnjSkU8=; b=FMWLC7izWfNAsfkD4wgqfpfKRI AgMD5FHxxCj8dpV7jaD2jEbrm5oI1Xpj2HL0Dn7ZWaiV/JOQyXtU3n11Q9gJfQ6+kFsWR9p7bvAmD Zxjmmfr9BLikl9OozLFAFmQLtboPUml4/IxRYtAl7VgkTkASlvBbQVD+d0demxKKdUgY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=M/MlrD8MpdY2dHVit2eFCgTTGbgNWZmMBF1oBnjSkU8=; b=Zm6Io5/rnnJzEYXuydC6GN67/8 hkSV/JaRbujCFuxt8gaWVo5JzJ64UQSVpTHA3qLKEd97+KB6VI8TvcqFnE/CFF2qOukNq77X7uog3 gF/CvL8rVWuE7CyUvGGRGuY0gJRa4IjnmZY/MGtlEDVKjDCOfrIxOVQuLut53ZQAByhE=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1llu6w-0002Io-0T for linux-f2fs-devel@lists.sourceforge.net; Wed, 26 May 2021 14:02:23 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9DE4861260; Wed, 26 May 2021 14:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622037729; bh=ZOZJp2WdVCkYj0Es/mOcXSzkMoXCayinr6ObnjkqIPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rh3DN6RLhMBijEbGzaG1PJ4MXvqxfNzwI1Z/BPu7CjTBiU6+2qj7jTxDtAMHT3CAn UteRZbiXBpb0ME66DgLND1TlvprBJd/hYJhePGAZ18Y51bpSEHROrv/lKB0nD9uVg4 FmI98z2dUxRolzq82jOf7/jq/qgTdqbxOv+eoqRTaXOc3ksB/5njDsivcwAZJ6KkWC DjqvHo9iDohV1ECZCZz1QKGs4hHFH33clX8Da3IV1BMBkEJK4Yh8Ih0ppCfLYpfa7z CbsklWG7Ryl4NK26rxpPtSvUZtY8Bz7dmHgmaxWDWiqpUZVUjs50Wk+YzLBeR1ooZF ArGKleioJnk7Q== Date: Wed, 26 May 2021 07:02:08 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20210521190217.2484099-1-jaegeuk@kernel.org> <33c5c36e-b5e1-cecc-fdc4-28a173a5b0a1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <33c5c36e-b5e1-cecc-fdc4-28a173a5b0a1@huawei.com> X-Headers-End: 1llu6w-0002Io-0T Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: immutable file can have null address in compressed chunk X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 05/26, Chao Yu wrote: > On 2021/5/22 3:02, Jaegeuk Kim wrote: > > If we released compressed blocks having an immutable bit, we can see less > > number of compressed block addresses. Let's fix wrong BUG_ON. > > > > Signed-off-by: Jaegeuk Kim > > It looks it will be better to merge this into > ("f2fs: compress: remove unneeded preallocation")? Right, fixed there. :) > > Reviewed-by: Chao Yu > > Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F8BDC47088 for ; Wed, 26 May 2021 14:02:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64959613D3 for ; Wed, 26 May 2021 14:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234262AbhEZODn (ORCPT ); Wed, 26 May 2021 10:03:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:43424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232641AbhEZODl (ORCPT ); Wed, 26 May 2021 10:03:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9DE4861260; Wed, 26 May 2021 14:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622037729; bh=ZOZJp2WdVCkYj0Es/mOcXSzkMoXCayinr6ObnjkqIPY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rh3DN6RLhMBijEbGzaG1PJ4MXvqxfNzwI1Z/BPu7CjTBiU6+2qj7jTxDtAMHT3CAn UteRZbiXBpb0ME66DgLND1TlvprBJd/hYJhePGAZ18Y51bpSEHROrv/lKB0nD9uVg4 FmI98z2dUxRolzq82jOf7/jq/qgTdqbxOv+eoqRTaXOc3ksB/5njDsivcwAZJ6KkWC DjqvHo9iDohV1ECZCZz1QKGs4hHFH33clX8Da3IV1BMBkEJK4Yh8Ih0ppCfLYpfa7z CbsklWG7Ryl4NK26rxpPtSvUZtY8Bz7dmHgmaxWDWiqpUZVUjs50Wk+YzLBeR1ooZF ArGKleioJnk7Q== Date: Wed, 26 May 2021 07:02:08 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: immutable file can have null address in compressed chunk Message-ID: References: <20210521190217.2484099-1-jaegeuk@kernel.org> <33c5c36e-b5e1-cecc-fdc4-28a173a5b0a1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33c5c36e-b5e1-cecc-fdc4-28a173a5b0a1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26, Chao Yu wrote: > On 2021/5/22 3:02, Jaegeuk Kim wrote: > > If we released compressed blocks having an immutable bit, we can see less > > number of compressed block addresses. Let's fix wrong BUG_ON. > > > > Signed-off-by: Jaegeuk Kim > > It looks it will be better to merge this into > ("f2fs: compress: remove unneeded preallocation")? Right, fixed there. :) > > Reviewed-by: Chao Yu > > Thanks,