From: Greg KH <gregkh@linuxfoundation.org>
To: Kai Ye <yekai13@huawei.com>
Cc: linux-accelerators@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
zhangfei.gao@linaro.org, wangzhou1@hisilicon.com
Subject: Re: [PATCH] uacce: use sysfs_emit instead of sprintf
Date: Mon, 17 May 2021 12:36:08 +0200 [thread overview]
Message-ID: <YKJHGP9LTnCRfIx6@kroah.com> (raw)
In-Reply-To: <1621247137-42693-1-git-send-email-yekai13@huawei.com>
On Mon, May 17, 2021 at 06:25:37PM +0800, Kai Ye wrote:
> Use the sysfs_emit to replace sprintf.
That says _what_ you did, not _why_ you are doing this. What problem
are you solving with this change?
thanks,
greg k-h
next prev parent reply other threads:[~2021-05-17 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 10:25 [PATCH] uacce: use sysfs_emit instead of sprintf Kai Ye
2021-05-17 10:36 ` Greg KH [this message]
2021-05-17 11:49 ` yekai(A)
2021-05-17 11:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKJHGP9LTnCRfIx6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=yekai13@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.