From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2481FC433ED for ; Tue, 18 May 2021 09:19:21 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C80E76135D for ; Tue, 18 May 2021 09:19:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C80E76135D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8F74040390; Tue, 18 May 2021 09:19:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hujFv0Nfgsbu; Tue, 18 May 2021 09:19:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTP id 7A7F9401F1; Tue, 18 May 2021 09:19:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4BAB4C000D; Tue, 18 May 2021 09:19:19 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 94342C0001 for ; Tue, 18 May 2021 09:19:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 76CCA83DC5 for ; Tue, 18 May 2021 09:19:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MRGjQUVAplHQ for ; Tue, 18 May 2021 09:19:17 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by smtp1.osuosl.org (Postfix) with ESMTPS id DA565832AA for ; Tue, 18 May 2021 09:19:16 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 2B71D2FA; Tue, 18 May 2021 11:19:15 +0200 (CEST) Date: Tue, 18 May 2021 11:19:13 +0200 From: Joerg Roedel To: Jean-Philippe Brucker Subject: Re: [PATCH] iommu/amd: Clear DMA ops when switching domain Message-ID: References: <20210422094216.2282097-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210422094216.2282097-1-jean-philippe@linaro.org> Cc: robin.murphy@arm.com, iommu@lists.linux-foundation.org, will@kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Apr 22, 2021 at 11:42:19AM +0200, Jean-Philippe Brucker wrote: > Since commit 08a27c1c3ecf ("iommu: Add support to change default domain > of an iommu group") a user can switch a device between IOMMU and direct > DMA through sysfs. This doesn't work for AMD IOMMU at the moment because > dev->dma_ops is not cleared when switching from a DMA to an identity > IOMMU domain. The DMA layer thus attempts to use the dma-iommu ops on an > identity domain, causing an oops: > > # echo 0000:00:05.0 > /sys/sys/bus/pci/drivers/e1000e/unbind > # echo identity > /sys/bus/pci/devices/0000:00:05.0/iommu_group/type > # echo 0000:00:05.0 > /sys/sys/bus/pci/drivers/e1000e/bind > ... > BUG: kernel NULL pointer dereference, address: 0000000000000028 > ... > Call Trace: > iommu_dma_alloc > e1000e_setup_tx_resources > e1000e_open > > Since iommu_change_dev_def_domain() calls probe_finalize() again, clear > the dma_ops there like Vt-d does. > > Fixes: 08a27c1c3ecf ("iommu: Add support to change default domain of an iommu group") > Signed-off-by: Jean-Philippe Brucker Applied for v5.13, thanks Jean-Philippe. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu