All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony PERARD <anthony.perard@citrix.com>
To: Julien Grall <julien@xen.org>
Cc: <xen-devel@lists.xenproject.org>,
	Julien Grall <jgrall@amazon.com>,
	"Ian Jackson" <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 2/2] tools/console: Use const whenever we point to literal strings
Date: Tue, 18 May 2021 17:01:57 +0100	[thread overview]
Message-ID: <YKPk9QJJS6kMy6uP@perard> (raw)
In-Reply-To: <20210518140134.31541-3-julien@xen.org>

On Tue, May 18, 2021 at 03:01:34PM +0100, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> Literal strings are not meant to be modified. So we should use const
> char * rather than char * when we want to store a pointer to them.
> 
> Take the opportunity to remove the cast (char *) in console_init(). It
> is unnecessary and will remove the const.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> Acked-by: Wei Liu <wl@xen.org>
> 
> ---
>     Changes in v2:
>         - Remove the cast (char *) in console_init()

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD


  reply	other threads:[~2021-05-18 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 14:01 [PATCH v2 0/2] Use const whenever we point to literal strings (take 1) Julien Grall
2021-05-18 14:01 ` [PATCH v2 1/2] xen/char: console: Use const whenever we point to literal strings Julien Grall
2021-05-18 14:39   ` Luca Fancellu
2021-05-18 15:08   ` Jan Beulich
2021-05-18 14:01 ` [PATCH v2 2/2] tools/console: " Julien Grall
2021-05-18 16:01   ` Anthony PERARD [this message]
2021-05-26 15:22 ` [PATCH v2 0/2] Use const whenever we point to literal strings (take 1) Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKPk9QJJS6kMy6uP@perard \
    --to=anthony.perard@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=jgrall@amazon.com \
    --cc=julien@xen.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.