From: Dan Carpenter <dan.carpenter@oracle.com>
To: danielj@mellanox.com
Cc: linux-rdma@vger.kernel.org
Subject: [bug report] {net, IB}/mlx5: Manage port association for multiport RoCE
Date: Wed, 19 May 2021 17:18:33 +0300 [thread overview]
Message-ID: <YKUeOV14j98OJIj7@mwanda> (raw)
In-Reply-To: <20210518082855.GB32682@kadam>
Hello Daniel Jurgens,
The patch 32f69e4be269: "{net, IB}/mlx5: Manage port association for
multiport RoCE" from Jan 4, 2018, leads to the following static
checker warning:
drivers/infiniband/hw/mlx5/main.c:3285 mlx5_ib_init_multiport_master()
warn: iterator 'mpi->list.next' changed during iteration
drivers/infiniband/hw/mlx5/main.c
3285 list_for_each_entry(mpi, &mlx5_ib_unaffiliated_port_list,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
We're iterating through the unafiliated list.
3286 list) {
3287 if (dev->sys_image_guid == mpi->sys_image_guid &&
3288 (mlx5_core_native_port_num(mpi->mdev) - 1) == i) {
3289 bound = mlx5_ib_bind_slave_port(dev, mpi);
The mlx5_ib_bind_slave_port() function returns true on success and
false on failure. On the failure path it calls:
mlx5_ib_unbind_slave_port(ibdev, mpi);
Which adds our "mpi" as the last item on the unaffiliated list. I don't
think anything good can come from adding a list item to a list twice.
3290 }
3291
3292 if (bound) {
3293 dev_dbg(mpi->mdev->device,
3294 "removing port from unaffiliated list.\n");
3295 mlx5_ib_dbg(dev, "port %d bound\n", i + 1);
3296 list_del(&mpi->list);
3297 break;
3298 }
3299 }
3300 if (!bound)
3301 mlx5_ib_dbg(dev, "no free port found for port %d\n",
3302 i + 1);
regards,
dan carpenter
next prev parent reply other threads:[~2021-05-19 14:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 16:06 [PATCH 1/6] staging: rtl8188eu: use safe iterator in rtw_free_network_queue Martin Kaiser
2021-05-16 16:06 ` [PATCH 2/6] staging: rtl8188eu: use safe iterator in rtw_free_all_stainfo Martin Kaiser
2021-05-16 19:24 ` Guenter Roeck
2021-05-16 16:06 ` [PATCH 3/6] staging: rtl8188eu: use safe iterator in expire_timeout_chk Martin Kaiser
2021-05-16 19:24 ` Guenter Roeck
2021-05-16 16:06 ` [PATCH 4/6] staging: rtl8188eu: use safe iterator in rtw_acl_remove_sta Martin Kaiser
2021-05-16 19:24 ` Guenter Roeck
2021-05-16 16:06 ` [PATCH 5/6] staging: rtl8188eu: use safe iterator in rtw_sta_flush Martin Kaiser
2021-05-16 19:24 ` Guenter Roeck
2021-05-16 16:06 ` [PATCH 6/6] staging: rtl8188eu: use safe iterator in rtw_free_xmitframe_queue Martin Kaiser
2021-05-16 19:24 ` Guenter Roeck
2021-05-16 19:24 ` [PATCH 1/6] staging: rtl8188eu: use safe iterator in rtw_free_network_queue Guenter Roeck
2021-05-16 20:03 ` Christophe JAILLET
2021-05-17 20:21 ` Martin Kaiser
2021-05-17 15:57 ` Dan Carpenter
2021-05-18 8:28 ` Dan Carpenter
2021-05-19 14:16 ` Dan Carpenter
2021-05-19 14:16 ` [PATCH] staging: emxx_udc: fix loop in _nbu2ss_nuke() Dan Carpenter
2021-05-19 14:17 ` [PATCH] w1: fix loop in w1_fini() Dan Carpenter
2023-05-08 8:59 ` (subset) " Krzysztof Kozlowski
2021-05-19 14:18 ` Dan Carpenter [this message]
2021-05-20 8:09 ` [bug report] {net, IB}/mlx5: Manage port association for multiport RoCE Leon Romanovsky
2021-05-19 14:19 ` [bug report] Bluetooth: L2CAP: Add initial code for Enhanced Credit Based Mode Dan Carpenter
2021-05-19 14:20 ` [PATCH] scsi: libsas: use _safe() loop in sas_resume_port() Dan Carpenter
2021-05-19 14:48 ` John Garry
2021-05-22 4:40 ` Martin K. Petersen
2021-05-17 20:18 ` [PATCH v2 1/6] staging: rtl8188eu: use safe iterator in rtw_free_network_queue Martin Kaiser
2021-05-17 20:18 ` [PATCH v2 2/6] staging: rtl8188eu: use safe iterator in rtw_free_all_stainfo Martin Kaiser
2021-05-17 20:32 ` Guenter Roeck
2021-05-17 20:18 ` [PATCH v2 3/6] staging: rtl8188eu: use safe iterator in expire_timeout_chk Martin Kaiser
2021-05-17 20:33 ` Guenter Roeck
2021-05-17 20:18 ` [PATCH v2 4/6] staging: rtl8188eu: use safe iterator in rtw_acl_remove_sta Martin Kaiser
2021-05-17 20:34 ` Guenter Roeck
2021-05-17 20:18 ` [PATCH v2 5/6] staging: rtl8188eu: use safe iterator in rtw_sta_flush Martin Kaiser
2021-05-17 20:34 ` Guenter Roeck
2021-05-17 20:18 ` [PATCH v2 6/6] staging: rtl8188eu: use safe iterator in rtw_free_xmitframe_queue Martin Kaiser
2021-05-17 20:35 ` Guenter Roeck
2021-05-17 20:30 ` [PATCH v2 1/6] staging: rtl8188eu: use safe iterator in rtw_free_network_queue Guenter Roeck
2021-05-18 7:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKUeOV14j98OJIj7@mwanda \
--to=dan.carpenter@oracle.com \
--cc=danielj@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.