From: Sergey Matyukevich <geomatsi@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/dhcp: add host-gawk to dependencies and build environment
Date: Fri, 21 May 2021 00:11:06 +0300 [thread overview]
Message-ID: <YKbQauodJeCyvNih@curiosity> (raw)
In-Reply-To: <5ade5409-df01-2cde-7bfb-7767c04138f2@mind.be>
Hello Arnout,
> > DHCP package may silently fail to install binaries to the target image.
> > The problem occurs when buildroot configuration and build host provide
> > different flavors of awk. For instance, mawk on build host and gawk in
> > buildroot output/host. In this case isc-dhcp configure script detects
> > gawk in output/host and generates Makefiles specifying gawk without
> > absolute path. During Buildroot installation phase, those Makefiles
> > are used to install dhcp binaries. They attempt to use gawk without
> > absolute path. However build host does not have gawk.
> >
> > To resolve the issue add host-gawk to the list of dhcp dependencies
> > and explicitely specify absolute path to host-gawk.
> >
> > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
>
> Heiko recently posted a patch that does the same thing, and I applied that one
> because it only adds the dependency when the server is enabled (client doesn't
> need gawk).
I did some build tests in support/docker/Dockerfile image. It turns out
that the patch suggested by Heiko is not enough. It adds host-gawk to
dependencies, but it does not set explicit path to this gawk in dhcp
configuration scripts. As a result, the same issue can be reproduced
immediately even with uclibc. The build test is as follows:
- use docker builder image described in support/docker/Dockerfile
-- note that this image provides mawk flavor
- start from default qemu_x86_defconfig
- enable both isc-dhcp client and server
As a result, neighter dhclient nor dhcpd are installed into
output/target. Previously, before the applied patch, the issue could be
reproduced only with glibc which pulled host-gawk dependency. Besides,
unless I missed something in my tests, dhclient installation is also
impacted, so host-gawk should be added globally.
I will update my patch and send v3.
Regards,
Sergey
prev parent reply other threads:[~2021-05-20 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 14:54 [Buildroot] [PATCH v2 1/1] package/dhcp: add host-gawk to dependencies and build environment Sergey Matyukevich
2021-05-20 18:22 ` Arnout Vandecappelle
2021-05-20 21:11 ` Sergey Matyukevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKbQauodJeCyvNih@curiosity \
--to=geomatsi@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.