From: Greg KH <gregkh@linuxfoundation.org>
To: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
Cc: fabioaiuto83@gmail.com, ross.schm.dev@gmail.com,
straube.linux@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Resend] [PATCH 1/2] [RFC] staging: rtl8723bs: refactor to reduce indents
Date: Sat, 22 May 2021 11:26:50 +0200 [thread overview]
Message-ID: <YKjOWtwarhM99dXc@kroah.com> (raw)
In-Reply-To: <20210522092024.65018-2-chouhan.shreyansh630@gmail.com>
On Sat, May 22, 2021 at 02:50:23PM +0530, Shreyansh Chouhan wrote:
> Reduce the number of indents in rtw_wlan_util.c file by refactoring the
> code.
>
> Moved the part of code that rearranged ac paramaters in the function
> WMMOnAssocResp to a separate function named sort_wmm_ac_params. It takes
> both the array of ac params and their indexes as arguments and sorts them.
> Has return type void.
>
> Moved the part of code that checked for the realtek vendor in the
> function check_assoc_AP to a separate function named
> get_realtek_assoc_AP_vender. It takes a pointer to struct
> ndis_80211_var_ie as an argument and returns a u32 realtek vendor.
>
> Signed-off-by: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
> ---
> .../staging/rtl8723bs/core/rtw_wlan_util.c | 108 +++++++++---------
> 1 file changed, 56 insertions(+), 52 deletions(-)
Why is [RFC] in the subject line? Do you not want these merged?
confused,
greg k-h
next prev parent reply other threads:[~2021-05-22 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 9:20 [Resend] [PATCH 0/2] [RFC] staging: rtl8723bs: refactor to reduce indents Shreyansh Chouhan
2021-05-22 9:20 ` [Resend] [PATCH 1/2] " Shreyansh Chouhan
2021-05-22 9:26 ` Greg KH [this message]
2021-05-22 9:36 ` Shreyansh Chouhan
2021-05-22 9:20 ` [Resend] [PATCH 2/2] [RFC] staging: rtl8723bs: remove unnecessary braces from conditionals Shreyansh Chouhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKjOWtwarhM99dXc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chouhan.shreyansh630@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ross.schm.dev@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.