From: Brian Foster <bfoster@redhat.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] iomap: resched ioend completion when in non-atomic context
Date: Mon, 24 May 2021 07:57:48 -0400 [thread overview]
Message-ID: <YKuUvHB6HUyQ6TWD@bfoster> (raw)
In-Reply-To: <YKi2hwnJMbLYtkmb@T590>
On Sat, May 22, 2021 at 03:45:11PM +0800, Ming Lei wrote:
> On Mon, May 17, 2021 at 01:17:20PM -0400, Brian Foster wrote:
> > The iomap ioend mechanism has the ability to construct very large,
> > contiguous bios and/or bio chains. This has been reported to lead to
>
> BTW, it is actually wrong to complete a large bio chains in
> iomap_finish_ioend(), which may risk in bio allocation deadlock, cause
> bio_alloc_bioset() relies on bio submission to make forward progress. But
> it becomes not true when all chained bios are freed just after the whole
> ioend is done since all chained bios(except for the one embedded in ioend)
> are allocated from same bioset(fs_bio_set).
>
Interesting. Do you have a reproducer (or error report) for this? Is it
addressed by the next patch, or are further changes required?
Brian
>
> Thanks,
> Ming
>
next prev parent reply other threads:[~2021-05-24 11:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 17:17 [PATCH v3 0/3] iomap: avoid soft lockup warnings on large ioends Brian Foster
2021-05-17 17:17 ` [PATCH v3 1/3] iomap: resched ioend completion when in non-atomic context Brian Foster
2021-05-17 17:54 ` Matthew Wilcox
2021-05-18 11:38 ` Brian Foster
2021-05-20 21:58 ` Darrick J. Wong
2021-05-24 11:57 ` Brian Foster
2021-05-24 16:53 ` Darrick J. Wong
2021-05-26 1:19 ` Darrick J. Wong
2021-05-22 7:45 ` Ming Lei
2021-05-24 11:57 ` Brian Foster [this message]
2021-05-24 14:11 ` Ming Lei
2021-05-17 17:17 ` [PATCH v3 2/3] xfs: kick large ioends to completion workqueue Brian Foster
2021-05-26 1:20 ` Darrick J. Wong
2021-05-17 17:17 ` [PATCH RFC v3 3/3] iomap: bound ioend size to 4096 pages Brian Foster
2021-05-19 13:28 ` Christoph Hellwig
2021-05-19 14:52 ` Brian Foster
2021-05-20 23:27 ` Darrick J. Wong
2021-05-24 12:02 ` Brian Foster
2021-05-25 4:20 ` Darrick J. Wong
2021-05-25 4:29 ` Damien Le Moal
2021-05-25 7:13 ` Dave Chinner
2021-05-25 9:07 ` Andreas Gruenbacher
2021-05-26 2:12 ` Matthew Wilcox
2021-05-26 3:32 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKuUvHB6HUyQ6TWD@bfoster \
--to=bfoster@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.