From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F40C47087 for ; Tue, 25 May 2021 06:28:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6871E61413 for ; Tue, 25 May 2021 06:28:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231231AbhEYG3k (ORCPT ); Tue, 25 May 2021 02:29:40 -0400 Received: from muru.com ([72.249.23.125]:60060 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230509AbhEYG3c (ORCPT ); Tue, 25 May 2021 02:29:32 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BF01D807E; Tue, 25 May 2021 06:28:06 +0000 (UTC) Date: Tue, 25 May 2021 09:27:58 +0300 From: Tony Lindgren To: Suman Anna Cc: Gowtham Tammana , bcousson@baylibre.com, robh+dt@kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grygorii Strashko , Nisanth Menon Subject: Re: [PATCH] ARM: dts: DRA7x: Fix duplicate USB4 device node Message-ID: References: <20210521211851.14674-1-g-tammana@ti.com> <9445e5c9-819c-0aed-f96f-b1ac2ea7d13e@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9445e5c9-819c-0aed-f96f-b1ac2ea7d13e@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Suman Anna [210524 15:24]: > This can be fixed in couple of different ways, and I see there have been > different commits that have ultimately caused this. > 6b14eb4705d6 ("ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi") > 549fce068a31 ("ARM: dts: dra7: Add l4 interconnect hierarchy and ti-sysc data" > bcbb63b80284 (ARM: dts: dra7: Separate AM57 dtsi files") > c7b72abca61e ("ARM: OMAP2+: Drop legacy platform data for dra7 dwc3") > > Would you prefer that we just drop the USB4 target-module reference in > dra7-l4.dtsi following the first commit? Looking at commit 549fce068a31 above, we have dra7-l4.dtsi define a module at 0x48940000. But maybe the module is only used for dwc on dra74x? If this controller instance is on all dra7 SoCs, then it should be in dra7-l4.dtsi. If the controller instance is only on dra74x, it should be only in dra74x.dtsi file. Sorry sounds like I have confused some hardware differences along the way. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EF59C2B9F8 for ; Tue, 25 May 2021 06:31:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE9B9610A5 for ; Tue, 25 May 2021 06:31:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE9B9610A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aMcASwfp6CzWPwksupH9Bt5fpvdeByVzL4qSBpCcunM=; b=l2iGDnZXpsnWWZ qNZz4EBoX2uSY1/wxvma36UMGBwID8EgVP1e4/Cg/jVDNrQrVgmoQ0KUk4wPywTakkRM6DROvCefP zq9rm4ksGOemno1QG/iHAd0ldHDPnXIhwsbacuQO48vKs4YXOU5Kt37eUSbH5/adG90OzdBTYrUYP tlhdYi8x11CWU85dPPYKW7TtkZS74OjbOjgsEYKsCEg1ZqcFcRkH4cmiU8MwKrjHIxpAbrKQ+qMxN 4C3Lo36/oqj70lQp7m6IGW4ciqj+qiunSJRl58i/d6eP1WyqiH6sxIw0x+/TmV1R7C6KCZ2dtvbeq HkCQ0axxdfWBzZhck7lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llQZZ-003cwu-8B; Tue, 25 May 2021 06:29:49 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llQXq-003cQs-Of for linux-arm-kernel@lists.infradead.org; Tue, 25 May 2021 06:28:04 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BF01D807E; Tue, 25 May 2021 06:28:06 +0000 (UTC) Date: Tue, 25 May 2021 09:27:58 +0300 From: Tony Lindgren To: Suman Anna Cc: Gowtham Tammana , bcousson@baylibre.com, robh+dt@kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Grygorii Strashko , Nisanth Menon Subject: Re: [PATCH] ARM: dts: DRA7x: Fix duplicate USB4 device node Message-ID: References: <20210521211851.14674-1-g-tammana@ti.com> <9445e5c9-819c-0aed-f96f-b1ac2ea7d13e@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9445e5c9-819c-0aed-f96f-b1ac2ea7d13e@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_232802_883490_995A1C4A X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Suman Anna [210524 15:24]: > This can be fixed in couple of different ways, and I see there have been > different commits that have ultimately caused this. > 6b14eb4705d6 ("ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi") > 549fce068a31 ("ARM: dts: dra7: Add l4 interconnect hierarchy and ti-sysc data" > bcbb63b80284 (ARM: dts: dra7: Separate AM57 dtsi files") > c7b72abca61e ("ARM: OMAP2+: Drop legacy platform data for dra7 dwc3") > > Would you prefer that we just drop the USB4 target-module reference in > dra7-l4.dtsi following the first commit? Looking at commit 549fce068a31 above, we have dra7-l4.dtsi define a module at 0x48940000. But maybe the module is only used for dwc on dra74x? If this controller instance is on all dra7 SoCs, then it should be in dra7-l4.dtsi. If the controller instance is only on dra74x, it should be only in dra74x.dtsi file. Sorry sounds like I have confused some hardware differences along the way. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel