From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3442116370689917429==" MIME-Version: 1.0 From: Leon Romanovsky To: kbuild-all@lists.01.org Subject: Re: [PATCH rdma-next v1 12/15] RDMA/hfi1: Use attributes for the port sysfs Date: Mon, 07 Jun 2021 16:31:31 +0300 Message-ID: In-Reply-To: <202106072139.6TXj5TQf-lkp@intel.com> List-Id: --===============3442116370689917429== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2021 at 09:07:09PM +0800, kernel test robot wrote: > Hi Leon, > = > I love your patch! Perhaps something to improve: > = > [auto build test WARNING on rdma/for-next] > [also build test WARNING on next-20210607] > [cannot apply to v5.13-rc5] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/0day-ci/linux/commits/Leon-Romanovsky/Reorgani= ze-sysfs-file-creation-for-struct-ib_devices/20210607-161959 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for= -next > config: x86_64-randconfig-b001-20210607 (attached as .config) > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ae97= 3380c5f6be77ce395022be40350942260be9) > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install x86_64 cross compiling tool for clang build > # apt-get install binutils-x86-64-linux-gnu > # https://github.com/0day-ci/linux/commit/1e8e4eebe16212ad4853b90= 2eb8d045fce03f826 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Leon-Romanovsky/Reorganize-sysfs= -file-creation-for-struct-ib_devices/20210607-161959 > git checkout 1e8e4eebe16212ad4853b902eb8d045fce03f826 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross AR= CH=3Dx86_64 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All warnings (new ones prefixed by >>): > = > >> drivers/infiniband/hw/hfi1/sysfs.c:175:37: warning: unused variable 'p= ort_cc_group' [-Wunused-const-variable] > static const struct attribute_group port_cc_group =3D { > ^ > 1 warning generated. Jason, You forgot to call to rdma_set_device_sysfs_group(... , port_cc_group) in hfi1. Thanks > = > = > vim +/port_cc_group +175 drivers/infiniband/hw/hfi1/sysfs.c > = > 174 = > > 175 static const struct attribute_group port_cc_group =3D { > 176 .name =3D "CCMgtA", > 177 .attrs =3D port_cc_attributes, > 178 .bin_attrs =3D port_cc_bin_attributes, > 179 }; > 180 = > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============3442116370689917429==--