From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7A2DC47082 for ; Mon, 7 Jun 2021 18:32:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFF8961059 for ; Mon, 7 Jun 2021 18:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbhFGSeY (ORCPT ); Mon, 7 Jun 2021 14:34:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhFGSeY (ORCPT ); Mon, 7 Jun 2021 14:34:24 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C4B5C061766 for ; Mon, 7 Jun 2021 11:32:33 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id k15so13753253pfp.6 for ; Mon, 07 Jun 2021 11:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+e6j0DkhXs3c5ZQ2veNO7IXOw8xfMmU+JwFBGETHbB4=; b=esS2wXIpTMmyEb3BcLL2uwFPK4JYIbUbezpQ27/MnSETF/F3Gop/j2gmnXPCAuC/uf fT4y+JvbR7iro7flaDlpjc+EVcGkOK7qNbU743WYVTUcXtriGZYuWI4NzJg0ebkdcUrN Mj+9aJSqhRSVt6et3akwqFQx8WIjDRQ/DpjoE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+e6j0DkhXs3c5ZQ2veNO7IXOw8xfMmU+JwFBGETHbB4=; b=ekLDkAAMj4KjiyQnDzjdJUZ2FwS76cuFksyEGgZu8edfllHGb2BFugtW1CRZ8XydAI GBcMPI3xGuuZK7wabHmP82ZSSHLdNmgFz2CECxR6hK7kHKYBuV4yJgl2RrYBma3+ipjP IVRlsSzmu1NEl9hfydr2s3BFxeWn67fd+ea7TBptvh6u1JGzwvjHNlPJyKpvTdG4IB3C HVMSLA3/mgcmRp1cHjB+HCRfXxqC3putFnRd+4gxO897yP0hvLpLVit05PNYXI4zX1oR EK25+eXbqhsw8Fwf1W0rejPxboadt8WmyeOIx6Kfi7fd86lIsd6MHaylK+nlMV3YD1vx Vzlg== X-Gm-Message-State: AOAM533NI5vN6KxQa4q23QXA7bK1nXU304YduD2QFAd4+4PfPwgAtpg+ Q3oLqSU9o8jEacAHV//0PrTEkA== X-Google-Smtp-Source: ABdhPJzi3DYzJwI/BVZMs7JCqw91yLvsX1cRd0demFVjrZqacogwt7V3Qh18aO2T3hK84psz9cWdNA== X-Received: by 2002:a63:e316:: with SMTP id f22mr18654277pgh.100.1623090752641; Mon, 07 Jun 2021 11:32:32 -0700 (PDT) Received: from localhost ([2620:15c:202:201:312d:da15:9317:e223]) by smtp.gmail.com with UTF8SMTPSA id l3sm9504603pgb.77.2021.06.07.11.32.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 11:32:32 -0700 (PDT) Date: Mon, 7 Jun 2021 11:32:31 -0700 From: Matthias Kaehlcke To: Greg Kroah-Hartman Cc: kernel test robot , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , kbuild-all@lists.01.org, Michal Simek , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Bastien Nocera , linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 2/5] USB: misc: Add onboard_usb_hub driver Message-ID: References: <20210604144027.v11.2.I7c9a1f1d6ced41dd8310e8a03da666a32364e790@changeid> <202106050751.uNo0uAEm-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jun 07, 2021 at 08:23:43PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 07, 2021 at 10:51:57AM -0700, Matthias Kaehlcke wrote: > > On Sat, Jun 05, 2021 at 07:18:38AM +0800, kernel test robot wrote: > > > Hi Matthias, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test WARNING on next-20210604] > > > [also build test WARNING on v5.13-rc4] > > > [cannot apply to usb/usb-testing robh/for-next char-misc/char-misc-testing driver-core/driver-core-testing linus/master v5.13-rc4 v5.13-rc3 v5.13-rc2] > > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch] > > > > > > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210605-054213 > > > base: ccc252d2e818f6a479441119ad453c3ce7c7c461 > > > config: arc-allyesconfig (attached as .config) > > > compiler: arceb-elf-gcc (GCC) 9.3.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/0day-ci/linux/commit/7107f99a12058b7147342c6f763d026102bd6606 > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-Add-onboard_usb_hub-driver/20210605-054213 > > > git checkout 7107f99a12058b7147342c6f763d026102bd6606 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All warnings (new ones prefixed by >>): > > > > > > >> drivers/usb/misc/onboard_usb_hub.c:400:6: warning: no previous prototype for 'onboard_hub_create_pdevs' [-Wmissing-prototypes] > > > 400 | void onboard_hub_create_pdevs(struct usb_device *parent_hub, struct list_head *pdev_list) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > >> drivers/usb/misc/onboard_usb_hub.c:458:6: warning: no previous prototype for 'onboard_hub_destroy_pdevs' [-Wmissing-prototypes] > > > 458 | void onboard_hub_destroy_pdevs(struct list_head *pdev_list) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > > Oh, I wasn't aware that prototypes are required for public functions. > > How else can they be called? Well, there are prototypes in include/linux/usb/onboard_hub.h, however this header isn't included (anymore) by the driver itself to avoid conflicts when COMPILE_TEST=y (see https://lkml.org/lkml/2021/5/25/975). From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2058436029133259831==" MIME-Version: 1.0 From: Matthias Kaehlcke To: kbuild-all@lists.01.org Subject: Re: [PATCH v11 2/5] USB: misc: Add onboard_usb_hub driver Date: Mon, 07 Jun 2021 11:32:31 -0700 Message-ID: In-Reply-To: List-Id: --===============2058436029133259831== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2021 at 08:23:43PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 07, 2021 at 10:51:57AM -0700, Matthias Kaehlcke wrote: > > On Sat, Jun 05, 2021 at 07:18:38AM +0800, kernel test robot wrote: > > > Hi Matthias, > > > = > > > I love your patch! Perhaps something to improve: > > > = > > > [auto build test WARNING on next-20210604] > > > [also build test WARNING on v5.13-rc4] > > > [cannot apply to usb/usb-testing robh/for-next char-misc/char-misc-te= sting driver-core/driver-core-testing linus/master v5.13-rc4 v5.13-rc3 v5.1= 3-rc2] > > > [If your patch is applied to the wrong git tree, kindly drop us a not= e. > > > And when submitting patch, we suggest to use '--base' as documented in > > > https://git-scm.com/docs/git-format-patch] > > > = > > > url: https://github.com/0day-ci/linux/commits/Matthias-Kaehlcke/US= B-misc-Add-onboard_usb_hub-driver/20210605-054213 > > > base: ccc252d2e818f6a479441119ad453c3ce7c7c461 > > > config: arc-allyesconfig (attached as .config) > > > compiler: arceb-elf-gcc (GCC) 9.3.0 > > > reproduce (this is a W=3D1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master= /sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://github.com/0day-ci/linux/commit/7107f99a12058b71473= 42c6f763d026102bd6606 > > > git remote add linux-review https://github.com/0day-ci/linux > > > git fetch --no-tags linux-review Matthias-Kaehlcke/USB-misc-A= dd-onboard_usb_hub-driver/20210605-054213 > > > git checkout 7107f99a12058b7147342c6f763d026102bd6606 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.= cross ARCH=3Darc = > > > = > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > = > > > All warnings (new ones prefixed by >>): > > > = > > > >> drivers/usb/misc/onboard_usb_hub.c:400:6: warning: no previous pro= totype for 'onboard_hub_create_pdevs' [-Wmissing-prototypes] > > > 400 | void onboard_hub_create_pdevs(struct usb_device *parent_hu= b, struct list_head *pdev_list) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > >> drivers/usb/misc/onboard_usb_hub.c:458:6: warning: no previous pro= totype for 'onboard_hub_destroy_pdevs' [-Wmissing-prototypes] > > > 458 | void onboard_hub_destroy_pdevs(struct list_head *pdev_list) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > = > > Oh, I wasn't aware that prototypes are required for public functions. > = > How else can they be called? Well, there are prototypes in include/linux/usb/onboard_hub.h, however this header isn't included (anymore) by the driver itself to avoid conflicts when COMPILE_TEST=3Dy (see https://lkml.org/lkml/2021/5/25/975). --===============2058436029133259831==--